13426 2019-07-03 14:59:04 +0000 Loses track of data if file rename()d to same name 2020-08-28 09:39:05 +0000 1 1 6 Yocto Project Subprojects Pseudo pseudo master x86 Multiple RESOLVED FIXED Medium+ normal 3.2 M3 1 ross.burton joe.slater randy.macleod seebs yp.pseudo.watcher yp.watcher --- --- No (bug/feature does not impact docs) oldest_to_newest 84362 0 4535 ross.burton 2019-07-03 14:59:04 +0000 Created attachment 4535 Test case Nothing stops rename() being told to rename foo to foo. For example this doesn't produe an error: $ touch foo $ python3 -c "import os; os.rename('foo', 'foo')" However when run under pseudo the rename() wrappers throw away the information for the old name, losing ownership data etc. Attached is a test case to demonstrate this. A simple strcmp in the rename() wrapper is enough to fix this, although that's both horrible and doesn't fix renameat(). 86053 1 randy.macleod 2020-01-16 16:19:31 +0000 Seems mostly harmless but it might be causing some autobuilder failures or other problems. 88011 2 joe.slater 2020-08-21 13:07:39 +0000 Only just started looking, but it seems like if the target of a rename exists, info about it is deleted. Then, the info for the renamed file is assigned to the rename target. Of course, in this case, that info is gone. 88036 3 joe.slater 2020-08-25 15:56:26 +0000 In the appropriate "guts" files, move the check for old/new identity to before playing with the pseudo database. Works for rename() and should work for renameat() and renameat2(). 88040 4 4716 joe.slater 2020-08-26 12:01:50 +0000 Created attachment 4716 testcase for rename() and renameat() 88059 5 randy.macleod 2020-08-28 09:39:05 +0000 merged to master and seems to be passing tests so closing: https://git.openembedded.org/openembedded-core/commit/?id=6b3d109f42385ad1cf1f297a6c06ea7eb6509f26 4535 2019-07-03 14:59:04 +0000 2019-07-03 14:59:04 +0000 Test case test-rename-same.sh text/plain 465 ross.burton IyEvYmluL2Jhc2gKIwojIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBMR1BMLTIuMS1vbmx5CiMK CnNldCAtZQoKcm0gLWYgZjEKCnRvdWNoIGYxCmZpbGV1aWQ9YFxscyAtbjEgZjEgfCBhd2sgJ3sg cHJpbnQgJDMgfSdgCmlmIFsgIiRmaWxldWlkIiAhPSAiJFVJRCIgXQp0aGVuCgllY2hvIFVJRCB3 cm9uZwoJZXhpdCAxCmZpCgpjaG93biByb290LnJvb3QgZjEKZmlsZXVpZD1gXGxzIC1uMSBmMSB8 IGF3ayAneyBwcmludCAkMyB9J2AKaWYgWyAiJGZpbGV1aWQiICE9ICIwIiBdCnRoZW4KCWVjaG8g VUlEIHdyb25nCglleGl0IDEKZmkKCnB5dGhvbjMgLWMgJ2ltcG9ydCBvczsgb3MucmVuYW1lKCJm MSIsICJmMSIpJwpmaWxldWlkPWBcbHMgLW4xIGYxIHwgYXdrICd7IHByaW50ICQzIH0nYAppZiBb ICIkZmlsZXVpZCIgIT0gIjAiIF0KdGhlbgoJZWNobyBVSUQgd3JvbmcgZ290ICRmaWxldWlkCgll eGl0IDEKZmkK 4716 2020-08-26 12:01:50 +0000 2020-08-26 12:01:50 +0000 testcase for rename() and renameat() arftest.c text/plain 770 joe.slater LyoKICogdGVzdCBmb3IgcHNldWRvIHJlbmFtaW5nCiAqCiAqICAgUnVuIGluIGEgZGlyZWN0b3J5 IG5hbWVkIGFyZiB3aXRoIGZpbGVzIGFyZiBhbmQgYXJmYXQgZXhpc3RpbmcuCiAqLwoKCiNpbmNs dWRlIDxmY250bC5oPgojaW5jbHVkZSA8c3RkaW8uaD4KCmludCBtYWluKGludCBhcmdjLCBjaGFy ICoqYXJndikKIHsKICAgaWYgKCFyZW5hbWUoImFyZiIsImJhcmYiKSkgIHByaW50ZigiYXJmIHRv IGJhcmZcbiIpOwogICBpZiAoIXJlbmFtZSgiYmFyZiIsImJhcmYiKSkgIHByaW50ZigiYmFyZiB0 byBiYXJmXG4iKTsKICAgaWYgKCFyZW5hbWUoImJhcmYiLCIuLi9hcmYvYmFyZiIpKSAgcHJpbnRm KCJiYXJmIHRvIC4uL2FyZi9iYXJmXG4iKTsKCiAgIGlmICghcmVuYW1lYXQoQVRfRkRDV0QsImFy ZmF0IixBVF9GRENXRCwiYmFyZmF0IikpCiAgICAgIHByaW50ZigiYXJmYXQgdG8gYmFyZmF0XG4i KTsKICAgaWYgKCFyZW5hbWVhdChBVF9GRENXRCwiYmFyZmF0IixBVF9GRENXRCwiYmFyZmF0Iikp CiAgICAgIHByaW50ZigiYmFyZmF0IHRvIGJhcmZhdFxuIik7CgojaWZkZWYgVU5ERUZJTkVECiAg IGlmICghcmVuYW1lYXQyKEFUX0ZEQ1dELCJhcmYyIixBVF9GRENXRCwiYmFyZjIiLDApKQogICAg ICBwcmludGYoImFyZjIgdG8gYmFyZjJcbiIpOwogICBpZiAoIXJlbmFtZWF0MihBVF9GRENXRCwi YmFyZjIiLEFUX0ZEQ1dELCJiYXJmMiIsMCkpCiAgICAgIHByaW50ZigiYmFyZjIgdG8gYmFyZjJc biIpOwojZW5kaWYKCiAgIHJldHVybiAwOwoKIH0=