13550 2019-09-25 07:44:29 +0000 username/password specified to gitsm:// does not get propagated to submodules 2023-08-03 12:41:21 +0000 1 1 7 Build System, Metadata & Runtime BitBake bitbake unspecified x86 Multiple RESOLVED WONTFIX Medium+ normal 4.3 M3 1 inno.test yoann.congal mark.hatle poky.bs.watcher poky.watcher randy.macleod richard.purdie yoann.congal --- --- No (bug/feature does not impact docs) oldest_to_newest 85062 0 4567 inno.test 2019-09-25 07:44:29 +0000 Created attachment 4567 Path that fixes the problem for me I have a recipe that takes the sources from git using a username/password with a line looking like this SRC_URI = "gitsm://${COMPANY_GIT_REPO}/path/to/project.git;protocol=https;user=${GIT_USER}" The project has a submodule requiring the same username/password but bitbake exits with a message like fatal: could not read Username for 'https://${COMPANY_GIT_REPO}': No such device or address The patch attached solved my problem (bitbake version 1.40.0). If a user is present it adds the parameter to submodule fetching. 85129 1 inno.test 2019-09-30 12:04:07 +0000 I found another way to solve the problem by making the url of the submodule relative. So I rewrote [submodule "mysubmodule"] path = mysubmodule url = https://myhost/mysubmodule.git as [submodule "mysubmodule"] path = mysubmodule url = ../mysubmodule.git I guess that is the way things are meant to be... inherit the user/password is acceptable as long as the submodule is on the same host, which means exactly the same use case covered by the patch I submitted. 90440 2 randy.macleod 2021-05-20 15:46:46 +0000 Mark, Unless you reply today, I'm going to assume that you like the patch as is: diff --git a/bitbake/lib/bb/fetch2/gitsm.py b/bitbake/lib/bb/fetch2/gitsm.py index b21fed2669..152bdc98c4 100644 --- a/bitbake/lib/bb/fetch2/gitsm.py +++ b/bitbake/lib/bb/fetch2/gitsm.py @@ -130,6 +130,8 @@ class GitSM(Git): url += ';protocol=%s' % proto url += ";name=%s" % module url += ";subpath=%s" % paths[module] + if ud.user: + url += ";user=%s" % ud.user ld = d.createCopy() # Not necessary to set SRC_URI, since we're passing the URI to and ask Tony to submit it. 91016 3 tony.tascioglu 2021-07-23 16:53:05 +0000 Sorry, I lost track of this. I'll get to it as soon as I can. 96032 4 yoann.congal 2023-07-26 13:24:03 +0000 I've checked : * "user=" parameter of SRC_URI in indeed not passed to submodules (as of bitbake commit 64bc00a46d). Same for the gitsm://USER@... part of the URL * The patch does fix that (I'll attach a refreshed version of the patch) However : * Passing password from git SRC_URI is not supported [0] * I don't see the point supporting passing the user but not the password * Recommended method to give a password to git SRC_URI is .netrc (for the git over http protocol) * This .netrc config does apply for git submodules * Using .netrc, I have no trouble having a git submodule pointing to http git URL using authentication. I would close this ticket since what the reporter want is supported (via the only supported method : .netrc) but I have a doubt since the observation "user is not propagated to submodules" is still true. [0] : https://git.openembedded.org/bitbake/tree/lib/bb/fetch2/git.py?id=a0d8108eba8d542707740d00c66c1c5f5b963f18#n692 96033 5 4963 yoann.congal 2023-07-26 14:25:23 +0000 Created attachment 4963 Refreshed patch "gitsm: propagate user parameter to submodules" 96129 6 yoann.congal 2023-07-27 15:47:38 +0000 From bug triage meeting 2023-07-27 : * I will send a patch commenting in the code that we don't support this (so we don't get more bugs about this) * Then, close this bug as WONTFIX 96143 7 yoann.congal 2023-07-28 16:29:45 +0000 > * I will send a patch commenting in the code that we don't support this (so we don't get more bugs about this) => https://lists.openembedded.org/g/bitbake-devel/message/14893 96174 8 yoann.congal 2023-08-03 12:41:21 +0000 Non-support documented here : https://git.yoctoproject.org/poky/commit/?id=d8a51fd6288b54c2fe9d08a65a50e2d8cd38b91b I close the bug I "won't fix" but the way to handle this is to use a .netrc file which will contain the username and the password. 4567 2019-09-25 07:44:29 +0000 2023-07-26 14:25:23 +0000 Path that fixes the problem for me gitsm.diff application/octet-stream 542 inno.test ZGlmZiAtLWdpdCBhL2JpdGJha2UvbGliL2JiL2ZldGNoMi9naXRzbS5weSBiL2JpdGJha2UvbGli L2JiL2ZldGNoMi9naXRzbS5weQppbmRleCBiMjFmZWQyNjY5Li4xNTJiZGM5OGM0IDEwMDY0NAot LS0gYS9iaXRiYWtlL2xpYi9iYi9mZXRjaDIvZ2l0c20ucHkKKysrIGIvYml0YmFrZS9saWIvYmIv ZmV0Y2gyL2dpdHNtLnB5CkBAIC0xMzAsNiArMTMwLDggQEAgY2xhc3MgR2l0U00oR2l0KToKICAg ICAgICAgICAgIHVybCArPSAnO3Byb3RvY29sPSVzJyAlIHByb3RvCiAgICAgICAgICAgICB1cmwg Kz0gIjtuYW1lPSVzIiAlIG1vZHVsZQogICAgICAgICAgICAgdXJsICs9ICI7c3VicGF0aD0lcyIg JSBwYXRoc1ttb2R1bGVdCisgICAgICAgICAgICAjaWYgdWQudXNlcjoKKyAgICAgICAgICAgICMg ICAgdXJsICs9ICI7dXNlcj0lcyIgJSB1ZC51c2VyIAogCiAgICAgICAgICAgICBsZCA9IGQuY3Jl YXRlQ29weSgpCiAgICAgICAgICAgICAjIE5vdCBuZWNlc3NhcnkgdG8gc2V0IFNSQ19VUkksIHNp bmNlIHdlJ3JlIHBhc3NpbmcgdGhlIFVSSSB0bwo= 4963 2023-07-26 14:25:23 +0000 2023-07-26 14:25:23 +0000 Refreshed patch "gitsm: propagate user parameter to submodules" 0001-gitsm-propagate-user-parameter-to-submodules.patch text/plain 923 yoann.congal RnJvbSAxY2NlZDk4MzAwZGNlZTc1NTE0ZjRiYWNhOTExYjNjYzI2OTJiZjRmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtYXJvbSA8aW5uby50ZXN0QHlhaG9vLmNvbT4KRGF0ZTogV2Vk LCAyNiBKdWwgMjAyMyAxNToyNzoyMyArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIGdpdHNtOiBwcm9w YWdhdGUgdXNlciBwYXJhbWV0ZXIgdG8gc3VibW9kdWxlcwoKTkI6IHBhdGNoIGZpcnN0IHBvc3Rl ZCBieSAibWFyb20iIG9uIGh0dHBzOi8vYnVnemlsbGEueW9jdG9wcm9qZWN0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTM1NTAKClNpZ25lZC1vZmYtYnk6IFlvYW5uIENvbmdhbCA8eW9hbm4uY29uZ2Fs QHNtaWxlLmZyPgotLS0KIGxpYi9iYi9mZXRjaDIvZ2l0c20ucHkgfCAyICsrCiAxIGZpbGUgY2hh bmdlZCwgMiBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvbGliL2JiL2ZldGNoMi9naXRzbS5w eSBiL2xpYi9iYi9mZXRjaDIvZ2l0c20ucHkKaW5kZXggZjhlMjM5YmM1Li43YTdmMGJmNTMgMTAw NjQ0Ci0tLSBhL2xpYi9iYi9mZXRjaDIvZ2l0c20ucHkKKysrIGIvbGliL2JiL2ZldGNoMi9naXRz bS5weQpAQCAtMTIzLDYgKzEyMyw4IEBAIGNsYXNzIEdpdFNNKEdpdCk6CiAgICAgICAgICAgICB1 cmwgKz0gIjtuYW1lPSVzIiAlIG1vZHVsZQogICAgICAgICAgICAgdXJsICs9ICI7c3VicGF0aD0l cyIgJSBtb2R1bGUKICAgICAgICAgICAgIHVybCArPSAiO25vYnJhbmNoPTEiCisgICAgICAgICAg ICBpZiB1ZC51c2VyOgorICAgICAgICAgICAgICAgIHVybCArPSAiO3VzZXI9JXMiICUgdWQudXNl cgogCiAgICAgICAgICAgICBsZCA9IGQuY3JlYXRlQ29weSgpCiAgICAgICAgICAgICAjIE5vdCBu ZWNlc3NhcnkgdG8gc2V0IFNSQ19VUkksIHNpbmNlIHdlJ3JlIHBhc3NpbmcgdGhlIFVSSSB0bwot LSAKMi4zMC4yCgo=