<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>13573</bug_id>
          
          <creation_ts>2019-10-04 15:50:13 +0000</creation_ts>
          <short_desc>Sanity check SDK_VENDOR</short_desc>
          <delta_ts>2020-02-10 13:44:45 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>devtools / tool chain</component>
          <version>unspecified</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard>NEWCOMER BACKPORT</status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>3.1 M3</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ross Burton">ross.burton</reporter>
          <assigned_to name="Ankur Tyagi">ankur.tyagi85</assigned_to>
          <cc>ankur.tyagi85</cc>
    
    <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
    
    <cc>randy.macleod</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>85220</commentid>
    <comment_count>0</comment_count>
    <who name="Ross Burton">ross.burton</who>
    <bug_when>2019-10-04 15:50:13 +0000</bug_when>
    <thetext>SDK_VENDOR shouldn&apos;t have any extra hyphens in because it is used to form a dash-separated triple and if there&apos;s more hyphens then things break.

For example with SDK_VENDOR=&quot;-myd-sdk&quot;:

Checking target system type... Invalid configuration `x86_64-myd-sdk-linux&apos;: machine `x86_64-myd-sdk&apos; not recognized

Changing the SDK_VENDOR to &quot;-myd_sdk&quot; fixed the build.

We should check for this at SDK construction time, so that the user can&apos;t build a broken SDK.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86249</commentid>
    <comment_count>1</comment_count>
    <who name="Ankur Tyagi">ankur.tyagi85</who>
    <bug_when>2020-02-01 03:33:52 +0000</bug_when>
    <thetext>I thought of putting a check inside sdk_variables() inside populate_sdk_base class but it has limitations:
- works only for the first time but not for successive invoke
- only works for populate_sdk but misses meta-toolchain

Can I get some more insight/ideas on this? thanks</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86320</commentid>
    <comment_count>2</comment_count>
    <who name="Ross Burton">ross.burton</who>
    <bug_when>2020-02-05 22:07:51 +0000</bug_when>
    <thetext>A better place to do that logic would be sanity.bbclass, this is where all of the pre-build sanity checks are implemented.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86387</commentid>
    <comment_count>3</comment_count>
    <who name="Ankur Tyagi">ankur.tyagi85</who>
    <bug_when>2020-02-09 04:16:42 +0000</bug_when>
    <thetext>Hi Ross,

This seems to be fixed now by your commit
https://github.com/openembedded/openembedded-core/commit/b0efd8d4d0dbc30e6505b42f5603f18fa764d732

This bug can be closed</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86389</commentid>
    <comment_count>4</comment_count>
    <who name="Ross Burton">ross.burton</who>
    <bug_when>2020-02-10 13:44:45 +0000</bug_when>
    <thetext>Huh.  I had totally forgotten I wrote that.  Sorry for not closing this earlier.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>