13628 2019-11-15 11:56:02 +0000 Sort files in do_image_cpio for reproducibility 2019-12-11 10:10:27 +0000 1 1 7 Build System, Metadata & Runtime OE-Core core 3.0 x86 Multiple RESOLVED FIXED Medium normal 3.1 1 ernstp ross.burton meta.mr.watcher meta.watcher richard.purdie --- --- No (bug/feature does not impact docs) oldest_to_newest 85544 0 4586 ernstp 2019-11-15 11:56:02 +0000 Created attachment 4586 Patch Find list files in the order that the filesystem has registered them which can vary. Adding a sort should have minimal performance impact. This should be done in meta/classes/image_types.bbclass 85547 1 ernstp 2019-11-15 15:07:17 +0000 There's a --reproducible option to cpio also. Perhaps make it optional under BUILD_REPRODUCIBLE_BINARIES ? 85548 2 ross.burton 2019-11-15 19:30:17 +0000 --reproducible doesn't sort so you'll need to do both. I prefer harmless changes to be done always instead of only in reproducible builds, less combinations for testing. Patches go to the mailing list not bugzilla, so can you please post using git-send-email to openembedded-core@lists.openembedded.org? 85549 3 ernstp 2019-11-15 23:54:54 +0000 > --reproducible doesn't sort so you'll need to do both. Yes I meant in addition to. > I prefer harmless changes to be done always instead of only in reproducible builds, less combinations for testing. Sounds good. > Patches go to the mailing list not bugzilla, so can you please post using git-send-email to openembedded-core@lists.openembedded.org? right, of course. 85674 4 4593 ernstp 2019-12-03 08:27:49 +0000 Created attachment 4593 Patch v2 85793 5 ernstp 2019-12-11 10:10:27 +0000 Merged to master. https://github.com/openembedded/openembedded-core/commit/930c1f69c928e21bda6bef7aad926d335195e107 4586 2019-11-15 11:56:02 +0000 2019-12-03 08:27:49 +0000 Patch 0001-do_image_cpio-Sort-files-for-reproducibility.patch text/plain 1416 ernstp RnJvbSBmNmZlOGE0NTc0NmU2NGQ3MjBiMGNjOTgwNTE4NmFjMjgzYjA5MTliIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RXJuc3Q9MjBTaj1DMz1CNnN0cmFuZD89IDxl cm5zdC5zam9zdHJhbmRAdmVyaXN1cmUuY29tPgpEYXRlOiBGcmksIDE1IE5vdiAyMDE5IDEyOjQ3 OjUzICswMTAwClN1YmplY3Q6IFtQQVRDSF0gZG9faW1hZ2VfY3BpbzogU29ydCBmaWxlcyBmb3Ig cmVwcm9kdWNpYmlsaXR5Ck1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFp bjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0CgpGaW5kIGxp c3QgZmlsZXMgaW4gdGhlIG9yZGVyIHRoYXQgdGhlIGZpbGVzeXN0ZW0gaGFzIHJlZ2lzdGVyZWQg dGhlbQp3aGljaCBjYW4gdmFyeS4gQWRkaW5nIGEgc29ydCBzaG91bGQgaGF2ZSBtaW5pbWFsIHBl cmZvcm1hbmNlIGltcGFjdC4KClNpZ25lZC1vZmYtYnk6IEVybnN0IFNqw7ZzdHJhbmQgPGVybnN0 LnNqb3N0cmFuZEB2ZXJpc3VyZS5jb20+Ci0tLQogbWV0YS9jbGFzc2VzL2ltYWdlX3R5cGVzLmJi Y2xhc3MgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24o LSkKCmRpZmYgLS1naXQgYS9tZXRhL2NsYXNzZXMvaW1hZ2VfdHlwZXMuYmJjbGFzcyBiL21ldGEv Y2xhc3Nlcy9pbWFnZV90eXBlcy5iYmNsYXNzCmluZGV4IDJlZWZmYmIzNjYuLjA0MTZhYzMyZGYg MTAwNjQ0Ci0tLSBhL21ldGEvY2xhc3Nlcy9pbWFnZV90eXBlcy5iYmNsYXNzCisrKyBiL21ldGEv Y2xhc3Nlcy9pbWFnZV90eXBlcy5iYmNsYXNzCkBAIC0xMjgsNyArMTI4LDcgQEAgSU1BR0VfQ01E X3RhciA9ICIke0lNQUdFX0NNRF9UQVJ9IC0tbnVtZXJpYy1vd25lciAtY2YgJHtJTUdERVBMT1lE SVJ9LyR7SU1BR0VfTkEKIAogZG9faW1hZ2VfY3Bpb1tjbGVhbmRpcnNdICs9ICIke1dPUktESVJ9 L2NwaW9fYXBwZW5kIgogSU1BR0VfQ01EX2NwaW8gKCkgewotCShjZCAke0lNQUdFX1JPT1RGU30g JiYgZmluZCAuIHwgY3BpbyAtbyAtSCBuZXdjID4ke0lNR0RFUExPWURJUn0vJHtJTUFHRV9OQU1F fSR7SU1BR0VfTkFNRV9TVUZGSVh9LmNwaW8pCisJKGNkICR7SU1BR0VfUk9PVEZTfSAmJiBmaW5k IC4gfCBzb3J0IHwgY3BpbyAtbyAtSCBuZXdjID4ke0lNR0RFUExPWURJUn0vJHtJTUFHRV9OQU1F fSR7SU1BR0VfTkFNRV9TVUZGSVh9LmNwaW8pCiAJIyBXZSBvbmx5IG5lZWQgdGhlIC9pbml0IHN5 bWxpbmsgaWYgd2UncmUgYnVpbGRpbmcgdGhlIHJlYWwKIAkjIGltYWdlLiBUaGUgLWRiZyBpbWFn ZSBkb2Vzbid0IG5lZWQgaXQhIEJ5IGJlaW5nIGNsZXZlcgogCSMgYWJvdXQgdGhpcyB3ZSBhbHNv IGF2b2lkICd0b3VjaCcgYmVsb3cgZmFpbGluZywgYXMgaXQKLS0gCjIuMjQuMAoK 4593 2019-12-03 08:27:49 +0000 2019-12-03 08:27:49 +0000 Patch v2 0001-do_image_cpio-Improve-reproducibility.patch text/plain 1470 ernstp RnJvbSA3YmFiNTYzNTAwMzNhOWEzOTZiYTY1NjUxN2Y1OTY2Nzg3MTlmZmE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RXJuc3Q9MjBTaj1DMz1CNnN0cmFuZD89IDxl cm5zdC5zam9zdHJhbmRAdmVyaXN1cmUuY29tPgpEYXRlOiBGcmksIDE1IE5vdiAyMDE5IDEyOjQ3 OjUzICswMTAwClN1YmplY3Q6IFtQQVRDSF0gZG9faW1hZ2VfY3BpbzogSW1wcm92ZSByZXByb2R1 Y2liaWxpdHkKTUlNRS1WZXJzaW9uOiAxLjAKQ29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFy c2V0PVVURi04CkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKCkZpbmQgbGlzdHMgZmls ZXMgaW4gdGhlIG9yZGVyIHRoYXQgdGhlIGZpbGVzeXN0ZW0gaGFzIHJlZ2lzdGVyZWQgdGhlbSwK d2hpY2ggY2FuIHZhcnkuIEFkZGluZyBhIHNvcnQgc2hvdWxkIGhhdmUgbWluaW1hbCBwZXJmb3Jt YW5jZSBpbXBhY3QuCkFsc28gdXNlIHRoZSAtLXJlcHJvZHVjaWJsZSBvcHRpb24gdG8gY3Bpby4K ClNpZ25lZC1vZmYtYnk6IEVybnN0IFNqw7ZzdHJhbmQgPGVybnN0LnNqb3N0cmFuZEB2ZXJpc3Vy ZS5jb20+Ci0tLQogbWV0YS9jbGFzc2VzL2ltYWdlX3R5cGVzLmJiY2xhc3MgfCAyICstCiAxIGZp bGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9t ZXRhL2NsYXNzZXMvaW1hZ2VfdHlwZXMuYmJjbGFzcyBiL21ldGEvY2xhc3Nlcy9pbWFnZV90eXBl cy5iYmNsYXNzCmluZGV4IDJlZWZmYmIzNjYuLmM3YWY4ODkwNzUgMTAwNjQ0Ci0tLSBhL21ldGEv Y2xhc3Nlcy9pbWFnZV90eXBlcy5iYmNsYXNzCisrKyBiL21ldGEvY2xhc3Nlcy9pbWFnZV90eXBl cy5iYmNsYXNzCkBAIC0xMjgsNyArMTI4LDcgQEAgSU1BR0VfQ01EX3RhciA9ICIke0lNQUdFX0NN RF9UQVJ9IC0tbnVtZXJpYy1vd25lciAtY2YgJHtJTUdERVBMT1lESVJ9LyR7SU1BR0VfTkEKIAog ZG9faW1hZ2VfY3Bpb1tjbGVhbmRpcnNdICs9ICIke1dPUktESVJ9L2NwaW9fYXBwZW5kIgogSU1B R0VfQ01EX2NwaW8gKCkgewotCShjZCAke0lNQUdFX1JPT1RGU30gJiYgZmluZCAuIHwgY3BpbyAt byAtSCBuZXdjID4ke0lNR0RFUExPWURJUn0vJHtJTUFHRV9OQU1FfSR7SU1BR0VfTkFNRV9TVUZG SVh9LmNwaW8pCisJKGNkICR7SU1BR0VfUk9PVEZTfSAmJiBmaW5kIC4gfCBzb3J0IHwgY3BpbyAt LXJlcHJvZHVjaWJsZSAtbyAtSCBuZXdjID4ke0lNR0RFUExPWURJUn0vJHtJTUFHRV9OQU1FfSR7 SU1BR0VfTkFNRV9TVUZGSVh9LmNwaW8pCiAJIyBXZSBvbmx5IG5lZWQgdGhlIC9pbml0IHN5bWxp bmsgaWYgd2UncmUgYnVpbGRpbmcgdGhlIHJlYWwKIAkjIGltYWdlLiBUaGUgLWRiZyBpbWFnZSBk b2Vzbid0IG5lZWQgaXQhIEJ5IGJlaW5nIGNsZXZlcgogCSMgYWJvdXQgdGhpcyB3ZSBhbHNvIGF2 b2lkICd0b3VjaCcgYmVsb3cgZmFpbGluZywgYXMgaXQKLS0gCjIuMjQuMAoK