13636 2019-11-18 12:27:14 +0000 recipetool unbound variable when reproducible_build class is inherited 2019-11-23 14:44:24 +0000 1 1 7 Build System, Metadata & Runtime OE-Core devtools / tool chain 3.0 x86 Multiple RESOLVED FIXED High normal 3.1 M1 1 richard.purdie richard.purdie meta.mr.watcher meta.watcher randy.macleod --- --- No (bug/feature does not impact docs) oldest_to_newest 85558 0 richard.purdie 2019-11-18 12:27:14 +0000 https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/481 There were a ton of failures when: INHERIT += "reproducible_build" was added. This bug covers the recipetool unbound variable selftest failures 2019-11-16 23:04:29,884 - oe-selftest - INFO - ====================================================================== 2019-11-16 23:04:29,884 - oe-selftest - INFO - ERROR: recipetool.RecipetoolTests.test_recipetool_create_git_http (subunit.RemotedTestCase) 2019-11-16 23:04:29,884 - oe-selftest - INFO - ---------------------------------------------------------------------- 2019-11-16 23:04:29,884 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last): File "/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/meta/lib/oeqa/selftest/cases/recipetool.py", line 503, in test_recipetool_create_git_http self._test_recipe_contents(recipefile, checkvars, inherits) File "/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/meta/lib/oeqa/selftest/cases/devtool.py", line 182, in _test_recipe_contents self.assertIn(inherit, inherits, 'Missing inherit of %s' % inherit) UnboundLocalError: local variable 'inherits' referenced before assignment 2019-11-16 23:04:29,884 - oe-selftest - INFO - ====================================================================== 2019-11-16 23:04:29,884 - oe-selftest - INFO - ERROR: recipetool.RecipetoolTests.test_recipetool_create_github_tarball (subunit.RemotedTestCase) 2019-11-16 23:04:29,884 - oe-selftest - INFO - ---------------------------------------------------------------------- 2019-11-16 23:04:29,885 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last): File "/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/meta/lib/oeqa/selftest/cases/recipetool.py", line 489, in test_recipetool_create_github_tarball self._test_recipe_contents(recipefile, checkvars, inherits) File "/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/meta/lib/oeqa/selftest/cases/devtool.py", line 182, in _test_recipe_contents self.assertIn(inherit, inherits, 'Missing inherit of %s' % inherit) UnboundLocalError: local variable 'inherits' referenced before assignment 85564 1 richard.purdie 2019-11-18 15:19:39 +0000 diff --git a/meta/lib/oeqa/selftest/cases/devtool.py b/meta/lib/oeqa/selftest/cases/devtool.py index 3a25da2033b..365a57c4f53 100644 --- a/meta/lib/oeqa/selftest/cases/devtool.py +++ b/meta/lib/oeqa/selftest/cases/devtool.py @@ -137,6 +137,7 @@ class DevtoolBase(OESelftestTestCase): with open(recipefile, 'r') as f: invar = None invalue = None + inherits = set() for line in f: var = None if invar: @@ -158,7 +159,7 @@ class DevtoolBase(OESelftestTestCase): invar = var continue elif line.startswith('inherit '): - inherits = line.split()[1:] + inherits.add(line.split()[1:]) if var and var in checkvars: needvalue = checkvars.pop(var) then the error becomes: AssertionError: 'pkgconfig' not found in set() : Missing inherit of pkgconfig 85565 2 richard.purdie 2019-11-18 16:29:34 +0000 Patches on the mailing list for this issue. 85585 3 randy.macleod 2019-11-21 15:44:53 +0000 There is a patch in review. 85614 4 richard.purdie 2019-11-23 14:40:27 +0000 http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=d05b78b245e9a1b2743d3f649378dc3e3565b12d