<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>13724</bug_id>
          
          <creation_ts>2020-01-03 01:29:59 +0000</creation_ts>
          <short_desc>task signature not changing when using mcdepends</short_desc>
          <delta_ts>2020-06-25 11:21:41 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>BitBake</product>
          <component>bitbake</component>
          <version>unspecified</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>3.2 M2</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jonathan Richardson">jon.richardson</reporter>
          <assigned_to name="Joshua Watt">JPEWhacker</assigned_to>
          <cc>frederik.sdun</cc>
    
    <cc>JPEWhacker</cc>
    
    <cc>poky.bs.watcher</cc>
    
    <cc>poky.watcher</cc>
    
    <cc>randy.macleod</cc>
    
    <cc>scott.branden</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>85978</commentid>
    <comment_count>0</comment_count>
    <who name="Jonathan Richardson">jon.richardson</who>
    <bug_when>2020-01-03 01:29:59 +0000</bug_when>
    <thetext>We have a recipe with a multiconfig dependency on a task from another recipe:

brcm-atf:
do_compile[depends] += &quot;${@bb.utils.contains(&quot;USE_UEFI&quot;, &quot;yes&quot;, &quot;brcm-edk2:do_deploy&quot;, bb.utils.contains(&quot;USE_UBOOT&quot;, &quot;yes&quot;, &quot;brcm-u-boot:do_deploy&quot;, bb.utils.contains(&quot;USE_TINYBOOT&quot;, &quot;yes&quot;, &quot;brcm-tiny-boot:do_deploy&quot;, &quot;&quot;, d), d), d)}&quot;
do_compile[depends] += &quot;${@bb.utils.contains(&quot;TRUSTED_MODE&quot;, &quot;optee&quot;, &quot;brcm-optee-os:do_deploy&quot;, &quot;&quot; ,d)}&quot;
do_compile[depends] += &quot;${@bb.utils.contains(&quot;USE_FRU&quot;, &quot;yes&quot;, &quot;brcm-fru:do_deploy&quot;, &quot;&quot; ,d)}&quot;

MULTICONFIG_FROM = &quot;${@d.getVar(&apos;BBMULTICONFIG&apos;).split()[0]}&quot;
MULTICONFIG_TO = &quot;${@d.getVar(&apos;BBMULTICONFIG&apos;).split()[1]}&quot;
do_compile[mcdepends] += &quot;multiconfig:${MULTICONFIG_FROM}:${MULTICONFIG_TO}:brcm-crmu:do_deploy&quot;

If I change source code in the brcm-crmu recipe, brcm_crmu:do_compile runs and the binary is updated. I would then expect the task signature for brcm-atf:do_compile to become invalidated also so that it can also run. The command run is: bitbake mc:stingray:brcm-atf

brcm-crmu has this do_deploy:
do_deploy() {
    install -D -m 0644 ${S}/scp-fw.bin ${DEPLOYDIR}/scp-fw.bin
}
addtask deploy before do_build after do_compile

When I dump the signature it looks like my task doesn&apos;t have a dependency from the mcdepends, though it does cause brcm-crmu do_deploy (and subsequently do_compile) to run successfully. brcm-atf has dependencies for the do_compile[depends], just not the do_compile[mcdepends].

$ bitbake-dumpsig -t brcm-atf do_compile

...

Tasks this task depends on: [&apos;/home/jon/work/yocto/nxs/poky/build/../meta-brcm/common/recipes-bsp/atf/brcm-atf.bb:do_configure&apos;, &apos;/home/jon/work/yocto/nxs/poky/build/../meta-brcm/common/recipes-bsp/atf/brcm-fru.bb:do_deploy&apos;, &apos;/home/jon/work/yocto/nxs/poky/build/../meta-brcm/common/recipes-bsp/edk2/brcm-edk2.bb:do_deploy&apos;]
This task depends on the checksums of files: [(&apos;oe-devtool-tree-sha1-brcm-atf&apos;, &apos;8640fa2da703f7ee8cfd5bca382e2837&apos;)]
Hash for dependent task /home/jon/work/yocto/nxs/poky/build/../meta-brcm/common/recipes-bsp/atf/brcm-atf.bb:do_configure is 17aa9eeff0ea95157868cdbc2748fa52ce09fcefa3d262d3be4a34eb3e840be7
Hash for dependent task /home/jon/work/yocto/nxs/poky/build/../meta-brcm/common/recipes-bsp/atf/brcm-fru.bb:do_deploy is 1340b31be11e17920e6cf59a6c4bfe750d84a9e9044d62fc797fef72ce3eabec
Hash for dependent task /home/jon/work/yocto/nxs/poky/build/../meta-brcm/common/recipes-bsp/edk2/brcm-edk2.bb:do_deploy is d356bf1184f51363e218aa83e859a1b3225349ed1725ad3ed6acaa1a66470d45
Computed base hash is c98dc7bd249fc3e4887140da6c645fc78fc5e362611674e1d0a05f9b3659902e and from file c98dc7bd249fc3e4887140da6c645fc78fc5e362611674e1d0a05f9b3659902e
Computed task hash is 214645088b423103d12903cb42d87ff7aa9baaa96d7d42f4835608fc7e50a7a3</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86096</commentid>
    <comment_count>1</comment_count>
    <who name="Frederik Noe-Sdun">frederik.sdun</who>
    <bug_when>2020-01-23 10:56:22 +0000</bug_when>
    <thetext>I had a simliar use-case in a customer based project.

To reproduce the issue I used meta/lib/oeqa/selftest/cases/multiconfig.py MultiConfig.test_multiconfig based setup.
If something is add to core-image-minimal it is now included in multiconfig-image-packager.

to fix the issues in master I attached patches to https://bugzilla.yoctoproject.org/show_bug.cgi?id=13130 (in a false manner)

Will try to send those to ML soonish ...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87485</commentid>
    <comment_count>2</comment_count>
    <who name="Joshua Watt">JPEWhacker</who>
    <bug_when>2020-06-15 09:15:11 +0000</bug_when>
    <thetext>Fixed in 749731a420fb905b6af97ce2909f06b2bcd14fe2 of oe-core and f2062c41693f9f684bdaf2df0a2a08b7f3871026 of bitbake</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87486</commentid>
    <comment_count>3</comment_count>
    <who name="Joshua Watt">JPEWhacker</who>
    <bug_when>2020-06-15 09:16:29 +0000</bug_when>
    <thetext>Also 8ff9203de4fce9c104c2987d86980c9f34036b97 of bitbake</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87504</commentid>
    <comment_count>4</comment_count>
    <who name="Jonathan Richardson">jon.richardson</who>
    <bug_when>2020-06-17 17:45:30 +0000</bug_when>
    <thetext>I cherry picked:

commit f78409bb4a6f689953098862c40de580d6d6d4dc (HEAD)
Author: Joshua Watt &lt;JPEWhacker@gmail.com&gt;
Date:   Tue Jun 9 13:34:14 2020 -0500

    bitbake: bitbake: siggen: Pass all data caches to hash functions

but I still see the same behaviour I reported. Is there a commit I missed? I&apos;m not sure what &apos;8ff9203de4fce9c104c2987d86980c9f34036b97  of bitbake&apos; means.

Thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87523</commentid>
    <comment_count>5</comment_count>
    <who name="Scott Branden">scott.branden</who>
    <bug_when>2020-06-19 10:01:01 +0000</bug_when>
    <thetext>reopened as issue does not appear to be resolved?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87525</commentid>
    <comment_count>6</comment_count>
    <who name="Joshua Watt">JPEWhacker</who>
    <bug_when>2020-06-19 11:26:35 +0000</bug_when>
    <thetext>Can you verify if you are still seeing the behavior on the latest master? I&apos;m pretty sure this is fixed there, and I&apos;d like to eliminate the backport as the cause of the problem</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87526</commentid>
    <comment_count>7</comment_count>
    <who name="Jonathan Richardson">jon.richardson</who>
    <bug_when>2020-06-19 11:28:11 +0000</bug_when>
    <thetext>I&apos;ll do a full merge next week to the latest in case there was some other dependent changes missed by just cherry picking it. Thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87527</commentid>
    <comment_count>8</comment_count>
    <who name="Joshua Watt">JPEWhacker</who>
    <bug_when>2020-06-19 11:38:32 +0000</bug_when>
    <thetext>Thanks. Also please make sure to use the &quot;mc:&quot; prefix everywhere. Using &quot;multiconfig:&quot; is spotty at best:

do_compile[mcdepends] += &quot;mc:...&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87588</commentid>
    <comment_count>9</comment_count>
    <who name="Joshua Watt">JPEWhacker</who>
    <bug_when>2020-06-25 07:44:35 +0000</bug_when>
    <thetext>Did you get a chance to test this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87620</commentid>
    <comment_count>10</comment_count>
    <who name="Jonathan Richardson">jon.richardson</who>
    <bug_when>2020-06-25 11:11:53 +0000</bug_when>
    <thetext>Hi Joshua. Yes, I did a full merge and it does work. Thanks for fixing it. There must have been some quirk with just cherry picking that one change. This can be closed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87621</commentid>
    <comment_count>11</comment_count>
    <who name="Joshua Watt">JPEWhacker</who>
    <bug_when>2020-06-25 11:21:07 +0000</bug_when>
    <thetext>Great. Thanks!</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>