13748 2020-01-23 21:21:02 +0000 bitbake doesn't detect changes in code to run do_compile when using devtool modify on recipe with destsuffix 2021-02-11 17:12:08 +0000 1 1 7 Build System, Metadata & Runtime OE-Core devtools / tool chain unspecified x86 Multiple RESOLVED FIXED Medium+ normal 3.3 M3 1 scott.branden bluelightning jon.richardson meta.mr.watcher meta.watcher randy.macleod richard.purdie tim.orling --- --- Don't know oldest_to_newest 86109 0 4616 scott.branden 2020-01-23 21:21:02 +0000 Created attachment 4616 rwmem recipe modified to demonstrate bitbake task do_compile not working bitbake does not detect changes in code that has been modified if destsuffix is specified in the SRC_URI of the recipe. I have simplified the rwmem recipe from the meta-openembedded layer to demonstrate. To reproduce: devtool modify rwmem bitbake rwmem (do_configure, do_compile, do_install as expected) bitbake rwmem (nothing changed - expected) touch workspace/sources/rwmem/ext/inih/test bitbake rwmem (BUG - nothing run do_compile and do_install should run) touch workspace/sources/rwmem/test bitbake rwmem (RUNS - because not in the destsuffix part of the recipe) 86110 1 scott.branden 2020-01-23 21:21:32 +0000 Recipe placed here so you don't need to look at the attachment: SUMMARY = "rwmemTesting" DESCRIPTION = "rwmemTesting" LICENSE = "GPLv2+" LIC_FILES_CHKSUM = "file://LICENSE;md5=b234ee4d69f5fce4486a80fdaf4a4263" PV .= "+git${SRCPV}" SRCREV_rwmem = "3ec3e421211b58e766651c2e3a3a21acf14a1906" SRCREV_inih = "4b10c654051a86556dfdb634c891b6c3224c4109" SRCREV_FORMAT = "rwmem_inih" SRC_URI = " \ git://github.com/tomba/rwmem.git;protocol=https;name=rwmem \ git://github.com/benhoyt/inih.git;protocol=https;name=inih;nobranch=1;destsuffix=git/ext/inih \ " S = "${WORKDIR}/git" do_configure() { bbwarn "Testing do_configure" } do_compile() { bbwarn "Testing do_compile" } do_install() { bbwarn "Testing do_install" } 86581 2 scott.branden 2020-02-24 22:13:00 +0000 Hi Robert, Have you been able to reproduce? 87677 3 scott.branden 2020-07-02 15:55:26 +0000 Bug still present in master branch of yocto 89156 4 scott.branden 2021-02-06 05:41:52 +0000 Bug seems to have been fixed by this commit: externalsrc: Detect code changes in submodules The srctree_hash was calculated only from main source directory ignoring changes in submodules. [YOCTO #13748] Use submodule--helper to determine all submodules, and calculate hash from all git tree objects names combined. (From OE-Core rev: 50ff9afb3990bcf60b4fa1f937506cb84028c32d) Signed-off-by: Tomasz Dziendzielski <tomasz.dziendzielski@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>org> 89157 5 scott.branden 2021-02-06 05:42:01 +0000 Bug seems to have been fixed by this commit: externalsrc: Detect code changes in submodules The srctree_hash was calculated only from main source directory ignoring changes in submodules. [YOCTO #13748] Use submodule--helper to determine all submodules, and calculate hash from all git tree objects names combined. (From OE-Core rev: 50ff9afb3990bcf60b4fa1f937506cb84028c32d) Signed-off-by: Tomasz Dziendzielski <tomasz.dziendzielski@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>org> 89201 6 scott.branden 2021-02-10 22:32:21 +0000 Fixed in commit "externalsrc: Detect code changes in submodules" 89233 7 randy.macleod 2021-02-11 17:12:08 +0000 Here's the link to that commit for those interested: http://cgit.openembedded.org/openembedded-core/commit/?id=50ff9afb3990bcf60b4fa1f937506cb84028c32d 4616 2020-01-23 21:21:02 +0000 2020-01-23 21:21:02 +0000 rwmem recipe modified to demonstrate bitbake task do_compile not working rwmem_1.2.bb application/octet-stream 666 scott.branden U1VNTUFSWSA9ICJyd21lbVRlc3RpbmciCkRFU0NSSVBUSU9OID0gInJ3bWVtVGVzdGluZyIKTElD RU5TRSA9ICJHUEx2MisiCkxJQ19GSUxFU19DSEtTVU0gPSAiZmlsZTovL0xJQ0VOU0U7bWQ1PWIy MzRlZTRkNjlmNWZjZTQ0ODZhODBmZGFmNGE0MjYzIgoKUFYgLj0gIitnaXQke1NSQ1BWfSIKClNS Q1JFVl9yd21lbSA9ICIzZWMzZTQyMTIxMWI1OGU3NjY2NTFjMmUzYTNhMjFhY2YxNGExOTA2IgpT UkNSRVZfaW5paCA9ICI0YjEwYzY1NDA1MWE4NjU1NmRmZGI2MzRjODkxYjZjMzIyNGM0MTA5IgoK U1JDUkVWX0ZPUk1BVCA9ICJyd21lbV9pbmloIgoKU1JDX1VSSSA9ICIgXAogICAgZ2l0Oi8vZ2l0 aHViLmNvbS90b21iYS9yd21lbS5naXQ7cHJvdG9jb2w9aHR0cHM7bmFtZT1yd21lbSBcCiAgICBn aXQ6Ly9naXRodWIuY29tL2JlbmhveXQvaW5paC5naXQ7cHJvdG9jb2w9aHR0cHM7bmFtZT1pbmlo O25vYnJhbmNoPTE7ZGVzdHN1ZmZpeD1naXQvZXh0L2luaWggXAoiCgpTID0gIiR7V09SS0RJUn0v Z2l0IgoKZG9fY29uZmlndXJlKCkgewogIGJid2FybiAiVGVzdGluZyBkb19jb25maWd1cmUiCn0K CmRvX2NvbXBpbGUoKSB7CiAgYmJ3YXJuICJUZXN0aW5nIGRvX2NvbXBpbGUiCn0KCmRvX2luc3Rh bGwoKSB7CiAgYmJ3YXJuICJUZXN0aW5nIGRvX2luc3RhbGwiCn0K