13881 2020-04-22 03:33:39 +0000 Bitdoc broken in latest and prior releases, remove or fix? 2020-05-02 03:02:03 +0000 1 1 7 Build System, Metadata & Runtime BitBake bitbake unspecified All Multiple RESOLVED FIXED Medium+ enhancement 3.2 M1 1 frazer.clews richard.purdie frazer.clews poky.bs.watcher poky.watcher randy.macleod tim.orling --- --- Don't know oldest_to_newest 87062 0 frazer.clews 2020-04-22 03:33:39 +0000 I noticed there's a binary for bitdoc, it's been broken for a long time but can't see if it's not meant to be used or not. I have made a WIP patch to fix it, but should it be removed maybe if it's not intended, if so I will make a patch to remove it to make the codebase better. I will leave the WIP patches in the attachments, thanks 87063 1 4670 frazer.clews 2020-04-22 03:34:14 +0000 Created attachment 4670 WIP patch to get bitdoc working 87070 2 tim.orling 2020-04-23 07:44:45 +0000 https://git.openembedded.org/bitbake/tree/bin/bitdoc 87080 3 frazer.clews 2020-04-23 08:59:27 +0000 Yeah, that's specifically what I am talking about 87103 4 richard.purdie 2020-04-29 08:40:47 +0000 Thanks, I've done a review of what this script was doing and I'm going to propose a patch to delete it. I did use your code to see what it actually did though, thanks! 87104 5 frazer.clews 2020-04-29 08:48:16 +0000 I agree that it may need removing, although I will say I am not 100% confident the `replace` function works as intended. Since I can't seem to replicate the original behaviour when this did work, just mentioning since you used my patch to test it 87126 6 richard.purdie 2020-04-30 12:34:03 +0000 Thanks, I think even accounting for some issues like the replace function, this script has been superseded by the data in the manuals. I wanted to double check there wasn't anything in here we were missing but I don't think there is. 87132 7 richard.purdie 2020-05-02 03:02:03 +0000 Its gone: http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=7a5cc8659e4ba8f36bcb5322e246005d812efb59 thanks for pointing it out. 4670 2020-04-22 03:34:14 +0000 2020-04-22 03:34:14 +0000 WIP patch to get bitdoc working 0001-fix-bitdoc-syntax.patch text/plain 5745 frazer.clews RnJvbSAwYWQzMmVjMzI4YmIwMDEzNTkwMDgyMDIyYTQ5ZWJkMmY1N2VhOTdiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGcmF6ZXIgQ2xld3MgPGZyYXplci5jbGV3c0Bjb2RldGhpbmsu Y28udWs+CkRhdGU6IE1vbiwgMjAgQXByIDIwMjAgMTQ6MTU6MzggKzAxMDAKU3ViamVjdDogW1BB VENIXSBmaXggYml0ZG9jIHN5bnRheAoKIC0gcmVtb3ZlIG9wdHBhcnNlCiAtIENvbnZlcnQgcHJp bnQgdG8gc3RkZXJyIHRvIHB5dGhvbiAzIHN5bnRheCwgYml0ZG9jIHByaW50IGZpeAogLSBmaXgg cmVwbGFjZSBtZXRob2QKIC0gbWFrZSB1c2FnZSBhIGRlc2NyaXB0aW9uIGluc3RlYWQKIC0gYnVt cCBiaXRkb2MgcmV2aXNpb24KLS0tCiBiaW4vYml0ZG9jIHwgODUgKysrKysrKysrKysrKysrKysr KysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNDEg aW5zZXJ0aW9ucygrKSwgNDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvYmluL2JpdGRvYyBi L2Jpbi9iaXRkb2MKaW5kZXggOWJkMDJiZTYuLjQzNDFkMGUxIDEwMDc1NQotLS0gYS9iaW4vYml0 ZG9jCisrKyBiL2Jpbi9iaXRkb2MKQEAgLTUsMTUgKzUsMTQgQEAKICMgU1BEWC1MaWNlbnNlLUlk ZW50aWZpZXI6IEdQTC0yLjAtb25seQogIwogCi1pbXBvcnQgb3B0cGFyc2UsIG9zLCBzeXMKK2lt cG9ydCBhcmdwYXJzZSwgb3MsIHN5cwogCiAjIGJpdGJha2UKLXN5cy5wYXRoLmFwcGVuZChvcy5w YXRoLmpvaW4ob3MucGF0aC5kaXJuYW1lKG9zLnBhdGguZGlybmFtZShfX2ZpbGVfXyksICdsaWIn KSkKK3N5cy5wYXRoLmluc2VydCgwLCBvcy5wYXRoLmpvaW4ob3MucGF0aC5kaXJuYW1lKG9zLnBh dGguZGlybmFtZShzeXMuYXJndlswXSkpLCAnbGliJykpCiBpbXBvcnQgYmIKIGltcG9ydCBiYi5w YXJzZQotZnJvbSAgIHN0cmluZyBpbXBvcnQgc3BsaXQsIGpvaW4KIAotX192ZXJzaW9uX18gPSAi MC4wLjIiCitfX3ZlcnNpb25fXyA9ICIwLjAuMyIKIAogY2xhc3MgSFRNTEZvcm1hdHRlcjoKICAg ICAiIiIKQEAgLTMxLDEzICszMCwxNCBAQCBjbGFzcyBIVE1MRm9ybWF0dGVyOgogICAgICAgICBr ZXlOQU1FLmh0bWwKICAgICAiIiIKIAotICAgIGRlZiByZXBsYWNlKHNlbGYsIHRleHQsICpwYWly cyk6CisgICAgQHN0YXRpY21ldGhvZAorICAgIGRlZiByZXBsYWNlKHRleHQsICpwYWlycyk6CiAg ICAgICAgICIiIgogICAgICAgICBGcm9tIHB5ZG9jLi4uIGFsbW9zdCBpZGVudGljYWwgYXQgbGVh c3QKICAgICAgICAgIiIiCiAgICAgICAgIHdoaWxlIHBhaXJzOgogICAgICAgICAgICAgKGEsIGIp ID0gcGFpcnNbMF0KLSAgICAgICAgICAgIHRleHQgPSBqb2luKHNwbGl0KHRleHQsIGEpLCBiKQor ICAgICAgICAgICAgdGV4dCA9IGIuam9pbih0ZXh0LnNwbGl0KGEpKQogICAgICAgICAgICAgcGFp cnMgPSBwYWlyc1sxOl0KICAgICAgICAgcmV0dXJuIHRleHQKICAgICBkZWYgZXNjYXBlKHNlbGYs IHRleHQpOgpAQCAtMzkzLDQyICszOTMsMzMgQEAgY2xhc3MgRG9jdW1lbnRhdGlvbjoKICAgICAg ICAgICAgIHJldHVybiBbXQogCiAKLWRlZiBwYXJzZV9jbWRsaW5lKGFyZ3MpOgorZGVmIG1haW4o KToKICAgICAiIiIKLSAgICBQYXJzZSB0aGUgQ01EIGxpbmUgYW5kIHJldHVybiB0aGUgcmVzdWx0 IGFzIGEgbi10dXBsZQorICAgIFRoZSBtYWluIE1ldGhvZAogICAgICIiIgogCi0gICAgcGFyc2Vy ID0gb3B0cGFyc2UuT3B0aW9uUGFyc2VyKCB2ZXJzaW9uID0gIkJpdGJha2UgRG9jdW1lbnRhdGlv biBUb29sIENvcmUgdmVyc2lvbiAlcywgJSVwcm9nIHZlcnNpb24gJXMiICUgKGJiLl9fdmVyc2lv bl9fLCBfX3ZlcnNpb25fXykpCi0gICAgdXNhZ2UgID0gIiIiJXByb2cgW29wdGlvbnNdCi0KLUNy ZWF0ZSBhIHNldCBvZiBodG1sIHBhZ2VzIChkb2N1bWVudGF0aW9uKSBmb3IgYSBiaXRiYWtlLmNv bmYuLi4uCi0iIiIKLQotICAgICMgQWRkIHRoZSBuZWVkZWQgb3B0aW9ucwotICAgIHBhcnNlci5h ZGRfb3B0aW9uKCAiLWMiLCAiLS1jb25maWciLCBoZWxwID0gIlVzZSB0aGUgc3BlY2lmaWVkIGNv bmZpZ3VyYXRpb24gZmlsZSBhcyBzb3VyY2UiLAotICAgICAgICAgICAgICAgICAgICAgICBhY3Rp b24gPSAic3RvcmUiLCBkZXN0ID0gImNvbmZpZyIsIGRlZmF1bHQgPSBvcy5wYXRoLmpvaW4oImNv bmYiLCAiZG9jdW1lbnRhdGlvbi5jb25mIikgKQorICAgIHBhcnNlciA9IGFyZ3BhcnNlLkFyZ3Vt ZW50UGFyc2VyKHByb2c9ImJpdGRvYyIsIGRlc2NyaXB0aW9uPSJDcmVhdGUgYSBzZXQgb2YgaHRt bCBwYWdlcyAoZG9jdW1lbnRhdGlvbikgZm9yIGEgYml0YmFrZS5jb25mLi4uIikKKyAgICBwYXJz ZXIuYWRkX2FyZ3VtZW50KCItLXZlcnNpb24iLCBhY3Rpb249InZlcnNpb24iLCB2ZXJzaW9uPSJC aXRiYWtlIERvY3VtZW50YXRpb24gVG9vbCBDb3JlIHZlcnNpb24gJXMsICVzIHZlcnNpb24gJXMi ICUgKGJiLl9fdmVyc2lvbl9fLCBvcy5wYXRoLmJhc2VuYW1lKF9fZmlsZV9fKSwgX192ZXJzaW9u X18pKQogCi0gICAgcGFyc2VyLmFkZF9vcHRpb24oICItbyIsICItLW91dHB1dCIsIGhlbHAgPSAi T3V0cHV0IGRpcmVjdG9yeSBmb3IgaHRtbCBmaWxlcyIsCi0gICAgICAgICAgICAgICAgICAgICAg IGFjdGlvbiA9ICJzdG9yZSIsIGRlc3QgPSAib3V0cHV0IiwgZGVmYXVsdCA9ICJodG1sLyIgKQor ICAgICMgQWRkIHRoZSBuZWVkZWQgYXJncworICAgIHBhcnNlci5hZGRfYXJndW1lbnQoIi1jIiwg Ii0tY29uZmlnIiwgaGVscD0iVXNlIHRoZSBzcGVjaWZpZWQgY29uZmlndXJhdGlvbiBmaWxlIGFz IHNvdXJjZSIsCisgICAgICAgICAgICAgICAgICAgICAgICBhY3Rpb249InN0b3JlIiwgZGVzdD0i Y29uZmlnIiwgZGVmYXVsdD1vcy5wYXRoLmpvaW4oImNvbmYiLCAiZG9jdW1lbnRhdGlvbi5jb25m IikpCiAKLSAgICBwYXJzZXIuYWRkX29wdGlvbiggIi1EIiwgICItLWRlYnVnIiwgaGVscCA9ICJJ bmNyZWFzZSB0aGUgZGVidWcgbGV2ZWwiLAotICAgICAgICAgICAgICAgICAgICAgICBhY3Rpb24g PSAiY291bnQiLCBkZXN0ID0gImRlYnVnIiwgZGVmYXVsdCA9IDAgKQorICAgIHBhcnNlci5hZGRf YXJndW1lbnQoIi1vIiwgIi0tb3V0cHV0IiwgaGVscD0iT3V0cHV0IGRpcmVjdG9yeSBmb3IgaHRt bCBmaWxlcyIsCisgICAgICAgICAgICAgICAgICAgICAgICBhY3Rpb249InN0b3JlIiwgZGVzdD0i b3V0cHV0IiwgZGVmYXVsdD0iaHRtbC8iKQogCi0gICAgcGFyc2VyLmFkZF9vcHRpb24oICItdiIs ICItLXZlcmJvc2UiLCBoZWxwID0gIm91dHB1dCBtb3JlIGNoaXQtY2hhciB0byB0aGUgdGVybWlu YWwiLAotICAgICAgICAgICAgICAgICAgICAgICBhY3Rpb24gPSAic3RvcmVfdHJ1ZSIsIGRlc3Qg PSAidmVyYm9zZSIsIGRlZmF1bHQgPSBGYWxzZSApCisgICAgcGFyc2VyLmFkZF9hcmd1bWVudCgi LUQiLCAiLS1kZWJ1ZyIsIGhlbHA9IkluY3JlYXNlIHRoZSBkZWJ1ZyBsZXZlbCIsCisgICAgICAg ICAgICAgICAgICAgICAgICBhY3Rpb249ImNvdW50IiwgZGVzdD0iZGVidWciLCBkZWZhdWx0PTAp CiAKLSAgICBvcHRpb25zLCBhcmdzID0gcGFyc2VyLnBhcnNlX2FyZ3MoIHN5cy5hcmd2ICkKLSAK LSAgICBiYi5tc2cuaW5pdF9tc2djb25maWcob3B0aW9ucy52ZXJib3NlLCBvcHRpb25zLmRlYnVn KQorICAgIHBhcnNlci5hZGRfYXJndW1lbnQoIi12IiwgIi0tdmVyYm9zZSIsIGhlbHA9Im91dHB1 dCBtb3JlIGNoaXQtY2hhciB0byB0aGUgdGVybWluYWwiLAorICAgICAgICAgICAgICAgICAgICAg ICAgYWN0aW9uPSJzdG9yZV90cnVlIiwgZGVzdD0idmVyYm9zZSIsIGRlZmF1bHQ9RmFsc2UpCiAK LSAgICByZXR1cm4gb3B0aW9ucy5jb25maWcsIG9wdGlvbnMub3V0cHV0CisgICAgYXJncyA9IHBh cnNlci5wYXJzZV9hcmdzKCkKIAotZGVmIG1haW4oKToKLSAgICAiIiIKLSAgICBUaGUgbWFpbiBN ZXRob2QKLSAgICAiIiIKKyAgICBiYi5tc2cuaW5pdF9tc2djb25maWcoYXJncy52ZXJib3NlLCBh cmdzLmRlYnVnKQogCi0gICAgKGNvbmZpZ19maWxlLCBvdXRwdXRfZGlyKSA9IHBhcnNlX2NtZGxp bmUoIHN5cy5hcmd2ICkKKyAgICBjb25maWdfZmlsZSA9IGFyZ3MuY29uZmlnCisgICAgb3V0cHV0 X2RpciA9IGFyZ3Mub3V0cHV0CiAKICAgICAjIHJpZ2h0IHRvIGxldCB1cyBsb2FkIHRoZSBmaWxl IG5vdwogICAgIHRyeToKQEAgLTQ5MiwyNyArNDgzLDMzIEBAIGRlZiBtYWluKCk6CiAgICAgIyBr ZXlzIGFuZCBncm91cHMKICAgICBodG1sX3NsYXZlID0gSFRNTEZvcm1hdHRlcigpCiAKLSAgICBm ID0gZmlsZSgnc3R5bGUuY3NzJywgJ3cnKQotICAgIHByaW50ID4+IGYsIGh0bWxfc2xhdmUuY3Jl YXRlQ1NTKCkKKyAgICBmaWxlID0gb3Blbigic3R5bGUuY3NzIiwgIncrIikKKyAgICBmaWxlLndy aXRlKGh0bWxfc2xhdmUuY3JlYXRlQ1NTKCkpCisgICAgZmlsZS5jbG9zZSgpCiAKLSAgICBmID0g ZmlsZSgnaW5kZXguaHRtbCcsICd3JykKLSAgICBwcmludCA+PiBmLCBodG1sX3NsYXZlLmNyZWF0 ZUluZGV4KCkKKyAgICBmaWxlID0gb3BlbigiaW5kZXguaHRtbCIsICJ3KyIpCisgICAgZmlsZS53 cml0ZShodG1sX3NsYXZlLmNyZWF0ZUluZGV4KCkpCisgICAgZmlsZS5jbG9zZSgpCiAKLSAgICBm ID0gZmlsZSgnYWxsX2dyb3Vwcy5odG1sJywgJ3cnKQotICAgIHByaW50ID4+IGYsIGh0bWxfc2xh dmUuY3JlYXRlR3JvdXBzU2l0ZShkb2MpCisgICAgZmlsZSA9IG9wZW4oImFsbF9ncm91cHMuaHRt bCIsICJ3KyIpCisgICAgZmlsZS53cml0ZShodG1sX3NsYXZlLmNyZWF0ZUdyb3Vwc1NpdGUoZG9j KSkKKyAgICBmaWxlLmNsb3NlKCkKIAotICAgIGYgPSBmaWxlKCdhbGxfa2V5cy5odG1sJywgJ3cn KQotICAgIHByaW50ID4+IGYsIGh0bWxfc2xhdmUuY3JlYXRlS2V5c1NpdGUoZG9jKQorICAgIGZp bGUgPSBvcGVuKCJhbGxfa2V5cy5odG1sIiwgIncrIikKKyAgICBmaWxlLndyaXRlKGh0bWxfc2xh dmUuY3JlYXRlS2V5c1NpdGUoZG9jKSkKKyAgICBmaWxlLmNsb3NlKCkKIAogICAgICMgbm93IGZv ciBlYWNoIGdyb3VwIGNyZWF0ZSB0aGUgc2l0ZQogICAgIGZvciBncm91cCBpbiBkb2MuZ3JvdXBz KCk6Ci0gICAgICAgIGYgPSBmaWxlKCdncm91cCVzLmh0bWwnICUgZ3JvdXAsICd3JykKLSAgICAg ICAgcHJpbnQgPj4gZiwgaHRtbF9zbGF2ZS5jcmVhdGVHcm91cFNpdGUoZ3JvdXAsIGRvYy5ncm91 cF9jb250ZW50KGdyb3VwKSkKKyAgICAgICAgZmlsZSA9IG9wZW4oImdyb3VwJXMuaHRtbCIgJSBn cm91cCwgIncrIikKKyAgICAgICAgZmlsZS53cml0ZShodG1sX3NsYXZlLmNyZWF0ZUdyb3VwU2l0 ZShncm91cCwgZG9jLmdyb3VwX2NvbnRlbnQoZ3JvdXApKSkKKyAgICAgICAgZmlsZS5jbG9zZSgp CiAKICAgICAjIG5vdyBmb3IgdGhlIGtleXMKICAgICBmb3Iga2V5IGluIGRvYy5kb2Nfa2V5cygp OgotICAgICAgICBmID0gZmlsZSgna2V5JXMuaHRtbCcgJSBkb2MuZG9jX2l0ZW0oa2V5KS5uYW1l KCksICd3JykKLSAgICAgICAgcHJpbnQgPj4gZiwgaHRtbF9zbGF2ZS5jcmVhdGVLZXlTaXRlKGRv Yy5kb2NfaXRlbShrZXkpKQorICAgICAgICBmaWxlID0gb3Blbigia2V5JXMuaHRtbCIgJSBkb2Mu ZG9jX2l0ZW0oa2V5KS5uYW1lKCksICJ3KyIpCisgICAgICAgIGZpbGUud3JpdGUoaHRtbF9zbGF2 ZS5jcmVhdGVLZXlTaXRlKGRvYy5kb2NfaXRlbShrZXkpKSkKKyAgICAgICAgZmlsZS5jbG9zZSgp CiAKIAogaWYgX19uYW1lX18gPT0gIl9fbWFpbl9fIjoKLS0gCjIuMjUuMwoK