13891 2020-05-03 04:48:04 +0000 insane.bbclass: do_package_qa hangs when checking a FIFO (named pipe) file 2021-04-29 15:53:10 +0000 1 1 7 Build System, Metadata & Runtime OE-Core core 2.6.4 x86 Multiple RESOLVED FIXED Medium+ normal 3.3 M3 1 Ahmed.Hossam twoerner meta.mr.watcher meta.watcher randy.macleod twoerner --- --- No (bug/feature does not impact docs) oldest_to_newest 87136 0 Ahmed.Hossam 2020-05-03 04:48:04 +0000 do_package_qa:package_qa_walk hangs when attempting to open a FIFO file in the package, specifically at elf.open() statement, this is because FIFOs block when opened for read. To reproduce add the following to an example recipe: DEPENDS += "coreutils-native" FILES_${PN} += " \ /usr/run \ " do_install_append() { mkdir -p ${D}/usr/run/${PN} mkfifo -m 0666 ${D}/usr/run/${PN}/fifo } P.S. It looks like this might be a regression as it was supposed to be fixed according to this mail in the mailing list: https://www.yoctoproject.org/pipermail/yocto/2016-February/028424.html 87137 1 Ahmed.Hossam 2020-05-03 04:54:21 +0000 A very bad workaround is to skip qa for the recipe: python do_package_qa() { pass } 87138 2 Ahmed.Hossam 2020-05-03 05:29:42 +0000 Reproduced on master SHA 7a5cc8659e4ba8f36bcb5322e246005d812efb59 87163 3 randy.macleod 2020-05-07 07:38:11 +0000 Needs an automated test as well. 88809 4 twoerner 2020-12-24 12:43:12 +0000 One of the tests in insane.bbclass (package_qa_check_shebang_size()) tries to read the contents of the object looking for the #!. If the object is a fifo, any read(2) of its contents will hang forever, waiting for contents to appear. The patch to fix this is as follows and has been submitted to the mailing list: diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index cf2165c517..105d2a5ce8 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass @@ -87,7 +87,8 @@ def package_qa_add_message(messages, section, new_msg): QAPATHTEST[shebang-size] = "package_qa_check_shebang_size" def package_qa_check_shebang_size(path, name, d, elf, messages): - if os.path.islink(path) or elf: + import stat + if os.path.islink(path) or stat.S_ISFIFO(os.stat(path).st_mode) or elf: return try: The patch is here: https://lists.openembedded.org/g/openembedded-core/topic/master_next_patch_1_3/79198302 88820 5 twoerner 2020-12-27 06:45:42 +0000 A patch to add an automated test is: https://lists.openembedded.org/g/openembedded-core/message/146221 90184 6 randy.macleod 2021-04-29 15:53:10 +0000 Fix in oe-core: https://git.openembedded.org/openembedded-core/commit/?id=a7b1d22e93c8846d84a9855876038c2b38958dec $ git branch -a --contains a7b1d22e93c hardknott master Test: https://git.openembedded.org/openembedded-core/commit/?id=53988b6389ce618d4cff52bd09ae91108beca354 $ git branch -a --contains 53988b6389ce618d4cff52bd09ae91108beca354 hardknott master Thanks Trevor!