14015 2020-08-19 05:48:07 +0000 URL Arguments in MIRROR/PREMIRROR get encoded 2024-02-08 16:09:04 +0000 1 1 7 Build System, Metadata & Runtime BitBake bitbake 3.1.2 x86 Multiple RESOLVED OBSOLETE Medium+ normal 5.99 1 yoctoproject.bugzilla yoctoproject.bugzilla mark.asselstine poky.bs.watcher poky.watcher randy.macleod tgamblin Vikkram.Ravi --- --- Don't know oldest_to_newest 87981 0 yoctoproject.bugzilla 2020-08-19 05:48:07 +0000 After successfully putting a PREMIRROR for our builds on a blob storage, I wanted to keep that storage completely private, so adding I thought the following would work: SAS_TOKEN = "?sv=2019-12-12&ss=bf&srt=co&sp=rdl&spr=https&sig=abcdef_TEST" INHERIT += "own-mirrors" SOURCE_MIRROR_URL = "https://somewhere.blob.core.windows.net/our-mirror/downloads/BASENAME${SAS_TOKEN}" BB_FETCH_PREMIRRORONLY = "1" Well it kind of does work, but the arguments of the SAS_TOKEN get encoded and the fetch via wget will fail. Expected behavior: SAS_TOKEN will not be encoded / = have a possibility to add URL parts that will not be encoded. FYI: I also asked a question about this on stackoverflow https://stackoverflow.com/questions/63486550/yocto-premirror-source-mirror-url-with-url-arguments-sas-token-possible 96070 1 randy.macleod 2023-07-26 21:22:01 +0000 Bulk move of 64 bugs to 4.3 M3 after a quick review. If a bug is actually fixed, please add a commit link and resolve it. -- Randy for YP bug team. 96464 2 tgamblin 2023-09-14 16:36:54 +0000 Moved to M4. 97059 3 randy.macleod 2023-10-30 15:29:09 +0000 Bulk move to 5.0 M1. -- Randy 97404 4 mark.asselstine 2023-12-03 00:54:16 +0000 Jahn, do you know of a publicly available example that I could use to attempt to reproduce and review this issue? It appears that the code does map with your assertion that the URL is encoded. dodwnload()->try_mirrors()->build_mirroruris()->uri_replace() which does a decode to complete the find and replace of the URL ends with a call to encodeurl() which encodes just the "path" component of the URL with a call to urllib.parse.quote(path). The interesting bit is that wget will work just fine with an encoded URL, per the manual "You can encode unsafe characters in a URL as ‘%xy’, xy being the hexadecimal representation of the character’s ASCII value. Some common unsafe characters include ‘%’ (quoted as ‘%25’), ‘:’ (quoted as ‘%3A’), and ‘@’ (quoted as ‘%40’). Refer to RFC1738 for a comprehensive list of unsafe characters." - https://www.gnu.org/software/wget/manual/wget.html which is why I ask about a reproducer. 97640 5 randy.macleod 2023-12-21 20:38:42 +0000 Jahn, are you able to share a reproducer as Mark requested? 98094 6 randy.macleod 2024-02-01 16:06:38 +0000 Moving to 5.99 (near term release but not 5.0) since we don't have a reproducer. 98160 7 randy.macleod 2024-02-08 16:09:04 +0000 No repsponse for a few years so closing. We'd consider the bug again if we can get a reproducer.