<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>14045</bug_id>
          
          <creation_ts>2020-09-16 05:29:29 +0000</creation_ts>
          <short_desc>git fetcher deadlock with self-referencing sub-modules</short_desc>
          <delta_ts>2022-11-20 11:32:15 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>BitBake</product>
          <component>bitbake</component>
          <version>3.4</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>4.2 M1</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>kenth.eriksson</reporter>
          <assigned_to name="Richard Purdie">richard.purdie</assigned_to>
          <cc>jonathan.crockett</cc>
    
    <cc>kenth.eriksson</cc>
    
    <cc>pavel</cc>
    
    <cc>poky.bs.watcher</cc>
    
    <cc>poky.watcher</cc>
    
    <cc>randy.macleod</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>88149</commentid>
    <comment_count>0</comment_count>
    <who name="">kenth.eriksson</who>
    <bug_when>2020-09-16 05:29:29 +0000</bug_when>
    <thetext>gitsm fetcher dead locks if submodule is self-referencing. The fetcher creates lock/done files in DL/git2 folder. Due to this design, it cannot handle repositories where submodule is a specific revision of the the parent repo.

As an example where a dead lock will happen, consider the following repository, https://github.com/gflags/gflags, where the doc folder is submodule of the parent repository.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88156</commentid>
    <comment_count>1</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2020-09-17 07:37:10 +0000</bug_when>
    <thetext>We should add a check to avoid the deadlock.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>93925</commentid>
    <comment_count>2</comment_count>
    <who name="Pavel Zhukov">pavel</who>
    <bug_when>2022-08-26 08:43:06 +0000</bug_when>
    <thetext>https://lists.openembedded.org/g/bitbake-devel/message/13934</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>93980</commentid>
    <comment_count>3</comment_count>
    <who name="Pavel Zhukov">pavel</who>
    <bug_when>2022-09-06 15:10:12 +0000</bug_when>
    <thetext>Resolved in https://git.openembedded.org/bitbake/commit/?id=0361ecf7eb82c386a9842cf1f3cb706c0a112e77

Test case added to cover possible regressions.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>94154</commentid>
    <comment_count>4</comment_count>
    <who name="Jonathan Crockett">jonathan.crockett</who>
    <bug_when>2022-10-13 17:23:30 +0000</bug_when>
    <thetext>This patch breaks cases where the parent repo matches the submodule except the submodule has additional chars to the repo name. 

E.g. parent is alpha and submodule is alpha-keys will now fail because the patch only looks at alpha not the end line, even though they are valid different repositories.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>94159</commentid>
    <comment_count>5</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2022-10-13 21:44:51 +0000</bug_when>
    <thetext>See Jonathan&apos;s comment.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>94409</commentid>
    <comment_count>6</comment_count>
    <who name="Pavel Zhukov">pavel</who>
    <bug_when>2022-11-13 10:48:39 +0000</bug_when>
    <thetext>https://lists.openembedded.org/g/bitbake-devel/message/14076</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>94432</commentid>
    <comment_count>7</comment_count>
    <who name="Pavel Zhukov">pavel</who>
    <bug_when>2022-11-18 11:53:26 +0000</bug_when>
    <thetext>Should be fixed by https://git.openembedded.org/bitbake/commit/?id=3ad27272c18f2bb9edd441f840167a3dabd5407b</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>94436</commentid>
    <comment_count>8</comment_count>
    <who name="Richard Purdie">richard.purdie</who>
    <bug_when>2022-11-20 11:32:15 +0000</bug_when>
    <thetext>Thanks for the help Pavel!</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>