14080 2020-10-08 05:48:33 +0000 string replace in do_install_append breaks pseudo 2020-10-09 04:05:04 +0000 1 1 7 Build System, Metadata & Runtime OE-Core core unspecified x86 Multiple RESOLVED FIXED Medium+ major 3.2 M4 1 nickersk richard.purdie JPEWhacker meta.mr.watcher meta.watcher randy.macleod richard.purdie --- --- No (bug/feature does not impact docs) oldest_to_newest 88321 0 nickersk 2020-10-08 05:48:33 +0000 we have in do_install_append in initscripts bbappend this replace commands: perl -i -pe 's:mount -a.+?$:mount -a -t nonfs,nfs4,smbfs,cifs,ncp,ncpfs,coda,ocfs2,gfs,gfs2,ceph -O no_netdev 2>/dev/null:' ${D}${sysconfdir}/init.d/mountall.sh perl -i -pe 's:(mount -a).*?$:$1:' ${D}${sysconfdir}/init.d/mountnfs.sh which causes pseudo abort and build fail. this error became in place after this oe-core commit: https://git.openembedded.org/openembedded-core/commit/?h=master-next&id=2db491d97da08d44ebd257f98489550a82a7935c how can/should be this error fixed? 88326 1 randy.macleod 2020-10-08 07:52:43 +0000 CAan you clean the recipe and report if this is reproducible? If it is, please also, try to remove your <proj>/tmp directory? Richard is going to add a warning if this clean-up is needed. 88336 2 nickersk 2020-10-08 08:36:03 +0000 wipeing out tmpdir, do_cleanall and build from scratch didnt work, same error exit 134 from 'perl -i -pe 's:mount -a.+?$:mount -a -t nonfs,nfs4,smbfs,cifs,ncp,ncpfs,coda,ocfs2,gfs,g fs2,ceph -O no_netdev 2>/dev/null:' tmp/work/mips32el-oe-linux/initscripts/1.0-r155.7/image/etc/init.d/mountall.sh' 88337 3 JPEWhacker 2020-10-08 08:38:32 +0000 I ran perl under strace to see if it's doing something weird. Here is the relevant output: $ touch foo.txt; strace perl -i -pe 's:(mount -a).*?$:$1:' foo.txt openat(AT_FDCWD, "foo.txt", O_RDONLY) = 3 ioctl(3, TCGETS, 0x7fffde1209f0) = -1 ENOTTY (Inappropriate ioctl for device) lseek(3, 0, SEEK_CUR) = 0 fstat(3, {st_mode=S_IFREG|0644, st_size=0, ...}) = 0 fcntl(3, F_SETFD, FD_CLOEXEC) = 0 unlink("foo.txt") = 0 openat(AT_FDCWD, "foo.txt", O_WRONLY|O_CREAT|O_EXCL, 0600) = 4 ioctl(4, TCGETS, 0x7fffde1209f0) = -1 ENOTTY (Inappropriate ioctl for device) lseek(4, 0, SEEK_CUR) = 0 fstat(4, {st_mode=S_IFREG|0600, st_size=0, ...}) = 0 fcntl(4, F_SETFD, FD_CLOEXEC) = 0 fstat(4, {st_mode=S_IFREG|0600, st_size=0, ...}) = 0 fchmod(4, 0100644) = 0 read(3, "", 8192) = 0 close(4) = 0 close(3) = 0 88347 4 richard.purdie 2020-10-08 14:28:59 +0000 I think Joshua ran that under perl 5.26.1 and I saw similar on my build machine where that do_install_append worked. I did find a machine with perl 5.30 on it which gave: openat(AT_FDCWD, "foo.txt", O_RDONLY|O_CLOEXEC) = 3 ioctl(3, TCGETS, 0x7ffe3b6def30) = -1 ENOTTY (Inappropriate ioctl for device) lseek(3, 0, SEEK_CUR) = 0 fstat(3, {st_mode=S_IFREG|0664, st_size=0, ...}) = 0 umask(0177) = 002 getpid() = 3242451 openat(AT_FDCWD, "XXCPEqW8", O_RDWR|O_CREAT|O_EXCL|O_CLOEXEC, 0600) = 4 fcntl(4, F_GETFD) = 0x1 (flags FD_CLOEXEC) umask(002) = 0177 fcntl(4, F_SETFD, FD_CLOEXEC) = 0 ioctl(4, TCGETS, 0x7ffe3b6defc0) = -1 ENOTTY (Inappropriate ioctl for device) lseek(4, 0, SEEK_CUR) = 0 fstat(4, {st_mode=S_IFREG|0600, st_size=0, ...}) = 0 getpid() = 3242451 openat(AT_FDCWD, ".", O_RDONLY|O_NONBLOCK|O_CLOEXEC|O_DIRECTORY) = 5 fstat(5, {st_mode=S_IFDIR|S_ISVTX|0777, st_size=978944, ...}) = 0 fstat(4, {st_mode=S_IFREG|0600, st_size=0, ...}) = 0 fchmod(4, 0100664) = 0 brk(0x55aebdfc7000) = 0x55aebdfc7000 read(3, "", 8192) = 0 close(4) = 0 getpid() = 3242451 renameat(5, "XXCPEqW8", 5, "foo.txt") = 0 close(5) = 0 close(3) = 0 Which perl version is on the system from the original report? 88348 5 richard.purdie 2020-10-08 14:59:56 +0000 I confirmed this is only an issue with perl 5.30 and does abort on that system. It looks like the: openat(AT_FDCWD, "XXCPEqW8", O_RDWR|O_CREAT|O_EXCL|O_CLOEXEC, 0600) = 4 call isn't seen by pseudo. Running out of time to work out why today though. 88349 6 4737 richard.purdie 2020-10-08 15:35:50 +0000 Created attachment 4737 Patch to pseudo which fixed the issue on my system 88350 7 richard.purdie 2020-10-08 15:36:58 +0000 When I applied the attached patch to pseudo, this started working for me on my system with perl 5.30. Could you confirm if it works for you please? 88351 8 nickersk 2020-10-08 22:36:49 +0000 I can confirm, works with provided patch. Thank You. 88355 9 richard.purdie 2020-10-09 04:05:04 +0000 Thanks for testing. I've merged the fix into pseudo and master: http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=d446d8b818a49e66b72fccbd29328cdbf4294239 4737 2020-10-08 15:35:50 +0000 2020-10-08 15:35:50 +0000 Patch to pseudo which fixed the issue on my system mkostemp64.patch text/plain 3787 richard.purdie SW5kZXg6IGdpdC9wb3J0cy9saW51eC9ndXRzL21rb3N0ZW1wNjQuYwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSAv ZGV2L251bGwKKysrIGdpdC9wb3J0cy9saW51eC9ndXRzL21rb3N0ZW1wNjQuYwpAQCAtMCwwICsx LDQ5IEBACisvKiAKKyAqIENvcHlyaWdodCAoYykgMjAxMCBXaW5kIFJpdmVyIFN5c3RlbXM7IHNl ZQorICogZ3V0cy9DT1BZUklHSFQgZm9yIGluZm9ybWF0aW9uLgorICoKKyAqIFNQRFgtTGljZW5z ZS1JZGVudGlmaWVyOiBMR1BMLTIuMS1vbmx5CisgKgorICogc3RhdGljIGludAorICogd3JhcF9t a3N0ZW1wNjQoY2hhciAqdGVtcGxhdGUsIGludCBvZmxhZ3MpIHsKKyAqCWludCByYyA9IC0xOwor ICovCisJc3RydWN0IHN0YXQ2NCBidWY7CisgCWludCBzYXZlX2Vycm5vOworCXNpemVfdCBsZW47 CisJY2hhciAqdG1wX3RlbXBsYXRlOworCisJaWYgKCF0ZW1wbGF0ZSkgeworCQllcnJubyA9IEVG QVVMVDsKKwkJcmV0dXJuIDA7CisJfQorCisJbGVuID0gc3RybGVuKHRlbXBsYXRlKTsKKwl0bXBf dGVtcGxhdGUgPSBQU0VVRE9fUk9PVF9QQVRIKEFUX0ZEQ1dELCB0ZW1wbGF0ZSwgQVRfU1lNTElO S19OT0ZPTExPVyk7CisKKwlpZiAoIXRtcF90ZW1wbGF0ZSkgeworCQllcnJubyA9IEVOT0VOVDsK KwkJcmV0dXJuIC0xOworCX0KKworCXJjID0gcmVhbF9ta29zdGVtcDY0KHRtcF90ZW1wbGF0ZSwg b2ZsYWdzKTsKKworCWlmIChyYyAhPSAtMSkgeworCQlzYXZlX2Vycm5vID0gZXJybm87CisKKwkJ aWYgKHJlYWxfX19meHN0YXQ2NChfU1RBVF9WRVIsIHJjLCAmYnVmKSAhPSAtMSkgeworCQkJcmVh bF9mY2htb2QocmMsIFBTRVVET19GU19NT0RFKDA2MDAsIDApKTsKKwkJCXBzZXVkb19jbGllbnRf b3AoT1BfQ1JFQVQsIDAsIC0xLCAtMSwgdG1wX3RlbXBsYXRlLCAmYnVmKTsKKwkJCXBzZXVkb19j bGllbnRfb3AoT1BfT1BFTiwgUFNBX1JFQUQgfCBQU0FfV1JJVEUsIHJjLCAtMSwgdG1wX3RlbXBs YXRlLCAmYnVmKTsKKwkJfSBlbHNlIHsKKwkJCXBzZXVkb19kZWJ1ZyhQREJHRl9DT05TSVNURU5D WSwgIm1rc3RlbXAgKGZkICVkKSBzdWNjZWVkZWQsIGJ1dCBmc3RhdCBmYWlsZWQgKCVzKS5cbiIs CisJCQkJcmMsIHN0cmVycm9yKGVycm5vKSk7CisJCQlwc2V1ZG9fY2xpZW50X29wKE9QX09QRU4s IFBTQV9SRUFEIHwgUFNBX1dSSVRFLCByYywgLTEsIHRtcF90ZW1wbGF0ZSwgMCk7CisJCX0KKwkJ ZXJybm8gPSBzYXZlX2Vycm5vOworCX0KKwkvKiBta3N0ZW1wIG9ubHkgY2hhbmdlcyB0aGUgWFhY WFhYIGF0IHRoZSBlbmQuICovCisJbWVtY3B5KHRlbXBsYXRlICsgbGVuIC0gNiwgdG1wX3RlbXBs YXRlICsgc3RybGVuKHRtcF90ZW1wbGF0ZSkgLSA2LCA2KTsKKy8qCXJldHVybiByYzsKKyAqIH0K KyAqLwpJbmRleDogZ2l0L3BvcnRzL2xpbnV4L2d1dHMvbWtzdGVtcDY0LmMKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gZ2l0Lm9yaWcvcG9ydHMvbGludXgvZ3V0cy9ta3N0ZW1wNjQuYworKysgZ2l0L3BvcnRzL2xp bnV4L2d1dHMvbWtzdGVtcDY0LmMKQEAgLTEsNSArMSw1IEBACiAvKiAKLSAqIENvcHlyaWdodCAo YykgMjAxMCBXaW5kIFJpdmVyIFN5c3RlbXM7IHNlZQorICogQ29weXJpZ2h0IChjKSAyMDA4LTIw MTAsIDIwMTIgV2luZCBSaXZlciBTeXN0ZW1zOyBzZWUKICAqIGd1dHMvQ09QWVJJR0hUIGZvciBp bmZvcm1hdGlvbi4KICAqCiAgKiBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogTEdQTC0yLjEtb25s eQpAQCAtOCw0MiArOCw5IEBACiAgKiB3cmFwX21rc3RlbXA2NChjaGFyICp0ZW1wbGF0ZSkgewog ICoJaW50IHJjID0gLTE7CiAgKi8KLQlzdHJ1Y3Qgc3RhdDY0IGJ1ZjsKLSAJaW50IHNhdmVfZXJy bm87Ci0Jc2l6ZV90IGxlbjsKLQljaGFyICp0bXBfdGVtcGxhdGU7CisJLyogbWtzdGVtcDY0KCkg aXMganVzdCBsaWtlIG1rb3N0ZW1wNjQoKSB3aXRoIG5vIGZsYWdzICovCisJcmMgPSB3cmFwX21r b3N0ZW1wNjQodGVtcGxhdGUsIDApOwogCi0JaWYgKCF0ZW1wbGF0ZSkgewotCQllcnJubyA9IEVG QVVMVDsKLQkJcmV0dXJuIDA7Ci0JfQotCi0JbGVuID0gc3RybGVuKHRlbXBsYXRlKTsKLQl0bXBf dGVtcGxhdGUgPSBQU0VVRE9fUk9PVF9QQVRIKEFUX0ZEQ1dELCB0ZW1wbGF0ZSwgQVRfU1lNTElO S19OT0ZPTExPVyk7Ci0KLQlpZiAoIXRtcF90ZW1wbGF0ZSkgewotCQllcnJubyA9IEVOT0VOVDsK LQkJcmV0dXJuIC0xOwotCX0KLQotCXJjID0gcmVhbF9ta3N0ZW1wNjQodG1wX3RlbXBsYXRlKTsK LQotCWlmIChyYyAhPSAtMSkgewotCQlzYXZlX2Vycm5vID0gZXJybm87Ci0KLQkJaWYgKHJlYWxf X19meHN0YXQ2NChfU1RBVF9WRVIsIHJjLCAmYnVmKSAhPSAtMSkgewotCQkJcmVhbF9mY2htb2Qo cmMsIFBTRVVET19GU19NT0RFKDA2MDAsIDApKTsKLQkJCXBzZXVkb19jbGllbnRfb3AoT1BfQ1JF QVQsIDAsIC0xLCAtMSwgdG1wX3RlbXBsYXRlLCAmYnVmKTsKLQkJCXBzZXVkb19jbGllbnRfb3Ao T1BfT1BFTiwgUFNBX1JFQUQgfCBQU0FfV1JJVEUsIHJjLCAtMSwgdG1wX3RlbXBsYXRlLCAmYnVm KTsKLQkJfSBlbHNlIHsKLQkJCXBzZXVkb19kZWJ1ZyhQREJHRl9DT05TSVNURU5DWSwgIm1rc3Rl bXAgKGZkICVkKSBzdWNjZWVkZWQsIGJ1dCBmc3RhdCBmYWlsZWQgKCVzKS5cbiIsCi0JCQkJcmMs IHN0cmVycm9yKGVycm5vKSk7Ci0JCQlwc2V1ZG9fY2xpZW50X29wKE9QX09QRU4sIFBTQV9SRUFE IHwgUFNBX1dSSVRFLCByYywgLTEsIHRtcF90ZW1wbGF0ZSwgMCk7Ci0JCX0KLQkJZXJybm8gPSBz YXZlX2Vycm5vOwotCX0KLQkvKiBta3N0ZW1wIG9ubHkgY2hhbmdlcyB0aGUgWFhYWFhYIGF0IHRo ZSBlbmQuICovCi0JbWVtY3B5KHRlbXBsYXRlICsgbGVuIC0gNiwgdG1wX3RlbXBsYXRlICsgc3Ry bGVuKHRtcF90ZW1wbGF0ZSkgLSA2LCA2KTsKIC8qCXJldHVybiByYzsKICAqIH0KICAqLwpJbmRl eDogZ2l0L3BvcnRzL2xpbnV4L3dyYXBmdW5jcy5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBnaXQub3JpZy9w b3J0cy9saW51eC93cmFwZnVuY3MuaW4KKysrIGdpdC9wb3J0cy9saW51eC93cmFwZnVuY3MuaW4K QEAgLTM2LDYgKzM2LDcgQEAgaW50IGZ0dzY0KGNvbnN0IGNoYXIgKnBhdGgsIGludCAoKmZuKShj bwogaW50IGdsb2I2NChjb25zdCBjaGFyICpwYXR0ZXJuLCBpbnQgZmxhZ3MsIGludCAoKmVycmZ1 bmMpKGNvbnN0IGNoYXIgKiwgaW50KSwgZ2xvYjY0X3QgKnBnbG9iKTsKIGludCBzY2FuZGlyNjQo Y29uc3QgY2hhciAqcGF0aCwgc3RydWN0IGRpcmVudDY0ICoqKm5hbWVsaXN0LCBpbnQgKCpmaWx0 ZXIpKGNvbnN0IHN0cnVjdCBkaXJlbnQ2NCAqKSwgaW50ICgqY29tcGFyKSgpKTsKIGludCB0cnVu Y2F0ZTY0KGNvbnN0IGNoYXIgKnBhdGgsIG9mZjY0X3QgbGVuZ3RoKTsKK2ludCBta29zdGVtcDY0 KGNoYXIgKnRlbXBsYXRlLCBpbnQgb2ZsYWdzKTsgLyogZmxhZ3M9QVRfU1lNTElOS19OT0ZPTExP VyAqLwogaW50IG1rc3RlbXA2NChjaGFyICp0ZW1wbGF0ZSk7IC8qIGZsYWdzPUFUX1NZTUxJTktf Tk9GT0xMT1cgKi8KIGludCBnZXRncm91cGxpc3QoY29uc3QgY2hhciAqdXNlciwgZ2lkX3QgZ3Jv dXAsIGdpZF90ICpncm91cHMsIGludCAqbmdyb3Vwcyk7CiBpbnQgc2V0Z3JvdXBzKHNpemVfdCBz aXplLCBjb25zdCBnaWRfdCAqbGlzdCk7Cg==