14179 2021-01-09 09:27:29 +0000 Need to validate user isn't building in a PSEUDO_IGNORE_PATHS 2021-01-29 14:59:02 +0000 1 1 7 Build System, Metadata & Runtime OE-Core core 3.3 x86 Multiple RESOLVED FIXED NEWCOMER Medium+ normal 3.3 M3 1 richard.purdie dorindabassey dorindabassey meta.mr.watcher meta.watcher randy.macleod yf3yu --- --- Yes (doc changes required) oldest_to_newest 88897 0 richard.purdie 2021-01-09 09:27:29 +0000 If a user builds in a path in PSEUDO_IGNORE_PATHS we need to error from a sanity test in sanity.bbclass rather than give them random failures. A recent example was an openbmi user building in /usr/local. 88953 1 dorindabassey 2021-01-17 21:25:19 +0000 Hi, Would adding this check in the function in sanity.bbclass suffice? def check_sanity_everybuild(status, d): # Check that user isn't building in PSEUDO_IGNORE_PATHS pseudoignorepaths = d.getVar('PSEUDO_IGNORE_PATHS').split(",") workdir = d.getVar('WORKDIR') for i in pseudoignorepaths: if(i in workdir): status.addresult("you are building in a path under PSEUDO_IGNORE_PATHS, please remove this" + str(i) + "directory in \nParsed WORKDIR: " + str(workdir) + "\n") 88957 2 richard.purdie 2021-01-19 15:54:02 +0000 I think rather than "i in workdir", you might want to use: if workdir.startswith(i): but otherwise it looks good to me. 88958 3 richard.purdie 2021-01-19 15:54:41 +0000 Oh, also, do we need to run this test everybuild? I think we already test when tmpdir changes so we probably don't need to. 88959 4 yf3yu 2021-01-19 16:01:15 +0000 looks like Dorinda did the work for me. I'll new to the project so I'll try to come up with my own solution. Dorinda, Feel free to send your patch in though, I can also run some tests 88960 5 dorindabassey 2021-01-19 17:48:11 +0000 Ok i get Thanks, so since workdir path already begins with tmpdir, then it might be better to add this under the conditional statement that checks when tmpdir changes: # Also Check that user isn't building in PSEUDO_IGNORE_PATHS pseudoignorepaths = d.getVar('PSEUDO_IGNORE_PATHS').split(",") for i in pseudoignorepaths: if tmpdir.startswith(i): status.addresult("your tmpdir also contains a PSEUDO_IGNORE_PATHS, please remove this" + str(i) + "directory in \nParsed TMPDIR: " + str(tmpdir) + "\n") 88961 6 dorindabassey 2021-01-19 17:55:36 +0000 oh Alright Yi Fan Yu, i will send a patch in due time thanks. 88962 7 randy.macleod 2021-01-19 17:58:55 +0000 Let's make this official since Dorinda is working on this bug. Thanks Dorinda. 88965 8 yf3yu 2021-01-19 18:43:45 +0000 Since I won't be working on this anymore, Here might be something to keep in mind with PSEUDO_IGNORE_PATH -variables are included in the PSEUDO_IGNORE_PATH `${BUILDHISTORY_DIR}` and `${CCACHE_DIR}` 88966 9 yf3yu 2021-01-19 18:59:52 +0000 More things... -just doing `i in list` can cause issues such as if i am building in `home/NAME/usr/b/` the sanity check might trigger since it found `/usr` -I think it makes sense just inserting it in `check_sanity_version_change(..)` so it runs basically once. only issue I see is that a person might move everything to a suspicious directory after a build. -_- 88968 10 dorindabassey 2021-01-20 10:41:09 +0000 Okay i see, thank you Yi Fan Yu, took note of your points hence am adding this in check_sanity_version_change(status, d): # Check that user isn't building in PSEUDO_IGNORE_PATHS pseudoignorepaths = d.getVar('PSEUDO_IGNORE_PATHS', expand=True).split(",") workdir = d.getVar('WORKDIR', expand=True) for i in pseudoignorepaths: if workdir.startswith(i): status.addresult("you are building in a path under PSEUDO_IGNORE_PATHS, please remove this" + str(i) + "directory in \nParsed WORKDIR: " + str(workdir) + "\n") i should submit a patch soon. 89073 11 dorindabassey 2021-01-29 01:45:52 +0000 patch submitted to mailing list @ https://lists.openembedded.org/g/openembedded-core/message/147238?p=,,,20,0,0,0::Created,,verify+that+user,20,2,0,80117826 89082 12 randy.macleod 2021-01-29 14:59:02 +0000 Thanks Dorinda. Next time please provide a link to the commit since not all submissions to the emails list are merged. This one is on master: http://cgit.openembedded.org/openembedded-core/commit/?id=7a681525e904914e938de25df5cc64209097d15d