<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>14220</bug_id>
          
          <creation_ts>2021-02-04 16:46:59 +0000</creation_ts>
          <short_desc>ptest-runner cannot handle large child output</short_desc>
          <delta_ts>2021-04-07 14:20:03 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>10</classification_id>
          <classification>QA/Testing</classification>
          <product>Package Testing (ptest)</product>
          <component>ptest</component>
          <version>unspecified</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>3.3 M3</target_milestone>
          
          <blocked>14170</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Yi Fan Yu">yf3yu</reporter>
          <assigned_to name="Aníbal Limón">anibal</assigned_to>
          <cc>anibal</cc>
    
    <cc>randy.macleod</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>Don&apos;t know</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>89145</commentid>
    <comment_count>0</comment_count>
      <attachid>4770</attachid>
    <who name="Yi Fan Yu">yf3yu</who>
    <bug_when>2021-02-04 16:46:59 +0000</bug_when>
    <thetext>Created attachment 4770
proposed patch

root cause of  https://bugzilla.yoctoproject.org/show_bug.cgi?id=14170

to reproduce this kind of issue:
make a ptest-run script to output a lot of data
ex: echo {1..1000000}\\n

echo will actually crash if you run it with ptest-runner

i think it is because in the source code of ptest-runner,
the parent process is reading from a non-blocking pipe and writing to a blocking stdout in  a loop. pipe might be full if parent is blocked.

attached is a proposed solution.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>89216</commentid>
    <comment_count>1</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2021-02-11 15:37:40 +0000</bug_when>
    <thetext>Put the reader in a separate thread.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>89688</commentid>
    <comment_count>2</comment_count>
    <who name="Aníbal Limón">anibal</who>
    <bug_when>2021-03-23 02:18:10 +0000</bug_when>
    <thetext>Patches sent to ML and dev branch,

https://github.com/alimon/ptest-runner2/tree/ptest_fixes</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>89845</commentid>
    <comment_count>3</comment_count>
    <who name="Aníbal Limón">anibal</who>
    <bug_when>2021-04-01 14:45:52 +0000</bug_when>
    <thetext>Patches in the ptest-runner,

http://git.yoctoproject.org/cgit/cgit.cgi/ptest-runner2/commit/?id=acbba90532053437ec7f251eaf1c02fcdaf4288e
http://git.yoctoproject.org/cgit/cgit.cgi/ptest-runner2/commit/?id=cce0edb4282ee081d043030bfdf29f3e4052f86c

Recipe bump to 2.4.1 in the ML.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>89880</commentid>
    <comment_count>4</comment_count>
    <who name="Aníbal Limón">anibal</who>
    <bug_when>2021-04-07 14:20:03 +0000</bug_when>
    <thetext>Merge at,

https://git.openembedded.org/openembedded-core/commit/?id=e3fd8f17dfb41173dbe037c25087a69f90b1346f</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>4770</attachid>
            <date>2021-02-04 16:46:59 +0000</date>
            <delta_ts>2021-02-04 16:46:59 +0000</delta_ts>
            <desc>proposed patch</desc>
            <filename>0001-util.c-remove-the-usage-of-pipe-for-parent-child-com.patch</filename>
            <type>text/plain</type>
            <size>4808</size>
            <attacher name="Yi Fan Yu">yf3yu</attacher>
            
              <data encoding="base64">RnJvbSA2NmU3MzhjMTlkYWJjNDhlOGExODE4NzBiNWE4YzUwOTZmOGUyMTA3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBZaSBGYW4gWXUgPHlpZmFuLnl1QHdpbmRyaXZlci5jb20+CkRh
dGU6IFdlZCwgMyBGZWIgMjAyMSAxMjoyMToxMiAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIHV0aWwu
YzogcmVtb3ZlIHRoZSB1c2FnZSBvZiBwaXBlIGZvciBwYXJlbnQvY2hpbGQKIGNvbW11bmljYXRp
b24KCklmIHRoZSBvdXRwdXQgb2YgdGhlIHRlc3Rpbmcgc2NyaXB0IGlzIHZlcnkgbGFyZ2UsCnRo
ZSBmd3JpdGUgY2FsbGVkIGJ5IHRoZSBwYXJlbnQgaW4Kd2FpdF9jaGlsZCB3b3VsZCBzdGFydCBi
bG9ja2luZy4gVGhhdCB3b3VsZCBzbG93IGRvd24KdGhlIHBhcmVudCBzcGVlZCBpbiBjbGVhcmlu
ZyB0aGUgcGlwZSBidWZmZXIuCgpUaGlzIGlzIGFuIGlzc3VlIGJlY2F1c2UgdGhlIHBpcGUgaXMg
Tm9uLUJsb2NraW5nLgpzbyB0aGUgY2hpbGQoZXg6IGEgYmFzaCBzY3JpcHQpCndobyB3YXMgZGVz
aWduZWQgdG8gb3V0cHV0IHRvIHdoYXQgaGUgdGhpbmtzIGlzIGEKaXMgc3Rkb3V0LCBtaWdodCBl
cnJvciBvdXQgZHVlIHRvIEVBR0FJTiAocGlwZSBmdWxsKS4KClRoZSBwcm9wb3NlZCBmaXggaXMg
dG8gcmVtb3ZlIHBpcGVzIGFuZCBqdXN0IGxldCB0aGUgY2hpbGQKd3JpdGUgZGlyZWN0bHkgdG8g
c3Rkb3V0IChzYW1lIGhpcyBwYXJlbnQpCgpUaGlzIHdvdWxkIG1lYW4gdGhhdCB0aGUgcGFyZW50
IG5vIGxvbmdlciBjb250cm9sIHRoZSBvdXRwdXQKb2YgdGhlIGNoaWxkLgoKU2lnbmVkLW9mZi1i
eTogWWkgRmFuIFl1IDx5aWZhbi55dUB3aW5kcml2ZXIuY29tPgotLS0KIHV0aWxzLmMgfCA1MyAr
KysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogMSBm
aWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgNDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0
IGEvdXRpbHMuYyBiL3V0aWxzLmMKaW5kZXggYTRlMTkwZS4uNWQ2MmNlZCAxMDA2NDQKLS0tIGEv
dXRpbHMuYworKysgYi91dGlscy5jCkBAIC0yNzQsMTIgKzI3NCwxNCBAQCBydW5fY2hpbGQoY2hh
ciAqcnVuX3B0ZXN0LCBpbnQgZmRfc3Rkb3V0LCBpbnQgZmRfc3RkZXJyKQogCWFyZ3ZbMF0gPSBy
dW5fcHRlc3Q7CiAJYXJndlsxXSA9IE5VTEw7CiAKKwkvKiBzaW5jZSBpdCBpc24ndCB1c2UgYnkg
dGhlIGNoaWxkLCBjbG9zZShmZF9zdGRlcnIpID8gKi8KKwljbG9zZShmZF9zdGRlcnIpOworCiAJ
ZHVwMihmZF9zdGRvdXQsIFNURE9VVF9GSUxFTk8pOwogCS8vIFhYWDogUmVkaXJlY3Qgc3RkZXJy
IHRvIHN0ZG91dCB0byBhdm9pZCBidWZmZXIgb3JkZXJpbmcgcHJvYmxlbXMuCiAJZHVwMihmZF9z
dGRvdXQsIFNUREVSUl9GSUxFTk8pOwogCi0JLyogc2luY2UgaXQgaXNuJ3QgdXNlIGJ5IHRoZSBj
aGlsZCwgY2xvc2UoZmRfc3RkZXJyKSA/ICovCi0JY2xvc2UoZmRfc3RkZXJyKTsgLyogdHJ5IHVz
aW5nIHRvIHNlZSBpZiB0aGlzIGZpeGVzIGJhc2ggcnVuLXJlYWQuIHJ3bSB0b2RvICovCisKIAlj
bG9zZV9mZHMoKTsKIAogCWV4ZWN2KHJ1bl9wdGVzdCwgYXJndik7CkBAIC0yOTAsMjAgKzI5Miwx
MyBAQCBydW5fY2hpbGQoY2hhciAqcnVuX3B0ZXN0LCBpbnQgZmRfc3Rkb3V0LCBpbnQgZmRfc3Rk
ZXJyKQogc3RhdGljIGlubGluZSBpbnQKIHdhaXRfY2hpbGQocGlkX3QgcGlkLCBpbnQgdGltZW91
dCwgaW50ICpmZHMsIEZJTEUgKipmcHMsIGludCAqdGltZW91dGVkKQogewotCXN0cnVjdCBwb2xs
ZmQgcGZkc1syXTsKIAlzdHJ1Y3QgdGltZXNwZWMgc2VudGluZWw7CiAJY2xvY2tpZF90IGNsb2Nr
ID0gQ0xPQ0tfTU9OT1RPTklDOwogCWludCBsb29waW5nID0gMTsKLQlpbnQgcjsKIAogCWludCBz
dGF0dXMgPSAtMTsKIAlpbnQgd2FpdGZsYWdzOwogCi0JcGZkc1swXS5mZCA9IGZkc1swXTsKLQlw
ZmRzWzBdLmV2ZW50cyA9IFBPTExJTjsKLQlwZmRzWzFdLmZkID0gZmRzWzFdOwotCXBmZHNbMV0u
ZXZlbnRzID0gUE9MTElOOwotCiAJaWYgKGNsb2NrX2dldHRpbWUoY2xvY2ssICZzZW50aW5lbCkg
PT0gLTEpIHsKIAkJY2xvY2sgPSBDTE9DS19SRUFMVElNRTsKIAkJY2xvY2tfZ2V0dGltZShjbG9j
aywgJnNlbnRpbmVsKTsKQEAgLTMyOCwyOSArMzIzLDEwIEBAIHdhaXRfY2hpbGQocGlkX3QgcGlk
LCBpbnQgdGltZW91dCwgaW50ICpmZHMsIEZJTEUgKipmcHMsIGludCAqdGltZW91dGVkKQogCQlp
ZiAod2FpdHBpZChwaWQsICZzdGF0dXMsIHdhaXRmbGFncykgPT0gcGlkKQogCQkJbG9vcGluZyA9
IDA7CiAKLQkJciA9IHBvbGwocGZkcywgMiwgV0FJVF9DSElMRF9QT0xMX1RJTUVPVVRfTVMpOwot
CQlpZiAociA+IDApIHsKLQkJCWNoYXIgYnVmW1dBSVRfQ0hJTERfQlVGX01BWF9TSVpFXTsKLQkJ
CXNzaXplX3QgbjsKLQotCQkJaWYgKHBmZHNbMF0ucmV2ZW50cyAhPSAwKSB7Ci0JCQkJd2hpbGUg
KChuID0gcmVhZChmZHNbMF0sIGJ1ZiwgV0FJVF9DSElMRF9CVUZfTUFYX1NJWkUpKSA+IDApCi0J
CQkJCWZ3cml0ZShidWYsIChzaXplX3QpbiwgMSwgZnBzWzBdKTsKLQkJCX0KLQotCQkJaWYgKHBm
ZHNbMV0ucmV2ZW50cyAhPSAwKSB7Ci0JCQkJd2hpbGUgKChuID0gcmVhZChmZHNbMV0sIGJ1Ziwg
V0FJVF9DSElMRF9CVUZfTUFYX1NJWkUpKSA+IDApIHsKLQkJCQkJZmZsdXNoKGZwc1swXSk7Ci0J
CQkJCWZ3cml0ZShidWYsIChzaXplX3QpbiwgMSwgZnBzWzFdKTsKLQkJCQkJZmZsdXNoKGZwc1sx
XSk7Ci0JCQkJfQotCQkJfQotCi0JCQljbG9ja19nZXR0aW1lKGNsb2NrLCAmc2VudGluZWwpOwot
CQl9Ci0JfQorICAgICAgICB9CiAKIAlmZmx1c2goZnBzWzBdKTsKKwogCXJldHVybiBzdGF0dXM7
CiB9CiAKQEAgLTQxMiw4ICszODgsNiBAQCBydW5fcHRlc3RzKHN0cnVjdCBwdGVzdF9saXN0ICpo
ZWFkLCBjb25zdCBzdHJ1Y3QgcHRlc3Rfb3B0aW9ucyBvcHRzLAogCWNoYXIgc3RpbWVbR0VUX1NU
SU1FX0JVRl9TSVpFXTsKIAogCXBpZF90IGNoaWxkOwotCWludCBwaXBlZmRfc3Rkb3V0WzJdOwot
CWludCBwaXBlZmRfc3RkZXJyWzJdOwogCWludCB0aW1lb3V0ZWQ7CiAJdGltZV90IHN0dGltZSwg
ZW50aW1lOwogCXRpbWVfdCBkdXJhdGlvbjsKQEAgLTQyOCwxNCArNDAyLDYgQEAgcnVuX3B0ZXN0
cyhzdHJ1Y3QgcHRlc3RfbGlzdCAqaGVhZCwgY29uc3Qgc3RydWN0IHB0ZXN0X29wdGlvbnMgb3B0
cywKIAogCWRvCiAJewotCQlpZiAoKHJjID0gcGlwZTIocGlwZWZkX3N0ZG91dCwgT19OT05CTE9D
SykpID09IC0xKSAKLQkJCWJyZWFrOwotCi0JCWlmICgocmMgPSBwaXBlMihwaXBlZmRfc3RkZXJy
LCBPX05PTkJMT0NLKSkgPT0gLTEpIHsKLQkJCWNsb3NlKHBpcGVmZF9zdGRvdXRbMF0pOwotCQkJ
Y2xvc2UocGlwZWZkX3N0ZG91dFsxXSk7Ci0JCQlicmVhazsKLQkJfQogCQlmcHJpbnRmKGZwLCAi
U1RBUlQ6ICVzXG4iLCBwcm9nbmFtZSk7CiAJCWlmIChpc2F0dHkoMCkgJiYgaW9jdGwoMCwgVElP
Q05PVFRZKSA9PSAtMSkgewogCQkJZnByaW50ZihmcCwgIkVSUk9SOiBVbmFibGUgdG8gZGV0YWNo
IGZyb20gY29udHJvbGxpbmcgdHR5LCAlc1xuIiwgc3RyZXJyb3IoZXJybm8pKTsKQEAgLTQ3NCwx
MSArNDQwLDEwIEBAIHJ1bl9wdGVzdHMoc3RydWN0IHB0ZXN0X2xpc3QgKmhlYWQsIGNvbnN0IHN0
cnVjdCBwdGVzdF9vcHRpb25zIG9wdHMsCiAJCQkJCWZwcmludGYoZnAsICJFUlJPUjogVW5hYmxl
IHRvIGF0dGFjaCB0byBjb250cm9sbGluZyB0dHksICVzXG4iLCBzdHJlcnJvcihlcnJubykpOwog
CQkJCX0KIAotCQkJCXJ1bl9jaGlsZChwLT5ydW5fcHRlc3QsIHBpcGVmZF9zdGRvdXRbMV0sIHBp
cGVmZF9zdGRlcnJbMV0pOworCQkJCXJ1bl9jaGlsZChwLT5ydW5fcHRlc3QsIFNURE9VVF9GSUxF
Tk8sIFNUREVSUl9GSUxFTk8pOwogCiAJCQl9IGVsc2UgewogCQkJCWludCBzdGF0dXM7Ci0JCQkJ
aW50IGZkc1syXTsgZmRzWzBdID0gcGlwZWZkX3N0ZG91dFswXTsgZmRzWzFdID0gcGlwZWZkX3N0
ZGVyclswXTsKIAkJCQlGSUxFICpmcHNbMl07IGZwc1swXSA9IGZwOyBmcHNbMV0gPSBmcF9zdGRl
cnI7CiAKIAkJCQlpZiAoc2V0cGdpZChjaGlsZCwgcGdpZCkgPT0gLTEpIHsKQEAgLTQ4OSw3ICs0
NTQsNyBAQCBydW5fcHRlc3RzKHN0cnVjdCBwdGVzdF9saXN0ICpoZWFkLCBjb25zdCBzdHJ1Y3Qg
cHRlc3Rfb3B0aW9ucyBvcHRzLAogCQkJCWZwcmludGYoZnAsICIlc1xuIiwgZ2V0X3N0aW1lKHN0
aW1lLCBHRVRfU1RJTUVfQlVGX1NJWkUsIHN0dGltZSkpOwogCQkJCWZwcmludGYoZnAsICJCRUdJ
TjogJXNcbiIsIHB0ZXN0X2Rpcik7CiAKLQkJCQlzdGF0dXMgPSB3YWl0X2NoaWxkKGNoaWxkLCBv
cHRzLnRpbWVvdXQsIGZkcywgZnBzLCAmdGltZW91dGVkKTsKKwkJCQlzdGF0dXMgPSB3YWl0X2No
aWxkKGNoaWxkLCBvcHRzLnRpbWVvdXQsIE5VTEwsIGZwcywgJnRpbWVvdXRlZCk7CiAJCQkJZW50
aW1lID0gdGltZShOVUxMKTsKIAkJCQlkdXJhdGlvbiA9IGVudGltZSAtIHN0dGltZTsKIApAQCAt
NTEwLDggKzQ3NSw2IEBAIHJ1bl9wdGVzdHMoc3RydWN0IHB0ZXN0X2xpc3QgKmhlYWQsIGNvbnN0
IHN0cnVjdCBwdGVzdF9vcHRpb25zIG9wdHMsCiAJCVBURVNUX0xJU1RfSVRFUkFURV9FTkQKIAkJ
ZnByaW50ZihmcCwgIlNUT1A6ICVzXG4iLCBwcm9nbmFtZSk7CiAKLQkJY2xvc2UocGlwZWZkX3N0
ZG91dFswXSk7IGNsb3NlKHBpcGVmZF9zdGRvdXRbMV0pOwotCQljbG9zZShwaXBlZmRfc3RkZXJy
WzBdKTsgY2xvc2UocGlwZWZkX3N0ZGVyclsxXSk7CiAJfSB3aGlsZSAoMCk7CiAKIAlpZiAocmMg
PT0gLTEpIAotLSAKMi4yNS4xCgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>