14450 2021-06-24 16:20:10 +0000 update-rc.d: Errors in enabling/disabling startup links 2021-07-15 00:48:18 +0000 1 1 11 Runtime General Runtime General Runtime unspecified All Multiple RESOLVED FIXED https://git.yoctoproject.org/cgit/cgit.cgi/update-rc.d/tree/update-rc.d#n117 Medium+ minor 3.4 M3 1 tolvupostur tolvupostur randy.macleod --- --- No (bug/feature does not impact docs) oldest_to_newest 90761 0 4809 tolvupostur 2021-06-24 16:20:10 +0000 Created attachment 4809 Patch that should fix this. The shell script /usr/sbin/update-rc.d has a couple of issues in line 117. newnn=$[100-$oldnn] https://git.yoctoproject.org/cgit/cgit.cgi/update-rc.d/tree/update-rc.d#n117 1) $[] is only known by bash. Running 'update-rc.d script enable' with a POSIX shell creates the links 'S$[100-12]script' instead of 'S88script'. - Running 'update-rc.d script enable' a second time encounters more issues, since the $oldnn just grabs the second and third letter of the symlinks, which are now '$['. - This is an issue since many embedded boards only have busybox shell. 2) $oldnn is parsed as a number, but a leading 0 means octal so that 08 and 09 fail. Running 'update-rc.d weston disable' does not work even when using bash, because S09weston results in $[100-09], which gives errors in any shell. Both issues could be handled by using $(()), and stripping the leading 0. $((100-${oldnn#0})) # oldnn is guaranteed to be 2 chars Shellcheck also reports 50+ other issues, but the others don't seem to break anything. 90820 1 randy.macleod 2021-07-01 14:37:05 +0000 Einar, Are you able to send the patch to the email list: openembedded-core@lists.openembedded.org https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded I am usually available to help but I'm on vacation for a week. - Randy 90839 2 tolvupostur 2021-07-02 13:37:51 +0000 Done. https://lists.openembedded.org/g/openembedded-core/message/153466 90870 3 tolvupostur 2021-07-07 08:35:50 +0000 Merged... https://git.yoctoproject.org/cgit/cgit.cgi/update-rc.d/commit/?id=8636cf478d426b568c1be11dbd9346f67e03adac Still needs to be tagged and bumped into poky 90914 4 tolvupostur 2021-07-13 11:30:52 +0000 Bumped in poky master https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=404463335113da2a6d0674e959109e069f9bb576 90920 5 randy.macleod 2021-07-15 00:48:18 +0000 Thanks Einar! 4809 2021-06-24 16:20:10 +0000 2021-06-24 16:20:10 +0000 Patch that should fix this. 0001-update-rc.d-Fix-enable-disable-command.patch application/octet-stream 1188 tolvupostur RnJvbSA1YmU0YTFiNDI3Y2QyYWU1ZjkxODNmODg4Y2Q5NTQ2NWY4ZDQ0MDZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFaW5hciBHdW5uYXJzc29uIDx0b2x2dXBvc3R1ckBnbWFpbC5j b20+CkRhdGU6IFRodSwgMjQgSnVuIDIwMjEgMTg6MDQ6MzkgKzAyMDAKU3ViamVjdDogW1BBVENI XSB1cGRhdGUtcmMuZDogRml4IGVuYWJsZS9kaXNhYmxlIGNvbW1hbmQKCiRbXSBpcyBhIGJhc2hp c20gYW5kIGRvZXMgbm90IHdvcmsgb24gUE9TSVggc2hlbGxzCgplbmFibGUvZGlzYWJsZSBvbiBs aW5rcyBudW1iZXJlZCAwOCBhbmQgMDkgZ2l2ZXMgdGhlIGVycm9yOgonYmFzaDogMTAwLTA4OiB2 YWx1ZSB0b28gZ3JlYXQgZm9yIGJhc2UgKGVycm9yIHRva2VuIGlzICIwOCIpJwotLS0KIHVwZGF0 ZS1yYy5kIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9u KC0pCgpkaWZmIC0tZ2l0IGEvdXBkYXRlLXJjLmQgYi91cGRhdGUtcmMuZAppbmRleCBjOTM1NWQ3 Li4yNGFjNzUyIDEwMDY0NAotLS0gYS91cGRhdGUtcmMuZAorKysgYi91cGRhdGUtcmMuZApAQCAt MTE0LDcgKzExNCw3IEBAIHJlbmFtZWxpbmsoKQogICAgICAgICAjIG9yIHN0b3AgbGluayB0byBz dGFydCBsaW5rIHdpdGggYSBzZXF1ZW5jZSBudW1iZXIgZXF1YWwgdG8gdGhlIGRpZmZlcmVuY2Ug b2YgMTAwIG1pbnVzIHRoZSBvcmlnaW5hbCBzZXF1ZW5jZSBudW1iZXIuCiAJaWYgbHMgJHtldGNk fSR7bGV2fS5kLyR7b2xkc3RhcnRzdG9wfSoke2JufSA+L2Rldi9udWxsIDI+JjE7IHRoZW4KIAkJ b2xkbm49YGJhc2VuYW1lICR7ZXRjZH0ke2xldn0uZC8ke29sZHN0YXJ0c3RvcH0qJHtibn18Y3V0 IC1jMi0zYAotCQluZXdubj0kWzEwMC0kb2xkbm5dCisJCW5ld25uPSQoKDEwMC0ke29sZG5uIzB9 KSkKIAkJWyAkdmVyYm9zZSAtZXEgMSBdICYmIGVjaG8gInJlbmFtZSAke2V0Y2R9JHtsZXZ9LmQv JHtvbGRzdGFydHN0b3B9JHtvbGRubn0ke2JufSAtPiAke2V0Y2R9JHtsZXZ9LmQvJHtuZXdzdGFy dHN0b3B9JHtuZXdubn0ke2JufSIKIAkJaWYgWyAkbm90cmVhbGx5IC1lcSAwIF07dGhlbgogCQkJ bXYgJHtldGNkfSR7bGV2fS5kLyR7b2xkc3RhcnRzdG9wfSR7b2xkbm59JHtibn0gJHtldGNkfSR7 bGV2fS5kLyR7bmV3c3RhcnRzdG9wfSR7bmV3bm59JHtibn0KLS0gCjIuMTcuMQoK