<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>14529</bug_id>
          
          <creation_ts>2021-08-26 14:57:31 +0000</creation_ts>
          <short_desc>devtool/recipetool does not use SPDX-License-Identifier headers to determine license(s)</short_desc>
          <delta_ts>2025-02-14 16:48:10 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>devtools / tool chain</component>
          <version>3.4</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>4.0 M3</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tim Orling">tim.orling</reporter>
          <assigned_to name="Saul Wold">saul.wold</assigned_to>
          <cc>JPEWhacker</cc>
    
    <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
    
    <cc>randy.macleod</cc>
    
    <cc>sgw</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>Don&apos;t know</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>91284</commentid>
    <comment_count>0</comment_count>
    <who name="Tim Orling">tim.orling</who>
    <bug_when>2021-08-26 14:57:31 +0000</bug_when>
    <thetext>When creating a new recipe with:
$ devtool add python3-pyinstaller-hooks-contrib https://files.pythonhosted.org/packages/a6/81/0a27c73014cbc9cc5623fd32f570d3daff7ad88999ecb4317cc6c6fd9db7/pyinstaller-hooks-contrib-2021.3.tar.gz

the resulting recipe has:
# The following license files were not able to be identified and are
# represented as &quot;Unknown&quot; below, you will need to check them yourself:
#   LICENSE
#   LICENSE.APL.txt
#   LICENSE.GPL.txt
LICENSE = &quot;Unknown&quot;
LIC_FILES_CHKSUM = &quot;file://LICENSE;md5=822bee463f4e00ac4478593130e95ccb \
                    file://LICENSE.APL.txt;md5=9f445e374fa8f653a9654c10468ffc36 \
                    file://LICENSE.GPL.txt;md5=757586685e1b7938627f468f1b05b2dc&quot;

When clearly it could have determined the Apache-2.0 and GPL-2.0-or-later, as those are called out in two of the license files:

LICENSE.APL.txt excerpt:
# ------------------------------------------------------------------
# Copyright (c) 2021 PyInstaller Development Team.
#
# This file is distributed under the terms of the Apache License 2.0
#
# The full license is available in LICENSE.APL.txt, distributed with
# this software.
#
# SPDX-License-Identifier: Apache-2.0
# ------------------------------------------------------------------
(followed by the Apache 2.0 text)

LICENSE.GPL.txt excerpt:
# ------------------------------------------------------------------
# Copyright (c) 2021 PyInstaller Development Team.
#
# This file is distributed under the terms of the GNU General Public
# License (version 2.0 or later).
#
# The full license is available in LICENSE.GPL.txt, distributed with
# this software.
#
# SPDX-License-Identifier: GPL-2.0-or-later
# ------------------------------------------------------------------
(followed by the GPL-2.0-or-later text)

The expected behavior would have been to set:
LICENSE = &quot;Apache-2.0 &amp; GPL-2.0-or-later &amp; UNKNOWN&quot;

(since the third file does not have license text in it but rather describes the other two files.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>92833</commentid>
    <comment_count>1</comment_count>
    <who name="Saul Wold">saul.wold</who>
    <bug_when>2022-03-22 16:52:36 +0000</bug_when>
    <thetext>https://git.yoctoproject.org/poky/commit/?id=75f9785a2b28eddd1f6ca0c8a6c6507dd97df409</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>100955</commentid>
    <comment_count>2</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2025-02-14 16:46:20 +0000</bug_when>
    <thetext>bulk change to add Saul&apos;s non-WR address.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>101024</commentid>
    <comment_count>3</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2025-02-14 16:48:10 +0000</bug_when>
    <thetext>Bulk change: Remove Saul&apos;s old WR address.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>