<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>14896</bug_id>
          
          <creation_ts>2022-08-17 22:27:15 +0000</creation_ts>
          <short_desc>Current autobuilder code incompatible with buildbot 3.5.0</short_desc>
          <delta_ts>2023-06-08 16:12:27 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>5</classification_id>
          <classification>Infrastructure</classification>
          <product>AutoBuilder</product>
          <component>autobuilder</component>
          <version>unspecified</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>4.3 M1</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jate Sujjavanich">jatedev</reporter>
          <assigned_to name="Richard Purdie">richard.purdie</assigned_to>
          <cc>infras.ab.watcher</cc>
    
    <cc>Infras.watcher</cc>
    
    <cc>mhalstead</cc>
    
    <cc>pidge</cc>
    
    <cc>randy.macleod</cc>
    
    <cc>tarxf</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>Don&apos;t know</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>93834</commentid>
    <comment_count>0</comment_count>
    <who name="Jate Sujjavanich">jatedev</who>
    <bug_when>2022-08-17 22:27:15 +0000</bug_when>
    <thetext>I created a yocto-autobuilder2 instance under and a pyenv with python 3.6.11. I used the instructions in the README.Guide. This installs buildbot 3.5.0.

When starting an a-quick build, for example, the subbuilders run &quot;Check run-config steps to use&quot; which is a call to run-config. However, no further build steps are created.

Dropping the buildbot version to 2.8.4 (matching the autobuilder.yocto.io instance) allows run-config to work, however.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>94037</commentid>
    <comment_count>1</comment_count>
    <who name="Benjamin Esquivel">tarxf</who>
    <bug_when>2022-09-20 17:28:35 +0000</bug_when>
    <thetext>Hi Jate, have you inspected your yocto-controller/twistd.log when the process gets stuck?

are there any other signs of obvious errors that you can share?

I just installed the autobuilder controller following the instructions and I did run into some bumps which I&apos;ll be sending patches for soon but I wanted to check if yours is a different error.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>94038</commentid>
    <comment_count>2</comment_count>
    <who name="Jate Sujjavanich">jatedev</who>
    <bug_when>2022-09-21 00:36:43 +0000</bug_when>
    <thetext>In the controller twistd.log, the instance on 3.5.0 jumps straight to the next step from run-config&apos;s generation of json to Clobber build dir.

I added some debug code to the functions in runconfig.py&apos;s RunConfigCheckSteps. In 2.8.4, I see calls to evaluateCommand:

2022-09-12 15:32:55-0400 [-] DEBUG: RunConfigCheckSteps.run()
2022-09-12 15:32:55-0400 [-] DEBUG: RunConfigCheckSteps.start()
022-09-12 15:32:55-0400 [-] ShellCommand.startCommand(cmd=&lt;RemoteShellCommand &apos;
[&apos;/home/pokybuild3/yocto-worker/syntux-dunfell/yocto-autobuilder-helper/scripts/
run-config&apos; ... --json-outputfile ...
...
2022-09-12 15:32:55-0400 [-] closing log &lt;buildbot.process.buildstep.SyncLogFile
Wrapper object at 0x7f1ba8fe3ba8&gt;
2022-09-12 15:32:55-0400 [-] closing log &lt;buildbot.process.buildstep.SyncLogFile
Wrapper object at 0x7f1ba914b0b8&gt;
2022-09-12 15:32:55-0400 [-] DEBUG: evaluateCommand
2022-09-12 15:32:56-0400 [-] releaseLocks(RunConfigCheckSteps(posttrigger=False)): []
2022-09-12 15:32:56-0400 [-]  step &apos;Check run-config steps to use&apos; complete: success (None)
2022-09-12 15:32:56-0400 [-] ShellCommand.startCommand(cmd=&lt;RemoteShellCommand &apos;[&apos;/home/pokybuild3/yocto-worker/syntux-dunfell/yocto-autobuilder-helper/scripts/run-config&apos; ... --phase 1


But with 3.5.0:

2022-09-20 20:05:50-0400 [-]  step &apos;Set build branch&apos; complete: success (None)
2022-09-20 20:05:50-0400 [-] &lt;RemoteShellCommand &apos;[&apos;/home/pokybuild3/yocto-worke
r/qemux86-64/yocto-autobuilder-helper/scripts/run-config&apos;, --json-outputfile
...
2022-09-20 20:05:50-0400 [-] releaseLocks(RunConfigCheckSteps(posttrigger=False)): []
2022-09-20 20:05:50-0400 [-]  step &apos;Check run-config steps to use&apos; complete: success (None)
2022-09-20 20:05:50-0400 [-] &lt;RemoteShellCommand &apos;[&apos;/home/pokybuild3/yocto-autobuilder-helper/janitor/clobberdir&apos;, &apos;/home/pokybuild3/yocto-worker/qemux86-64/&apos;]&apos;&gt;: RemoteCommand.run [13]
2022-09-20 20:05:50-0400 [-] command &apos;[&apos;/home/pokybuild3/yocto-autobuilder-helper/janitor/clobberdir&apos;, &apos;/home/pokybuild3/yocto-worker/qemux86-64/&apos;]&apos; in dir &apos;build&apos;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>94046</commentid>
    <comment_count>3</comment_count>
    <who name="Benjamin Esquivel">tarxf</who>
    <bug_when>2022-09-22 01:46:15 +0000</bug_when>
    <thetext>ok, I&apos;ll take a look at this and see if the 3.6.0 behaves the same as 3.5.0 you mention.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>94476</commentid>
    <comment_count>4</comment_count>
    <who name="Jate Sujjavanich">jatedev</who>
    <bug_when>2022-12-07 00:39:19 +0000</bug_when>
    <thetext>While using the yocto-autobuilder2 code, I became curious about exactly what version stopped working. By bisecting the versions, I learned it was buildbot 3.0.0. That&apos;s when I found the release notes about the deprecation of old-style build steps. E.g., ShellCommand.

In 2.9.x, buildbot&apos;s developers added deprecation warnings to begin the process of removing old-style steps. They added *NewStyle aliases to allow gradual migration to the new API.
In 3.0.x, they formally removed old-style steps.
In 3.1.x, they removed the *NewStyle aliases. Before moving to this version, the *NewStyle aliases should be converted to standard classes.

I some patches which go through this migration process.

I&apos;ve done simple testing up through 3.2.x. There will probably have to be a structured test plan to cover autobuilder2 through the latest version.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>95669</commentid>
    <comment_count>5</comment_count>
    <who name="Richard Purdie">richard.purdie</who>
    <bug_when>2023-06-08 16:12:27 +0000</bug_when>
    <thetext>We&apos;ve updated to new versions of buildbot now.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>