15027 2023-02-02 08:33:12 +0000 images_types: missing vname var init in multiubi_mkfs() 2023-03-16 14:36:02 +0000 1 1 7 Build System, Metadata & Runtime OE-Core oe-core other 4.1.2 x86 Multiple RESOLVED FIXED Medium+ normal 4.2 M4 1 romuald.jeanne alexandre.belloni alexandre.belloni randy.macleod romuald.jeanne --- Regression (Used to work) No (bug/feature does not impact docs) oldest_to_newest 94845 0 4925 romuald.jeanne 2023-02-02 08:33:12 +0000 Created attachment 4925 patch proposal Since introduction in openembedded-core master branch of commit images_types: isolate the write of UBI configuration SHA1 601294b35c83faa134e26844c65db59b42d5052f There is a missing init in multiubi_mkfs() function for 'vname' var. Proposal to keep the vname var init as previously done in multiubi_mkfs() function and it as parameter for wrtie_ubi_config() function. Patch attached for 'image-types.bbclass' file. 95031 1 alexandre.belloni 2023-02-28 22:33:55 +0000 I'm sorry for the delay, I've sent this to the autobuilders but the selftests are failing: https://autobuilder.yoctoproject.org/typhoon/#builders/80/builds/4814/steps/14/logs/stdio https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/4897/steps/14/logs/stdio https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/4862/steps/14/logs/stdio 2023-02-28 21:55:23,095 - oe-selftest - INFO - ====================================================================== 2023-02-28 21:55:23,095 - oe-selftest - INFO - FAIL: imagefeatures.ImageFeatures.test_image_fstypes (subunit.RemotedTestCase) 2023-02-28 21:55:23,096 - oe-selftest - INFO - ---------------------------------------------------------------------- 2023-02-28 21:55:23,096 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last): File "/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/lib/oeqa/selftest/cases/imagefeatures.py", line 224, in test_image_fstypes self.assertTrue(os.path.exists(image_path), File "/usr/lib64/python3.11/unittest/case.py", line 715, in assertTrue raise self.failureException(msg) AssertionError: False is not true : ubi image /home/pokybuild/yocto-worker/oe-selftest-fedora/build/build-st-733784/tmp/deploy/images/qemux86-64/core-image-minimal-qemux86-64.ubi doesn't exist I confirm there was no ubi image generated. Can you fix the patch? To ensure a timely reply, the proper way to contribute is documented here: https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded 95059 2 romuald.jeanne 2023-03-03 08:47:26 +0000 Ok, so I've tried to set-up everything to send the patch as expected. I'm really used with git send-email, but it returns OK. Here's the log: $ git send-email --to=openembedded-core@lists.openembedded.org --confirm=always -M -1 /tmp/ZcHh2UuARB/0001-image_types-fix-vname-var-init-in-multiubi_mkfs-func.patch (mbox) Adding cc: Romuald JEANNE <romuald.jeanne@st.com> from line 'From: Romuald JEANNE <romuald.jeanne@st.com>' (body) Adding cc: Romuald JEANNE <romuald.jeanne@st.com> from line 'Signed-off-by: Romuald JEANNE <romuald.jeanne@st.com>' From: romuald.jeanne@st.com To: openembedded-core@lists.openembedded.org Cc: Romuald JEANNE <romuald.jeanne@st.com> Subject: [PATCH] image_types: fix vname var init in multiubi_mkfs() function Date: Fri, 3 Mar 2023 09:43:28 +0100 Message-Id: <20230303084328.14758-1-romuald.jeanne@st.com> X-Mailer: git-send-email 2.17.1 Send this email? ([y]es|[n]o|[q]uit|[a]ll): y OK. Log says: Sendmail: /usr/bin/msmtp -i openembedded-core@lists.openembedded.org romuald.jeanne@st.com From: romuald.jeanne@st.com To: openembedded-core@lists.openembedded.org Cc: Romuald JEANNE <romuald.jeanne@st.com> Subject: [PATCH] image_types: fix vname var init in multiubi_mkfs() function Date: Fri, 3 Mar 2023 09:43:28 +0100 Message-Id: <20230303084328.14758-1-romuald.jeanne@st.com> X-Mailer: git-send-email 2.17.1 Result: OK 95100 3 alexandre.belloni 2023-03-09 15:55:39 +0000 Patch on the list, under test. 95146 4 alexandre.belloni 2023-03-16 14:36:02 +0000 8b5e1cce35e1 ("image_types: fix vname var init in multiubi_mkfs() function") 4925 2023-02-02 08:33:12 +0000 2023-02-02 08:33:12 +0000 patch proposal 0001-image_type-fix-vname-var-init-in-multiubi_mkfs-funct.patch text/plain 1340 romuald.jeanne RnJvbSA5ZjMwMDY3YmFjY2FhNTExZjhhOTJjMDBmYzA5MDAwYjhmMTU4NGI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb211YWxkIEpFQU5ORSA8cm9tdWFsZC5qZWFubmVAc3QuY29t PgpEYXRlOiBUaHUsIDIgRmViIDIwMjMgMDk6MjQ6MDkgKzAxMDAKU3ViamVjdDogW1BBVENIXSBp bWFnZV90eXBlOiBmaXggdm5hbWUgdmFyIGluaXQgaW4gbXVsdGl1YmlfbWtmcygpIGZ1bmN0aW9u CgpTaWduZWQtb2ZmLWJ5OiBSb211YWxkIEpFQU5ORSA8cm9tdWFsZC5qZWFubmVAc3QuY29tPgot LS0KIG1ldGEvY2xhc3Nlcy1yZWNpcGUvaW1hZ2VfdHlwZXMuYmJjbGFzcyB8IDEzICsrKysrKyst LS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvbWV0YS9jbGFzc2VzLXJlY2lwZS9pbWFnZV90eXBlcy5iYmNsYXNzIGIvbWV0 YS9jbGFzc2VzLXJlY2lwZS9pbWFnZV90eXBlcy5iYmNsYXNzCmluZGV4IDc2NGU2YTU1NzQuLjc3 Y2IyMmNmOWMgMTAwNjQ0Ci0tLSBhL21ldGEvY2xhc3Nlcy1yZWNpcGUvaW1hZ2VfdHlwZXMuYmJj bGFzcworKysgYi9tZXRhL2NsYXNzZXMtcmVjaXBlL2ltYWdlX3R5cGVzLmJiY2xhc3MKQEAgLTE1 NywxMSArMTU3LDcgQEAgVUJJX1ZPTFRZUEUgPz0gImR5bmFtaWMiCiBVQklfSU1HVFlQRSA/PSAi dWJpZnMiCiAKIHdyaXRlX3ViaV9jb25maWcoKSB7Ci0JaWYgWyAteiAiJDEiIF07IHRoZW4KLQkJ bG9jYWwgdm5hbWU9IiIKLQllbHNlCi0JCWxvY2FsIHZuYW1lPSJfJDEiCi0JZmkKKwlsb2NhbCB2 bmFtZT0iJDEiCiAKIAljYXQgPDxFT0YgPiB1YmluaXplJHt2bmFtZX0tJHtJTUFHRV9OQU1FfS5j ZmcKIFt1Ymlmc10KQEAgLTE4Myw3ICsxNzksMTIgQEAgbXVsdGl1YmlfbWtmcygpIHsKICAgICAg ICAgICAgIGJiZmF0YWwgIk1LVUJJRlNfQVJHUyBhbmQgVUJJTklaRV9BUkdTIGhhdmUgdG8gYmUg c2V0LCBzZWUgaHR0cDovL3d3dy5saW51eC1tdGQuaW5mcmFkZWFkLm9yZy9mYXEvdWJpZnMuaHRt bCBmb3IgZGV0YWlscyIKICAgICAgICAgZmkKIAotCXdyaXRlX3ViaV9jb25maWcgIiQzIgorCWlm IFsgLXogIiQxIiBdOyB0aGVuCisJCWxvY2FsIHZuYW1lPSIiCisJZWxzZQorCQlsb2NhbCB2bmFt ZT0iXyQzIgorCWZpCisJd3JpdGVfdWJpX2NvbmZpZyAiJHt2bmFtZX0iCiAKIAlpZiBbIC1uICIk dm5hbWUiIF07IHRoZW4KIAkJbWtmcy51YmlmcyAtciAke0lNQUdFX1JPT1RGU30gLW8gJHtJTUdE RVBMT1lESVJ9LyR7SU1BR0VfTkFNRX0ke3ZuYW1lfSR7SU1BR0VfTkFNRV9TVUZGSVh9LnViaWZz ICR7bWt1Ymlmc19hcmdzfQotLSAKMi4xNy4xCgo=