<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>15065</bug_id>
          
          <creation_ts>2023-03-10 10:32:54 +0000</creation_ts>
          <short_desc>image_types: enable multiubi build</short_desc>
          <delta_ts>2023-04-06 14:58:03 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>oe-core other</component>
          <version>4.1.4</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>4.2</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Romuald Jeanne">romuald.jeanne</reporter>
          <assigned_to name="Romuald Jeanne">romuald.jeanne</assigned_to>
          <cc>randy.macleod</cc>
    
    <cc>richard.purdie</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>95108</commentid>
    <comment_count>0</comment_count>
    <who name="Romuald Jeanne">romuald.jeanne</who>
    <bug_when>2023-03-10 10:32:54 +0000</bug_when>
    <thetext>For multiubi build we use to set on machine side the MKUBIFS_ARGS_&lt;label&gt; and UBINIZE_ARGS_&lt;label&gt; vars.
But these vars are not available in &apos;do_image_multiubi&apos; task environment, so the &apos;eval&apos; commands run to set local &apos;mkubifs_args&apos; and &apos;ubinize_args&apos; vars, always init empty vars.
Then &apos;multiubi_mkfs()&apos; calls abort with bbfatal (&quot;MKUBIFS_ARGS and UBINIZE_ARGS have to be set...&quot;).

I suggest to expand all MKUBIFS_ARGS_&lt;label&gt; and UBINIZE_ARGS_&lt;label&gt; vars in
&apos;do_image_multiubi&apos; task to make them usable to init the local &apos;mkubifs_args&apos; and &apos;ubinize_args&apos; vars.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>95144</commentid>
    <comment_count>1</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2023-03-16 14:35:03 +0000</bug_when>
    <thetext>Merged but we could use some tests. Are you interested Romuald?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>95145</commentid>
    <comment_count>2</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2023-03-16 14:35:36 +0000</bug_when>
    <thetext>https://git.openembedded.org/openembedded-core/commit/?id=09d05215cf61981c7bc828cc0ff64c2fd5edc43c</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>95147</commentid>
    <comment_count>3</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2023-03-16 14:36:19 +0000</bug_when>
    <thetext>See previous question</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>95156</commentid>
    <comment_count>4</comment_count>
    <who name="Romuald Jeanne">romuald.jeanne</who>
    <bug_when>2023-03-16 15:25:07 +0000</bug_when>
    <thetext>What do you mean by &quot;use some tests&quot;?
Anyway I&apos;m ok for some tests. Let me know how I can help.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>95158</commentid>
    <comment_count>5</comment_count>
    <who name="Richard Purdie">richard.purdie</who>
    <bug_when>2023-03-16 16:38:19 +0000</bug_when>
    <thetext>If you look at meta/lib/oeqa/selftest/cases/imagefeatures.py for example, test_image_fstypes does briefly test multiubi but only that it basically works, nothing about configuration options. You&apos;d run this with &quot;oe-selftest -r imagefeatures&quot; 

We were hoping we could add some more specific tests for the multiubi image type to ensure the fixes you&apos;ve added don&apos;t regress.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>95166</commentid>
    <comment_count>6</comment_count>
    <who name="Romuald Jeanne">romuald.jeanne</who>
    <bug_when>2023-03-17 14:44:19 +0000</bug_when>
    <thetext>Ok, thanks for the hint.
I&apos;ll check this part and try to write something to propose an update for multiubi test by the end of next week.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>95168</commentid>
    <comment_count>7</comment_count>
    <who name="Romuald Jeanne">romuald.jeanne</who>
    <bug_when>2023-03-20 13:50:37 +0000</bug_when>
    <thetext>I&apos;ve just sent a patch to the mailing list to implement a test on test_image_fstypes.
Please refer to e-mail with subject:
[PATCH] oeqa/selftest/imagefeatures: set a test for mutliubi in test_image_fstypes</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>95310</commentid>
    <comment_count>8</comment_count>
    <who name="Richard Purdie">richard.purdie</who>
    <bug_when>2023-04-06 14:58:03 +0000</bug_when>
    <thetext>https://git.yoctoproject.org/poky/commit/?id=6815f716927477988d2ca2111c74285dcc15c053</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>