15222 2023-10-04 06:36:19 +0000 devtool upgrade ignores git system configuration 2023-10-31 05:58:12 +0000 1 1 7 Build System, Metadata & Runtime OE-Core Scripts and Tools 4.0 x86 Multiple RESOLVED FIXED Medium normal 5.0 1 marcus.flyckt marcus.flyckt randy.macleod ross.burton --- --- No (bug/feature does not impact docs) oldest_to_newest 96608 0 marcus.flyckt 2023-10-04 06:36:19 +0000 In my yocto docker container I have my git configuration at /etc/gitconfig (i.e `git config --system`). But `devtool upgrade` only checks `git --global` (i.e `$HOME/.gitconfig`) and complains that my git configuration is incomplete ``` pokyuser@c68fe28b8f36:/platform_builddir/build$ git config user.name Marcus Flyckt pokyuser@c68fe28b8f36:/platform_builddir/build$ git config user.email mafl@kvaser.com pokyuser@c68fe28b8f36:/platform_builddir/build$ devtool upgrade libdatachannel NOTE: Starting bitbake server... ERROR: Your git configuration is incomplete which will prevent rebases from working: Please set your name using: git config --global user.name Please set your email using: git config --global user.email ``` 96610 1 ross.burton 2023-10-04 11:20:26 +0000 Sounds like an easy fix, can you send a patch? 96611 2 marcus.flyckt 2023-10-04 12:39:54 +0000 Sure. Where should I send that patch and in what format? 96613 3 ross.burton 2023-10-04 19:10:49 +0000 This will be an interesting test of the new Contributor Guide! The actual code fix is, as far as I can tell, simply deleting "--global" from the correct git call. Then follow the process documented in https://docs.yoctoproject.org/contributor-guide/submit-changes.html. Please do say if there's anything missing or confusing in there, it's brand-new hot-off-the-press documentation that may well need tweaking. 96654 4 marcus.flyckt 2023-10-06 06:36:36 +0000 I've followed the documented process and submitted a patch to the Openembedded-core@lists.openembedded.org mailing list. 97042 5 ross.burton 2023-10-30 15:17:32 +0000 Fixed in 30a9f7de45050c8bac49d4b37419cc2e067a75fa. Marcus, did you find any problems or gaps in the documentation? 97165 6 marcus.flyckt 2023-10-31 05:58:12 +0000 I followed the steps in the documentation verbatim. I found it comprehensive and simple to follow.