<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>15229</bug_id>
          
          <creation_ts>2023-10-11 07:23:26 +0000</creation_ts>
          <short_desc>meta-yocto-bsp/conf/machine/beaglebone-yocto.conf: MACHINE_EXTRA_RRECOMMENDS</short_desc>
          <delta_ts>2024-09-27 01:20:45 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>BSPs</product>
          <component>bsps-meta-yocto</component>
          <version>4.2.4</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>5.1</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Robert Berger">pokylinux</reporter>
          <assigned_to name="Kevin Hao">kexin.hao</assigned_to>
          <cc>randy.macleod</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>Don&apos;t know</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>96670</commentid>
    <comment_count>0</comment_count>
    <who name="Robert Berger">pokylinux</who>
    <bug_when>2023-10-11 07:23:26 +0000</bug_when>
    <thetext>Here[1] both:

MACHINE_EXTRA_RRECOMMENDS = &quot;kernel-modules kernel-devicetree&quot;

and

MACHINE_ESSENTIAL_EXTRA_RDEPENDS += &quot;kernel-image kernel-devicetree&quot;

are defined.

I would say that MACHINE_ESSENTIAL_EXTRA_RDEPENDS wins, so does it make any sense to define both?

[1] https://git.yoctoproject.org/poky/tree/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>96672</commentid>
    <comment_count>1</comment_count>
    <who name="Kevin Hao">kexin.hao</who>
    <bug_when>2023-10-11 13:53:13 +0000</bug_when>
    <thetext>It makes no sense to put &apos;kernel-devicetree&apos; into both MACHINE_EXTRA_RRECOMMENDS and MACHINE_ESSENTIAL_EXTRA_RDEPENDS. I can make a patch to drop it from MACHINE_EXTRA_RRECOMMENDS. 

But since the &apos;kernel-modules&apos; is not essential for booting the machine, it should be set in MACHINE_EXTRA_RRECOMMENDS. And the &apos;kernel-image&apos; and &apos;kernel-devicetree&apos; are essential for the machine to boot and should be set in MACHINE_ESSENTIAL_EXTRA_RDEPENDS.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>96679</commentid>
    <comment_count>2</comment_count>
    <who name="Robert Berger">pokylinux</who>
    <bug_when>2023-10-12 08:04:01 +0000</bug_when>
    <thetext>What if you want to build a small image like a core-image-minimal and would like to have kernel-modules inside?

With MACHINE_EXTRA_RRECOMMENDS = &quot;kernel-modules kernel-devicetree&quot;

they will not be added, but with MACHINE_ESSENTIAL_EXTRA_RDEPENDS they will be added.

What would you suggest?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>96683</commentid>
    <comment_count>3</comment_count>
    <who name="Kevin Hao">kexin.hao</who>
    <bug_when>2023-10-12 12:53:07 +0000</bug_when>
    <thetext>The &apos;kernel-modules&apos; is not essential for booting the machine, so it is set in the MACHINE_EXTRA_RRECOMMENDS. This is consistent with all other machines (qemus, genericx86). We can&apos;t includes all the packages in core-image-minimal image.

If you indeed want to include the &apos;kernel-modules&apos; in your core-image-minimal image, you should modify your conf/local.conf by adding &apos;IMAGE_INSTALL:append = &quot;kernel-modules&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>96687</commentid>
    <comment_count>4</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2023-10-12 14:43:31 +0000</bug_when>
    <thetext>Robert, does Kevin&apos;s explanation help.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>96697</commentid>
    <comment_count>5</comment_count>
    <who name="Robert Berger">pokylinux</who>
    <bug_when>2023-10-13 06:52:25 +0000</bug_when>
    <thetext>Yes, this explanation helps.
Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>96744</commentid>
    <comment_count>6</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2023-10-19 15:01:40 +0000</bug_when>
    <thetext>Robert, it seems you got the info you need so I&apos;m closing the bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>96775</commentid>
    <comment_count>7</comment_count>
    <who name="Robert Berger">pokylinux</who>
    <bug_when>2023-10-24 10:27:29 +0000</bug_when>
    <thetext>I guess Kevin should make a patch as indicated above:

&quot;It makes no sense to put &apos;kernel-devicetree&apos; into both MACHINE_EXTRA_RRECOMMENDS and MACHINE_ESSENTIAL_EXTRA_RDEPENDS. I can make a patch to drop it from MACHINE_EXTRA_RRECOMMENDS. 
&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>99051</commentid>
    <comment_count>8</comment_count>
    <who name="Robert Berger">pokylinux</who>
    <bug_when>2024-05-23 06:39:48 +0000</bug_when>
    <thetext>this seems to be fixed

commit 97306ebc00ef3dd7eacab817659d980c29da96ea
Author: Kevin Hao &lt;kexin.hao@windriver.com&gt;
Date:   Tue Jan 2 19:57:08 2024 +0800

    beaglebone-yocto: Remove the redundant kernel-devicetree
    
    The kernel-devicetree is set in both MACHINE_ESSENTIAL_EXTRA_RDEPENDS
    and MACHINE_EXTRA_RRECOMMENDS. Since it is an essential package for
    boot, drop the one in MACHINE_EXTRA_RRECOMMENDS.
    
    [YOCTO #15229]
    
    (From meta-yocto rev: 5935d4fd751153f0f1c930924a5e2771f6dd5e72)
    
    Signed-off-by: Kevin Hao &lt;kexin.hao@windriver.com&gt;
    Signed-off-by: Richard Purdie &lt;richard.purdie@linuxfoundation.org&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>99052</commentid>
    <comment_count>9</comment_count>
    <who name="Robert Berger">pokylinux</who>
    <bug_when>2024-05-23 06:40:38 +0000</bug_when>
    <thetext>-MACHINE_EXTRA_RRECOMMENDS = &quot;kernel-modules kernel-devicetree&quot;
+MACHINE_EXTRA_RRECOMMENDS = &quot;kernel-modules&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>99739</commentid>
    <comment_count>10</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2024-09-26 18:17:13 +0000</bug_when>
    <thetext>Kevin, any news or move to 5.2 ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>99743</commentid>
    <comment_count>11</comment_count>
    <who name="Kevin Hao">kexin.hao</who>
    <bug_when>2024-09-27 01:20:45 +0000</bug_when>
    <thetext>This issue has already been fixed, so close it.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>