<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>15243</bug_id>
          
          <creation_ts>2023-10-19 11:47:32 +0000</creation_ts>
          <short_desc>Patchtest deletes all local changes when running</short_desc>
          <delta_ts>2023-10-19 15:04:30 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>6</classification_id>
          <classification>Yocto Project Subprojects</classification>
          <product>Patchwork/Patchtest</product>
          <component>Patchtest</component>
          <version>unspecified</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>High</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>4.3 M4</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ross Burton">ross.burton</reporter>
          <assigned_to name="Trevor Gamblin">tgamblin</assigned_to>
          <cc>randy.macleod</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>96730</commentid>
    <comment_count>0</comment_count>
    <who name="Ross Burton">ross.burton</who>
    <bug_when>2023-10-19 11:47:32 +0000</bug_when>
    <thetext>If there are any local changes in the repository then patchtest will delete then when it test-applies the patches.

(the git reset --hard in repo.py)

If it insists on applying/reseting the current branch then it should _definitely_ refuse to run if there are local uncommitted changes.

Ideally, it could create a temporary worktree so it can run in a pristine branch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>96745</commentid>
    <comment_count>1</comment_count>
    <who name="Trevor Gamblin">tgamblin</who>
    <bug_when>2023-10-19 15:04:30 +0000</bug_when>
    <thetext>Patch in master to fix: https://git.yoctoproject.org/poky/commit/?id=4ba54e29ffa6e3dbfcb92752a759b805a2591a09

It logs an error to console and exits if there are local changes. The temporary worktree idea will be kept in mind for future patchtest refactors.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>