15270 2023-10-30 15:29:03 +0000 patchtest-send-results should reply to specific threads 2024-09-03 13:28:08 +0000 1 1 6 Yocto Project Subprojects Patchwork/Patchtest Patchtest 5.0 x86 Multiple RESOLVED WORKSFORME Medium+ normal 5.1 M3 1 tgamblin tgamblin mhalstead randy.macleod richard.purdie ross.burton --- --- Don't know oldest_to_newest 97043 0 tgamblin 2023-10-30 15:29:03 +0000 the boto3 send_email function that patchtest-send-results uses does not provide a means to specify a thread to reply to. send_raw_email does but will require more careful construction of the reply patch. Ideally, patchtest-send-results should at least provide the option to specify a particular thread/message ID to reply to, if not make it the default. 97167 1 richard.purdie 2023-10-31 10:27:57 +0000 Make it the default please! 97169 2 richard.purdie 2023-10-31 10:28:30 +0000 *** Bug 15271 has been marked as a duplicate of this bug. *** 97174 3 tgamblin 2023-11-01 15:47:44 +0000 Did some investigating into this and found that there are actually two message IDs for patches on the mailing list, as described by the email headers: the "X-Orig-Message-Id" and the "Message ID". The latter seems to be what is needed to reply correctly to a message thread, but the former is what is available in the patch files that patchtest pulls from Patchwork. The Groups.io Help Center page confirms that it replaces the original message ID and renames the old one if a checkbox is selected in the account preferences (for a mailing list?): https://groups.io/helpcenter/membersmanual?single=true under "Seeing copies of your own messages that you email to groups": "For those interested in the technical details: When this checkbox is selected, Groups.io replaces the Message-Id header with a new, system-generated one and renames the original Message-Id header to X-Orig-Message-Id." I'm not sure what the larger implications for the mailing list usability would be if this is indeed an account setting for openembedded-core@lists.openembedded.org. If true and we don't want to change the groups.io settings, some extra function could be written to scan the mailing list for the right patch and get the new message ID, but that could have a lot of test time/validation impacts. 97175 4 tgamblin 2023-11-01 16:51:19 +0000 We'll have to scan the mailing list and compare message IDs to get the right one to respond against. 97176 5 tgamblin 2023-11-01 18:21:35 +0000 After review that's incorrect - I was operating under incorrect assumptions about message ID mangling. Submitted a patch to use In-Reply-To with results emails. 97232 6 tgamblin 2023-11-09 14:30:18 +0000 Fixed in https://git.yoctoproject.org/poky/commit/?id=2bddb6bb97075a2dd8e988867e0ee6e4556d2924 and https://git.yoctoproject.org/poky/commit/?id=b53d1287d24f506a08905fa86a81aca21203e73a 98142 7 ross.burton 2024-02-06 16:11:11 +0000 The threading is still not happening correctly. See for example https://lore.kernel.org/openembedded-core/0101018d7d1f5ee6-9ed9018f-ac7d-48ee-bbfb-c24420673d13-000000@us-west-2.amazonses.com/T/#u which is not threading as a reply to https://lore.kernel.org/openembedded-core/20240206061701.3947297-1-simone.p.weiss@posteo.com/T/#u. This impacts patchwork, as the patchtest reply doesn't appear at all: https://patchwork.yoctoproject.org/project/oe-core/patch/20240206061701.3947297-1-simone.p.weiss@posteo.com/ 98157 8 randy.macleod 2024-02-08 16:00:46 +0000 Trevor is working on this. 98178 9 tgamblin 2024-02-09 15:25:15 +0000 Sent a patch to add the 'References' header to patchtest-send-results in oe-core. That should fix this issue. 98260 10 randy.macleod 2024-02-22 16:03:22 +0000 Michael, Trevor is mostly waiting for your input on why the threading isn't working. 98271 11 tgamblin 2024-02-22 17:36:24 +0000 Steve was right in the bug triage meeting - it seems to be threading properly now. I'll keep an eye on it and reopen this if there are instances where it doesn't. 98330 12 tgamblin 2024-02-26 21:17:16 +0000 See: https://lists.openembedded.org/g/openembedded-core/topic/patchtest_results_for/104591017?p=,,,20,0,0,0::recentpostdate/sticky,,,20,2,0,104591017,previd%3D1708981536361105116,nextid%3D1708939175624870970&previd=1708981536361105116&nextid=1708939175624870970 That one didn't thread the way it should've. 98331 13 tgamblin 2024-02-26 21:17:46 +0000 Shorter comment: https://lists.openembedded.org/g/openembedded-core/topic/patchtest_results_for/104591017 99604 14 tgamblin 2024-09-03 13:28:08 +0000 I haven't seen patchtest fail to thread responses in a while. It would still be good to improve the subject line in its replies, but that's not a factor in whether it replies to the right email. I'll close this for now, but if we see problems again then it can be reopened.