15285 2023-11-17 19:56:38 +0000 devtool: Generated patches do not always match source end-of-line (CRLF vs LF) 2023-12-07 16:14:00 +0000 1 1 7 Build System, Metadata & Runtime OE-Core devtools / tool chain unspecified x86 Multiple RESOLVED FIXED Medium normal 5.0 1 yoann.congal yoann.congal meta.mr.watcher meta.watcher randy.macleod ross.burton --- --- No (bug/feature does not impact docs) oldest_to_newest 97276 0 yoann.congal 2023-11-17 19:56:38 +0000 When patchin projucer in meta-openembedded, I triggered this : [meta-multimedia][PATCH] juce/projucer: Backport a fix for the compilation under recent GCC https://lists.openembedded.org/g/openembedded-devel/message/106762 ... which had to be fixed like this : [meta-multimedia][PATCH] projucer: Refresh patch to apply cleanly https://lists.openembedded.org/g/openembedded-devel/message/106872 Origin sources are CR-LF (Windows): $ file modules/juce_core/system/juce_StandardHeader.h modules/juce_core/system/juce_StandardHeader.h: C source, ASCII text, with CRLF line terminators My commit in the devtool workspace is still in CR-LF. The generated patch is LF => it does not apply cleanly. 97303 1 yoann.congal 2023-11-22 14:16:13 +0000 Maybe in https://git.openembedded.org/openembedded-core/tree/meta/lib/oe/patch.py#n464 def extractPatches():? Sightly related patches : [PATCH v2 0/2] patch: reduce changes during patch refresh https://lists.openembedded.org/g/openembedded-core/message/191105 [PATCH v2 1/2] patch: extract patches without diffstats https://lists.openembedded.org/g/openembedded-core/message/191106 [PATCH v2 2/2] patch: extract patches with all-zero hash https://lists.openembedded.org/g/openembedded-core/message/191107 97339 2 yoann.congal 2023-11-27 13:50:26 +0000 Patch sent : https://lists.openembedded.org/g/openembedded-core/message/191303 97442 3 yoann.congal 2023-12-07 16:14:00 +0000 Patch merged : https://git.yoctoproject.org/poky/commit/?id=2c59f5ad01aa0e6dfd1e6291e770c77041be762e