15311 2023-12-07 17:13:56 +0000 Make patchtest check for use of deprecated CVE_CHECK_IGNORE 2024-01-10 15:19:50 +0000 1 1 6 Yocto Project Subprojects Patchwork/Patchtest Patchtest 5.0 x86 Multiple RESOLVED FIXED Medium+ normal 5.0 M2 1 tgamblin simone.p.weiss randy.macleod simone.p.weiss --- --- Don't know oldest_to_newest 97444 0 tgamblin 2023-12-07 17:13:56 +0000 Patchtest should recommend the use of CVE_STATUS instead if CVE_CHECK_IGNORE is found. 97474 1 simone.p.weiss 2023-12-09 20:33:59 +0000 I would like to do this. I just assigned the issue now to myself. Hope that is fine. 97490 2 tgamblin 2023-12-11 17:22:08 +0000 That's great. Let me know if you have issues. 97601 3 4999 simone.p.weiss 2023-12-17 18:38:54 +0000 Created attachment 4999 patch including bb renamed vars 97602 4 simone.p.weiss 2023-12-17 18:50:08 +0000 Hi Trevor, thanks for the offer. I have indeed some questions/issues now. After the first patch for this topic, it was suggested to also include checks for renamed variables. I have tried to implement such a check now, see also the attached patch above. While the check is fine and works, I wonder about how to handle subsequent tests, i.e. tests that are not pretests. When a patch containing a variable from BB_RENAMED_VARIABLES is already merged, the tinfoil setup while raise an error during parsing. This happens due to the check for such variables in lib/bb/data_smart.py and/or lib/bb/cookerdata.py. There a check for the usage of renamed variables is already performed before the testcase would run. Any suggestions how to handle this? Thanks 97616 5 tgamblin 2023-12-18 18:42:03 +0000 Hmm, that is a problem. Generally speaking, patchtest shouldn't be testing things that the rest of the build system is already going to check. I know I agreed with the suggestion that it also look for those variables before, but given that it's causing a problem I think it'd be better to just take the patch you've already sent, and open a new bug for patchtest describing the need (i.e. to also check for BB_RENAMED_VARIABLES) and what's blocking it. 97768 6 simone.p.weiss 2024-01-10 15:19:50 +0000 Was merged with https://git.yoctoproject.org/poky/commit/?id=70a92a2f8bfd0fce7e631972c2aff05121024dc2 4999 2023-12-17 18:38:54 +0000 2023-12-17 18:38:54 +0000 patch including bb renamed vars 0001-patchtest-Add-tests-for-deprecated-variables.patch text/plain 3409 simone.p.weiss RnJvbSBlNTk3YWIyMTFkMmUxY2NhOTgzODhkYzg5OTBkNDg2M2RmZGU2ZjM0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/U2ltb25lPTIwV2VpPUMzPTlGPz0gPHNpbW9u ZS5wLndlaXNzQHBvc3Rlby5jb20+CkRhdGU6IFN1biwgMTAgRGVjIDIwMjMgMTA6NTI6MjUgKzAx MDAKU3ViamVjdDogW1BBVENIXSBwYXRjaHRlc3Q6IEFkZCB0ZXN0cyBmb3IgZGVwcmVjYXRlZCB2 YXJpYWJsZXMKTUlNRS1WZXJzaW9uOiAxLjAKQ29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFy c2V0PVVURi04CkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKCklmIGEgcmVjaXBlcyB3 YXMgbW9kaWZpZWQgY2hlY2sgaWYgdmFyaWFibGVzIG5hbWVzIGFyZSB1cCB0byBkYXRlOgoKLSBS ZWNvbW1lbmQgdXNhZ2Ugb2YgYENWRV9TVEFUVVNgIGlmIGBDVkVfQ0hFQ0tfSUdOT1JFYCBpcyB1 c2VkLgogIFRoaXMgaXMgYSBkZXByZWFjdGVkIHZhcmlhYmxlIGFuZCB3aWxsIHJlc3VsdCBpbiBh IHdhcm5pbmcgZnJvbSB0aGUKICBjdmUtY2hlY2suY2xhc3MgYW5kIHNob3VsZCBoZW5jZSBub3Qg YmUgdXNlZCBhbnltb3JlLiBTZWUgYWxzbyBbWU9DVE8gIzE1MzExXQotIENoZWNrIGZvciB1c2Ug b2YgcmVuYW1lZCB2YXJpYWJsZXMgZnJvbSBgQkJfUkVOQU1FRF9WQVJJQUJMRVNgLgoKU2lnbmVk LW9mZi1ieTogU2ltb25lIFdlacOfIDxzaW1vbmUucC53ZWlzc0Bwb3N0ZW8uY29tPgotLS0KIG1l dGEvbGliL3BhdGNodGVzdC90ZXN0cy90ZXN0X21ldGFkYXRhLnB5IHwgNDEgKysrKysrKysrKysr KysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCA0MSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0 IGEvbWV0YS9saWIvcGF0Y2h0ZXN0L3Rlc3RzL3Rlc3RfbWV0YWRhdGEucHkgYi9tZXRhL2xpYi9w YXRjaHRlc3QvdGVzdHMvdGVzdF9tZXRhZGF0YS5weQppbmRleCBiNmY0NDU2YWQyLi45NThlYjM1 MDdmIDEwMDY0NAotLS0gYS9tZXRhL2xpYi9wYXRjaHRlc3QvdGVzdHMvdGVzdF9tZXRhZGF0YS5w eQorKysgYi9tZXRhL2xpYi9wYXRjaHRlc3QvdGVzdHMvdGVzdF9tZXRhZGF0YS5weQpAQCAtMjUs NiArMjUsOCBAQCBjbGFzcyBUZXN0TWV0YWRhdGEoYmFzZS5NZXRhZGF0YSk6CiAgICAgc2hhMjU2 c3VtID0gJ3NoYTI1NnN1bScKICAgICBnaXRfcmVnZXggPSBweXBhcnNpbmcuUmVnZXgoJ15naXRc OlwvXC8uKicpCiAgICAgbWV0YWRhdGFfc3VtbWFyeSA9ICdTVU1NQVJZJworICAgIGN2ZV9jaGVj a19pZ25vcmVfdmFyID0gJ0NWRV9DSEVDS19JR05PUkUnCisgICAgY3ZlX3N0YXR1c192YXIgPSAn Q1ZFX1NUQVRVUycKIAogICAgIGRlZiB0ZXN0X2xpY2Vuc2VfcHJlc2VuY2Uoc2VsZik6CiAgICAg ICAgIGlmIG5vdCBzZWxmLmFkZGVkOgpAQCAtMTc4LDMgKzE4MCw0MiBAQCBjbGFzcyBUZXN0TWV0 YWRhdGEoYmFzZS5NZXRhZGF0YSk6CiAgICAgICAgICAgICAjICIke1BOfSB2ZXJzaW9uICR7UE59 LSR7UFJ9IiBpcyB0aGUgZGVmYXVsdCwgc28gZmFpbCBpZiBkZWZhdWx0CiAgICAgICAgICAgICBp ZiBzdW1tYXJ5LnN0YXJ0c3dpdGgoJyVzIHZlcnNpb24nICUgcG4pOgogICAgICAgICAgICAgICAg IHNlbGYuZmFpbCgnJXMgaXMgbWlzc2luZyBpbiBuZXdseSBhZGRlZCByZWNpcGUnICUgc2VsZi5t ZXRhZGF0YV9zdW1tYXJ5KQorCisgICAgZGVmIHByZXRlc3RfcmVuYW1lZF92YXJpYWJsZXMoc2Vs Zik6CisgICAgICAgIGlmIG5vdCBzZWxmLm1vZGlmaWVkOgorICAgICAgICAgICAgc2VsZi5za2lw KCdObyBtb2RmaWVkIHJlY2lwZXMsIHNraXBwaW5nIHRlc3QnKQorCisgICAgICAgIGZvciBwbiBp biBzZWxmLm1vZGlmaWVkOgorICAgICAgICAgICAgcmQgPSBzZWxmLnRpbmZvaWwucGFyc2VfcmVj aXBlKHBuKQorICAgICAgICAgICAgCisgICAgICAgICAgICAjIGNoZWNrIGZvciB2YXJpYWJsZXMg aW4gQkJfUkVOQU1FRF9WQVJJQUJMRVMsIHRoYXQgY29udGFpbnMKKyAgICAgICAgICAgICMgdmFy aWFibGVzIHRoYXQgaGF2ZSBiZWVuIHNpbXBseSByZW5hbWVkLiBEbyB0aGlzIGluIGEgcHJldGVz dCwgYXMKKyAgICAgICAgICAgICMgYWZ0ZXIgbWVyZ2luZyB0aGUgdGluZm9pbCBzZXR1cCB3b3Vs ZCBmYWlsIGlmIHN1Y2ggdmFyaWFibGVzIGFyZQorICAgICAgICAgICAgIyBwcmVzZW50IGluIGEg cGF0Y2guCisgICAgICAgICAgICByZW5hbWVkX3ZhcnMgPSByZC5nZXRWYXJGbGFncygnQkJfUkVO QU1FRF9WQVJJQUJMRVMnKSBvciB7fQorCisgICAgICAgICAgICBmb3IgdmFyIGluIHJlbmFtZWRf dmFyczoKKyAgICAgICAgICAgICAgICBmb3IgcGF0Y2ggaW4gc2VsZi5wYXRjaHNldDoKKyAgICAg ICAgICAgICAgICAgICAgIyBwYXRjaGVzIG1pZ2h0IGNvbnRhaW4gcmVuYW1lZCB2YXJpYWJsZXMg c3RpbGwKKyAgICAgICAgICAgICAgICAgICAgaWYgcGF0Y2gucGF0aC5lbmRzd2l0aCgnLnBhdGNo Jyk6CisgICAgICAgICAgICAgICAgICAgICAgICBjb250aW51ZQorICAgICAgICAgICAgICAgICAg ICB1c2VkID0gc3RyKHBhdGNoKS5maW5kKHZhcikKKyAgICAgICAgICAgICAgICAgICAgaWYgdXNl ZCAhPSAtMToKKyAgICAgICAgICAgICAgICAgICAgICAgIHNlbGYuZmFpbCgnJXMgaXMgZGVwcmVj YXRlZCBhbmQgc2hvdWxkIGJlIHJlcGxhY2VkJyAlIHZhcikKKworICAgIGRlZiB0ZXN0X2RlcHJl Y2F0ZWRfdmFyaWFibGVzKHNlbGYpOgorICAgICAgICBpZiBub3Qgc2VsZi5tb2RpZmllZDoKKyAg ICAgICAgICAgIHNlbGYuc2tpcCgnTm8gbW9kZmllZCByZWNpcGVzLCBza2lwcGluZyB0ZXN0JykK KworICAgICAgICBmb3IgcG4gaW4gc2VsZi5tb2RpZmllZDoKKyAgICAgICAgICAgIHJkID0gc2Vs Zi50aW5mb2lsLnBhcnNlX3JlY2lwZShwbikKKyAgICAgICAgICAgICMgd2UgYXJlIG5vdCBpbnRl cmVzdGVkIGluIGltYWdlcworICAgICAgICAgICAgaWYgJ2NvcmUtaW1hZ2UnIGluIHBuOgorICAg ICAgICAgICAgICAgIGNvbnRpbnVlCisKKyAgICAgICAgICAgICMgY2hlY2sgZm9yIENWRV9DSEVD S19JR05PUkUgdGhhdCB3YXMgZGVwcmVhY3RlZCBieSBDVkVfU1RBVFVTIHdpY2gKKyAgICAgICAg ICAgICMgaXMgZW5yaWNoZWQgd2l0aCB0aGUgc3RhdHVzIG9mIHRoZSBDVkUgZS5nLiAocGF0Y2hl ZCwgaWdub3JlZCwgLi4uKS4KKyAgICAgICAgICAgIGN2ZV9jaGVja19pZ25vcmUgPSByZC5nZXRW YXIoc2VsZi5jdmVfY2hlY2tfaWdub3JlX3ZhcikKKyAgICAgICAgICAgIGlmIGN2ZV9jaGVja19p Z25vcmUgaXMgbm90IE5vbmU6CisgICAgICAgICAgICAgICAgc2VsZi5mYWlsKCclcyBpcyBkZXBy ZWNhdGVkIGFuZCBzaG91bGQgYmUgcmVwbGFjZWQgYnkgJXMnICUgKHNlbGYuY3ZlX2NoZWNrX2ln bm9yZV92YXIsIHNlbGYuY3ZlX3N0YXR1c192YXIpKQorCi0tIAoyLjM5LjIKCg==