15325 2023-12-15 12:51:57 +0000 kernel: do_symlink_kernsrc is not reentrant when S is overriden 2026-03-25 23:48:55 +0000 1 1 7 Build System, Metadata & Runtime OE-Core kernel 5.1 x86 Multiple IN PROGRESS REVIEW Medium normal 6.1 1 ecordonnier unassigned randy.macleod tom.zanussi --- --- No (bug/feature does not impact docs) oldest_to_newest 97576 0 ecordonnier 2023-12-15 12:51:57 +0000 The function do_symlink_kernsrc is not reentrant in the case where S is defined to a non-default value. How to reproduce (tested with commit 7d06e4e30b39a901a3d0b263d5de43f954c3270b of poky which is quite close to master): - add this line to meta/recipes-kernel/linux/linux-yocto_6.5.bb: S = "${WORKDIR}/my-kernel-source-dir" - build linux-yocto a first time: bitbake linux-yocto This works, and you can see that the function do_symlink_kernsrc created a symlink : ``` poky/build$ ls -l tmp/work-shared/qemux86-64/ total 8 drwxr-xr-x 2 ecordonnier ecordonnier 4096 Dec 15 13:18 kernel-build-artifacts drwxr-xr-x 2 ecordonnier ecordonnier 4096 Dec 15 13:18 kernel-source poky/build$ ls -l tmp/work/qemux86_64-poky-linux/linux-yocto/6.5.13+git/ total 1480 ... ... lrwxrwxrwx 1 ecordonnier ecordonnier 73 Dec 15 13:18 my-kernel-source-dir -> /home/ecordonnier/dev/poky/build/tmp/work-shared/qemux86-64/kernel-source ``` - Build a second time (in reality this happened to me when building again after updating poky to a version which modified kernel.bbclass): bitbake -C symlink_kernsrc linux-yocto This will fail, and leave the directory structure in a completely broken state: kernel-source is now a symlink to itself, and my-kernel-source-dir is a broken symlink: ``` poky/build$ ls -l tmp/work-shared/qemux86-64/ total 8 drwxr-xr-x 2 ecordonnier ecordonnier 4096 Dec 15 13:18 kernel-build-artifacts lrwxrwxrwx 1 ecordonnier ecordonnier 73 Dec 15 13:18 kernel-source -> /home/ecordonnier/dev/poky/build/tmp/work-shared/qemux86-64/kernel-source poky/build$ ls -l tmp/work/qemux86_64-poky-linux/linux-yocto/6.5.13+git/ ... lrwxrwxrwx 1 ecordonnier ecordonnier 73 Dec 15 13:20 my-kernel-source-dir -> /home/ecordonnier/dev/poky/build/tmp/work-shared/qemux86-64/kernel-source ``` 97622 1 ecordonnier 2023-12-19 13:41:37 +0000 https://lists.openembedded.org/g/openembedded-core/topic/patch_v4_kernel_bbclass/103262114 97632 2 randy.macleod 2023-12-21 15:32:56 +0000 Patch on list, thanks! 99071 3 randy.macleod 2024-05-23 15:30:31 +0000 Etienne, I took a quick look but didn't find a commit in master. Please provide a commit link if that exists. 99072 4 ecordonnier 2024-05-23 15:33:28 +0000 Randy, there is no patch merged. I received some feedback after a couple of months, and then haven't found time to react on the feedback and work on a new version of the patch. 99074 5 randy.macleod 2024-05-23 21:49:28 +0000 Thanks for the update, Etienne. 99094 6 ecordonnier 2024-05-27 09:11:36 +0000 This was the latest feedback I got: https://lists.openembedded.org/g/openembedded-core/message/195238?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Acreated%2C%2Creentrant%2C20%2C2%2C0%2C103308574 100076 7 randy.macleod 2024-10-31 15:09:20 +0000 Bulk move of 5.1 bugs to 5.2. -- YP bug review (Randy) 101769 8 ecordonnier 2025-04-29 07:30:28 +0000 I unassigned myself, because I don't know when I will have time to work on this. In principle this should be fixed, even though it's only a corner-case with some specific preconditions, so not high priority. 101821 9 randy.macleod 2025-05-01 14:07:08 +0000 Bulk move of all unassigned 5.2 medium importance bugs to 5.3.