15404 2024-02-16 16:06:42 +0000 git fetcher: Git clone invocation fails when URL contains parentheses 2024-10-17 20:24:27 +0000 1 1 7 Build System, Metadata & Runtime BitBake bitbake 2.0.3 x86 Multiple RESOLVED FIXED Medium normal 5.1 1 privest randy.macleod poky.bs.watcher poky.watcher randy.macleod --- --- No (bug/feature does not impact docs) oldest_to_newest 98223 0 5015 privest 2024-02-16 16:06:42 +0000 Created attachment 5015 Proposed patch to escape parentheses in git fetcher # Summary: When using git fetcher on a repo with parentheses in its URL, the invocation of the git clone command will fail. The clone directory is not quoted thus the shell will return an error and won't execute the command. # To reproduce: 1. Create a recipe using git fetcher with a repo containing parentheses. (example SRC_URI: "git://mygit.com/my%28repo%29name;protocol=https;rev=22c569f770d8b5594dc5661f99a92e7a0c042d26") 2. Run bitbake my-recipe # Actual result (from log.do_fetch): ``` DEBUG: Fetcher accessed the network with the command LANG=C git clone --bare --mirror 'https://mygit.com/my(repo)name' /data/privest/YoctoProject/build/downloads//git2/my(repo)name --progress /bin/sh: 1: Syntax error: "(" unexpected ``` # Expected result: Should clone the repo successfully. A solution would be to escape parentheses from the srcname. See the attached patch. # Build Configuration: BB_VERSION = "2.0.0" BUILD_SYS = "x86_64-linux" NATIVELSBSTRING = "ubuntu-22.04" meta meta-poky = "kirkstone:0b39955d14600257a6eafc211fd68a933c69a0e9" meta-yocto-bsp = "kirkstone:0b39955d14600257a6eafc211fd68a933c69a0e9" 98258 1 randy.macleod 2024-02-22 15:39:21 +0000 It's a simple patch. Philippe, can you send the patch to the email list? 98446 2 privest 2024-03-10 03:34:51 +0000 (In reply to Randy MacLeod from comment #1) > It's a simple patch. Philippe, can you send the patch to the email list? A properly formatted patch was sent to the bitbake-devel@lists.openembedded.org mailing list. Thank you! 98477 3 randy.macleod 2024-03-14 15:08:13 +0000 Thanks Philippe. Richard expects to merge this to master soon and I'll add a link when he does that. 99937 4 randy.macleod 2024-10-17 20:24:27 +0000 Fixed by: https://git.openembedded.org/bitbake/commit/?id=12f9738577934ad7c99f0770f1392a9d6050e7d6 bitbake on master ❯ git branch -a --contains 12f9738577934ad7c99f0770f1392a9d6050e7d6 * master remotes/origin/2.10 remotes/origin/2.8 remotes/origin/HEAD -> origin/master remotes/origin/master Thanks Philippe! 5015 2024-02-16 16:06:42 +0000 2024-02-16 16:06:42 +0000 Proposed patch to escape parentheses in git fetcher 0001-Escape-parentheses-in-git-src-name-in-git-fetcher.patch application/mbox 1045 privest RnJvbSA1NjIxNDUyOWU0OWNkNGIxNTY0MTFhMzk1NmQ5YjQ5NmExYjQ1ZGJhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBSaXZlc3QgPHByaXZlc3RAZ2VuZXRlYy5jb20+ CkRhdGU6IEZyaSwgMTYgRmViIDIwMjQgMTA6NTc6MzcgLTA1MDAKU3ViamVjdDogW1BBVENIXSBF c2NhcGUgcGFyZW50aGVzZXMgaW4gZ2l0IHNyYyBuYW1lIGluIGdpdCBmZXRjaGVyCgotLS0KIGJp dGJha2UvbGliL2JiL2ZldGNoMi9naXQucHkgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNl cnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9iaXRiYWtlL2xpYi9iYi9mZXRj aDIvZ2l0LnB5IGIvYml0YmFrZS9saWIvYmIvZmV0Y2gyL2dpdC5weQppbmRleCA0ZDZlNTdhZGU3 Li41MjdlNWUwZTE0IDEwMDY0NAotLS0gYS9iaXRiYWtlL2xpYi9iYi9mZXRjaDIvZ2l0LnB5Cisr KyBiL2JpdGJha2UvbGliL2JiL2ZldGNoMi9naXQucHkKQEAgLTI1Niw3ICsyNTYsNyBAQCBjbGFz cyBHaXQoRmV0Y2hNZXRob2QpOgogICAgICAgICAgICAgICAgICAgICB1ZC51bnJlc29sdmVkcmV2 W25hbWVdID0gdWQucmV2aXNpb25zW25hbWVdCiAgICAgICAgICAgICAgICAgdWQucmV2aXNpb25z W25hbWVdID0gc2VsZi5sYXRlc3RfcmV2aXNpb24odWQsIGQsIG5hbWUpCiAKLSAgICAgICAgZ2l0 c3JjbmFtZSA9ICclcyVzJyAlICh1ZC5ob3N0LnJlcGxhY2UoJzonLCAnLicpLCB1ZC5wYXRoLnJl cGxhY2UoJy8nLCAnLicpLnJlcGxhY2UoJyonLCAnLicpLnJlcGxhY2UoJyAnLCdfJykpCisgICAg ICAgIGdpdHNyY25hbWUgPSAnJXMlcycgJSAodWQuaG9zdC5yZXBsYWNlKCc6JywgJy4nKSwgdWQu cGF0aC5yZXBsYWNlKCcvJywgJy4nKS5yZXBsYWNlKCcqJywgJy4nKS5yZXBsYWNlKCcgJywnXycp LnJlcGxhY2UoJygnLCAnXycpLnJlcGxhY2UoJyknLCAnXycpKQogICAgICAgICBpZiBnaXRzcmNu YW1lLnN0YXJ0c3dpdGgoJy4nKToKICAgICAgICAgICAgIGdpdHNyY25hbWUgPSBnaXRzcmNuYW1l WzE6XQogCi0tIAoyLjQwLjAKCg==