15448 2024-03-20 12:02:44 +0000 Possible failure in do_uboot_assemble_fitimage task 2024-05-23 15:18:55 +0000 1 1 7 Build System, Metadata & Runtime Meta-yocto meta-yocto 4.2 Other arm RESOLVED FIXED Medium normal 5.0 1 mfrynas mfrynas poky.bs.watcher poky.watcher randy.macleod --- --- Don't know oldest_to_newest 98538 0 5033 mfrynas 2024-03-20 12:02:44 +0000 Created attachment 5033 adjustment of do_uboot_assemble_fitimage task to multiple UBOOT_CONFIG definitions Possible issue in UBOOT_CONFIG interation in code located in uboot-sign.bbclass, task do_uboot_assemble_fitimage(): unset i j k <------- possible issue for config in ${UBOOT_MACHINE}; do i=$(expr $i + 1); bberror "i = $i, config = ${config}" for type in ${UBOOT_CONFIG}; do j=$(expr $j + 1); bberror "j = $j, type = ${type}" if [ $j -eq $i ]; then break; fi done for binary in ${UBOOT_BINARIES}; do k=$(expr $j + 1); <------- possible issue bberror "k = $k, binary = ${binary}" if [ $k -eq $i ]; then break; fi done cd ${B}/${config} bberror "uboot_assemble_fitimage ${type} ${binary}" uboot_assemble_fitimage_helper ${type} ${binary} done For following definitions: UBOOT_CONFIG[conf_1] = "conf_1_defconfig,,u-boot.bin_1" UBOOT_CONFIG[conf_2] = "conf_2_defconfig,,u-boot.bin_2" I get following log prints: i = 1, config = conf_1_defconfig j = 1, type = conf_1 k = 2, binary = u-boot.bin_1 k = 2, binary = u-boot.bin_2 uboot_assemble_fitimage conf_1 u-boot.bin_2 i = 2, config = conf_2_defconfig j = 2, type = conf_1 k = 3, binary = u-boot.bin_1 k = 3, binary = u-boot.bin_2 uboot_assemble_fitimage conf_1 u-boot.bin_2 The correct binary file never gets hit ($k never equals $i) and the one from last iteration is passed do uboot_assemble_fitimage() function. What's more, the $j is not reset after upper loop iteration, and while iterating over UBOOT_CONFIG the second time the condition $j -eq $i is true for the first entry (conf_1 in my example, whereas it should be conf_2). With change in attacked diff file it is working for me correctly. 98557 1 randy.macleod 2024-03-21 14:45:18 +0000 Please send the patch to the list with a good commit log. Patch reviewed quickly in a meeting... Thanks, ../Randy 98602 2 5036 mfrynas 2024-03-25 13:20:44 +0000 Created attachment 5036 Patch with fix proposal Patch proposal with detailed description. 98608 3 5037 mfrynas 2024-03-25 16:12:45 +0000 Created attachment 5037 Fix iteration over UBOOT_BINARIES in uboot-sign.bbclass 99063 4 randy.macleod 2024-05-23 15:12:18 +0000 Likley fixed. Randy to find the commit. 99065 5 randy.macleod 2024-05-23 15:18:55 +0000 Seems to be fixed by: https://git.yoctoproject.org/poky/commit/?id=ed7cd56a8ac50ce77bc33cd10354862ce5260f8f 5033 2024-03-20 12:02:44 +0000 2024-03-20 12:02:44 +0000 adjustment of do_uboot_assemble_fitimage task to multiple UBOOT_CONFIG definitions do_uboot_assemble_fitimage.diff text/plain 611 mfrynas LS0tIG9yaWdpbmFsICAgMjAyNC0wMy0yMCAxMjo1NToxMS42NTA3NDk5OTIgKzAxMDAKKysrIG1v ZGlmaWVkICAgMjAyNC0wMy0yMCAxMjo1NzozNi4xMjY5Mzc1MjIgKzAxMDAKQEAgLTQsOCArNCw5 IEBACiAgICBmaQogCiAgICBpZiBbIC1uICIke1VCT09UX0NPTkZJR30iIF07IHRoZW4KLSAgICAg ICB1bnNldCBpIGogaworICAgICAgIHVuc2V0IGkKICAgICAgICBmb3IgY29uZmlnIGluICR7VUJP T1RfTUFDSElORX07IGRvCisgICAgICAgICAgIHVuc2V0IGogawogICAgICAgICAgICBpPSQoZXhw ciAkaSArIDEpOwogICAgICAgICAgICBmb3IgdHlwZSBpbiAke1VCT09UX0NPTkZJR307IGRvCiAg ICAgICAgICAgICAgICBqPSQoZXhwciAkaiArIDEpOwpAQCAtMTUsNyArMTYsNyBAQAogICAgICAg ICAgICBkb25lCiAKICAgICAgICAgICAgZm9yIGJpbmFyeSBpbiAke1VCT09UX0JJTkFSSUVTfTsg ZG8KLSAgICAgICAgICAgICAgIGs9JChleHByICRqICsgMSk7CisgICAgICAgICAgICAgICBrPSQo ZXhwciAkayArIDEpOwogICAgICAgICAgICAgICAgaWYgWyAkayAtZXEgJGkgXTsgdGhlbgogICAg ICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgZmk= 5036 2024-03-25 13:20:44 +0000 2024-03-25 16:10:26 +0000 Patch with fix proposal 0001-uboot-sign-fix-iteration-over-UBOOT_MACHINE-and-UBOO.patch text/plain 1641 mfrynas RnJvbSBkODZjMzZkZjNkYTczYjI4ODcxMjVhM2VkNzgxNjU2OGI0YTk0NzUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWwgRnJ5bmFzIDxtaWNoYWwuZnJ5bmFzQGludGVyLmlr ZWEuY29tPgpEYXRlOiBNb24sIDI1IE1hciAyMDI0IDEzOjU4OjQyICswMTAwClN1YmplY3Q6IFtQ QVRDSF0gdWJvb3Qtc2lnbjogZml4IGl0ZXJhdGlvbiBvdmVyIFVCT09UX01BQ0hJTkUgYW5kCiBV Qk9PVF9CSU5BUklFUwoKRm9yIG11bHRpcGxlIFVCT09UX0NPTkZJRyBjb25maWd1cmF0aW9ucyB0 aGUgZmF1bHR5IGNvZGUgaW4gdGFzawpkb191Ym9vdF9hc3NlbWJsZV9maXRpbWFnZSgpIGdldHMg ZXhlY3V0ZWQuClRoZXJlIHNlZW0gdG8gYmUgMiBidWdzIGluIHRoaXMgY29kZToKMS4gaW5kZXgg dmFyaWFibGVzICdqJyBhbmQgJ2snIGFyZSBub3QgcmVzZXR0ZWQgZm9yIGluY3JlYXNlZCAnaScg aW5kZXgsCiAgIGVmZmVjdGl2ZWx5IGxvb3Npbmcgc3luY2hyb25pemF0aW9uIHdpdGggdGhlaXMg cmVsYXRlZCBsb29wcwoyLiBpbmRleCB2YXJpYWJsZSAnaycgZ2V0IGluaXRpYWxpemVkIHdpdGgg dmFsdWUgb2YgaW5kZXggdmFyaWFibGUgJ2onCiAgIHdoaWNoIHdhcyBpbmNyZWFzZWQgaW4gdGhl IHByZXZpb3VzIGxvb3AuIFRoYXQgd2F5IHRoZSBjb25kaXRpb24KICAgWyAkayAtZXEgJGkgXSBp cyBhbHdheXMgZmFsc2UgYW5kIHJlc3VsdHMgaW4gdGhlICdiaW5hcnknIHZhcmlhYmxlCiAgIGJl aW5nIGFsd2F5cyBzZXQgdG8gdGhlIGxhc3QgZW50cnkgb2YgVUJPT1RfQklOQVJJRVMgdmFyaWFi bGUuCgpDaGFuZ2UtSWQ6IEkwOGU1ZmJmZWQ1ODZiNTRlZGU2OGMwMWE3OGQ4MThlZjJmODI5YWVh Ci0tLQogbWV0YS9jbGFzc2VzLXJlY2lwZS91Ym9vdC1zaWduLmJiY2xhc3MgfCA1ICsrKy0tCiAx IGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL21ldGEvY2xhc3Nlcy1yZWNpcGUvdWJvb3Qtc2lnbi5iYmNsYXNzIGIvbWV0YS9jbGFzc2Vz LXJlY2lwZS91Ym9vdC1zaWduLmJiY2xhc3MKaW5kZXggMzA2NWM1NDU3Ny4uYmFhMjQ2NGQ4ZCAx MDA2NDQKLS0tIGEvbWV0YS9jbGFzc2VzLXJlY2lwZS91Ym9vdC1zaWduLmJiY2xhc3MKKysrIGIv bWV0YS9jbGFzc2VzLXJlY2lwZS91Ym9vdC1zaWduLmJiY2xhc3MKQEAgLTMzNyw4ICszMzcsOSBA QCBkb191Ym9vdF9hc3NlbWJsZV9maXRpbWFnZSgpIHsKIAlmaQogCiAJaWYgWyAtbiAiJHtVQk9P VF9DT05GSUd9IiBdOyB0aGVuCi0JCXVuc2V0IGkgaiBrCisJCXVuc2V0IGkKIAkJZm9yIGNvbmZp ZyBpbiAke1VCT09UX01BQ0hJTkV9OyBkbworCQkJdW5zZXQgaiBrCiAJCQlpPSQoZXhwciAkaSAr IDEpOwogCQkJZm9yIHR5cGUgaW4gJHtVQk9PVF9DT05GSUd9OyBkbwogCQkJCWo9JChleHByICRq ICsgMSk7CkBAIC0zNDgsNyArMzQ5LDcgQEAgZG9fdWJvb3RfYXNzZW1ibGVfZml0aW1hZ2UoKSB7 CiAJCQlkb25lCiAKIAkJCWZvciBiaW5hcnkgaW4gJHtVQk9PVF9CSU5BUklFU307IGRvCi0JCQkJ az0kKGV4cHIgJGogKyAxKTsKKwkJCQlrPSQoZXhwciAkayArIDEpOwogCQkJCWlmIFsgJGsgLWVx ICRpIF07IHRoZW4KIAkJCQkJYnJlYWs7CiAJCQkJZmkKLS0gCjIuNDAuMQoK 5037 2024-03-25 16:12:45 +0000 2024-03-25 16:12:45 +0000 Fix iteration over UBOOT_BINARIES in uboot-sign.bbclass 0001-uboot-sign-fix-iteration-over-UBOOT_BINARIES.patch text/plain 1611 mfrynas RnJvbSBkODZjMzZkZjNkYTczYjI4ODcxMjVhM2VkNzgxNjU2OGI0YTk0NzUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWwgRnJ5bmFzIDxtZnJ5bmFzQGdtYWlsLmNvbT4KRGF0 ZTogTW9uLCAyNSBNYXIgMjAyNCAxMzo1ODo0MiArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIHVib290 LXNpZ246IGZpeCBpdGVyYXRpb24gb3ZlciBVQk9PVF9CSU5BUklFUwoKRm9yIG11bHRpcGxlIFVC T09UX0NPTkZJRyBjb25maWd1cmF0aW9ucyB0aGUgZmF1bHR5IGNvZGUgaW4gdGFzawpkb191Ym9v dF9hc3NlbWJsZV9maXRpbWFnZSgpIGdldHMgZXhlY3V0ZWQuClRoZXJlIHNlZW0gdG8gYmUgMiBi dWdzIGluIHRoaXMgY29kZToKMS4gaW5kZXggdmFyaWFibGVzICdqJyBhbmQgJ2snIGFyZSBub3Qg cmVzZXR0ZWQgZm9yIGluY3JlYXNlZCAnaScgaW5kZXgsCiAgIGVmZmVjdGl2ZWx5IGxvb3Npbmcg c3luY2hyb25pemF0aW9uIHdpdGggdGhlaXMgcmVsYXRlZCBsb29wcwoyLiBpbmRleCB2YXJpYWJs ZSAnaycgZ2V0IGluaXRpYWxpemVkIHdpdGggdmFsdWUgb2YgaW5kZXggdmFyaWFibGUgJ2onCiAg IHdoaWNoIHdhcyBpbmNyZWFzZWQgaW4gdGhlIHByZXZpb3VzIGxvb3AuIFRoYXQgd2F5IHRoZSBj b25kaXRpb24KICAgWyAkayAtZXEgJGkgXSBpcyBhbHdheXMgZmFsc2UgYW5kIHJlc3VsdHMgaW4g dGhlICdiaW5hcnknIHZhcmlhYmxlCiAgIGJlaW5nIGFsd2F5cyBzZXQgdG8gdGhlIGxhc3QgZW50 cnkgb2YgVUJPT1RfQklOQVJJRVMgdmFyaWFibGUuCgpDaGFuZ2UtSWQ6IEkwOGU1ZmJmZWQ1ODZi NTRlZGU2OGMwMWE3OGQ4MThlZjJmODI5YWVhCi0tLQogbWV0YS9jbGFzc2VzLXJlY2lwZS91Ym9v dC1zaWduLmJiY2xhc3MgfCA1ICsrKy0tCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCsp LCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL21ldGEvY2xhc3Nlcy1yZWNpcGUvdWJvb3Qt c2lnbi5iYmNsYXNzIGIvbWV0YS9jbGFzc2VzLXJlY2lwZS91Ym9vdC1zaWduLmJiY2xhc3MKaW5k ZXggMzA2NWM1NDU3Ny4uYmFhMjQ2NGQ4ZCAxMDA2NDQKLS0tIGEvbWV0YS9jbGFzc2VzLXJlY2lw ZS91Ym9vdC1zaWduLmJiY2xhc3MKKysrIGIvbWV0YS9jbGFzc2VzLXJlY2lwZS91Ym9vdC1zaWdu LmJiY2xhc3MKQEAgLTMzNyw4ICszMzcsOSBAQCBkb191Ym9vdF9hc3NlbWJsZV9maXRpbWFnZSgp IHsKIAlmaQogCiAJaWYgWyAtbiAiJHtVQk9PVF9DT05GSUd9IiBdOyB0aGVuCi0JCXVuc2V0IGkg aiBrCisJCXVuc2V0IGkKIAkJZm9yIGNvbmZpZyBpbiAke1VCT09UX01BQ0hJTkV9OyBkbworCQkJ dW5zZXQgaiBrCiAJCQlpPSQoZXhwciAkaSArIDEpOwogCQkJZm9yIHR5cGUgaW4gJHtVQk9PVF9D T05GSUd9OyBkbwogCQkJCWo9JChleHByICRqICsgMSk7CkBAIC0zNDgsNyArMzQ5LDcgQEAgZG9f dWJvb3RfYXNzZW1ibGVfZml0aW1hZ2UoKSB7CiAJCQlkb25lCiAKIAkJCWZvciBiaW5hcnkgaW4g JHtVQk9PVF9CSU5BUklFU307IGRvCi0JCQkJaz0kKGV4cHIgJGogKyAxKTsKKwkJCQlrPSQoZXhw ciAkayArIDEpOwogCQkJCWlmIFsgJGsgLWVxICRpIF07IHRoZW4KIAkJCQkJYnJlYWs7CiAJCQkJ ZmkKLS0gCjIuNDAuMQoK