15466 2024-04-04 14:20:30 +0000 devtool uses a gitsm URI for a version not using submodules if HEAD does 2024-08-08 15:10:35 +0000 1 1 7 Build System, Metadata & Runtime OE-Core devtools / tool chain unspecified x86 Multiple RESOLVED FIXED Medium+ normal 5.1 M2 1 alexandre.truong alexandre.truong meta.mr.watcher meta.watcher randy.macleod tim.orling vincent yoann.congal --- --- No (bug/feature does not impact docs) oldest_to_newest 98690 0 alexandre.truong 2024-04-04 14:20:30 +0000 devtool's submodule detection seems to check HEAD for sub-modules but not the version we're asking. Link to a patch to workaround this in the test-suite (test_devtool_add_git_style2) : https://lists.openembedded.org/g/openembedded-core/message/197961 In the test, the mbedtls repo is used and triggered this with this patch on the development branch (the main one): https://github.com/Mbed-TLS/mbedtls/commit/456a54da8ef44c8b725b524567c08cffec6a7214 The test asks for the 3.1.0 version which does not contain sub-modules. How to reproduce the problem: devtool add --version v3.1.0 mbedtls git://git@github.com/ARMmbed/mbedtls.git;protocol=https # We should have git://git@github.com/ARMmbed/mbedtls.git;protocol=https;branch=master we get gitsm://git@github.com/ARMmbed/mbedtls.git;protocol=https;branch=master 98749 1 vincent 2024-04-14 19:15:57 +0000 This is not an issue with devtool not setting the correct URI for a version, but the --version not being used for anything else but setting the "PV" value in the recipe. The version it will check out from git will be the same as if no version is specified. If I add mbedtls by doing: > devtool add --srcrev v3.1.0 mbedtls git://git@github.com/ARMmbed/mbedtls.git it checks out the correct tag and sets the SRC_URI as expected. > SRC_URI = "git://git@github.com/ARMmbed/mbedtls.git;protocol=ssh;branch=master" To fix this issue I ould change the command to set both the --srcrev and the --version: > devtool add --srcrev v3.1.0 --version v3.1.0 mbedtls git://git@github.com/ARMmbed/mbedtls.git 98923 2 alexandre.truong 2024-04-26 08:36:27 +0000 Patches sent: https://lists.openembedded.org/g/openembedded-core/topic/patch_2_2/105746806 https://lists.openembedded.org/g/openembedded-core/topic/patch_1_2_revert/105746807 98927 3 alexandre.truong 2024-04-26 10:17:33 +0000 Link to the v2 of the patches: https://lists.openembedded.org/g/openembedded-core/message/198719 https://lists.openembedded.org/g/openembedded-core/message/198720 99525 4 randy.macleod 2024-08-08 15:10:35 +0000 https://git.openembedded.org/openembedded-core/log/?qt=range&q=731f47ecfd8ad6558aac629806810789c623986b and follow commit. Thanks!