<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>15536</bug_id>
          
          <creation_ts>2024-06-30 22:22:07 +0000</creation_ts>
          <short_desc>When saving ptest artefacts for failed tests, recursive directories are being copied</short_desc>
          <delta_ts>2024-07-11 16:13:51 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>10</classification_id>
          <classification>QA/Testing</classification>
          <product>Package Testing (ptest)</product>
          <component>ptest</component>
          <version>unspecified</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>High</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>5.1 M3</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Richard Purdie">richard.purdie</reporter>
          <assigned_to name="Alexis Lothoré">alexis.lothore</assigned_to>
          <cc>alexandre.belloni</cc>
    
    <cc>alexis.lothore</cc>
    
    <cc>randy.macleod</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>99298</commentid>
    <comment_count>0</comment_count>
    <who name="Richard Purdie">richard.purdie</who>
    <bug_when>2024-06-30 22:22:07 +0000</bug_when>
    <thetext>We&apos;ve been seeing space issues on the autobuilder, sometimes with a lack of inodes.

Upon investigation, we found:

~/yocto-worker/qemux86-64-ptest/build/build/tmp/log/oeqa/artifacts

contained huge numbers of inodes (approx. 105063410 from du --inodes -s)

This was from a util-linux ptest failure which resulted in recursive directories of the form:

build/tmp/log/oeqa/artifacts/usr/lib/util-linux/ptest/tests/output/lsblk/dumps/simple-lvm/sys/block/loop0/holders/dm-0/slaves/loop0/holders/dm-0/slaves/loop0/holders/dm-0/slaves/loop0/holders/dm-0/slaves/loop0/holders

We need to make the artefact saving preserve symlinks and/or stop at a sensible depth.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>99308</commentid>
    <comment_count>1</comment_count>
    <who name="Alexis Lothoré">alexis.lothore</who>
    <bug_when>2024-07-02 14:04:28 +0000</bug_when>
    <thetext>I see two ways of fixing this without spawning an over-complicated solution evaluating each file to check if any is a symlink:
- create an archive with all the files we want to retrieve, and then scp/uncompress this archive
- switch to rsync

I kind of remember that there was constraints which prevented rsync usage for this use case, but I don&apos;t remember the details. I will check again and come up with a fix for this</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>99314</commentid>
    <comment_count>2</comment_count>
    <who name="Richard Purdie">richard.purdie</who>
    <bug_when>2024-07-03 17:19:02 +0000</bug_when>
    <thetext>(In reply to Alexis Lothoré from comment #1)
&gt; I see two ways of fixing this without spawning an over-complicated solution
&gt; evaluating each file to check if any is a symlink:
&gt; - create an archive with all the files we want to retrieve, and then
&gt; scp/uncompress this archive

I&apos;d worry that we don&apos;t have the space on target to be able to do this in many cases unfortunately.

&gt; - switch to rsync
&gt; 
&gt; I kind of remember that there was constraints which prevented rsync usage
&gt; for this use case, but I don&apos;t remember the details. I will check again and
&gt; come up with a fix for this

The issue with this one would be the requirement to have rsync in the target image which we can&apos;t always guarantee either.

There may be a third option which is to pipe tar over ssh since tar can handle symlinks and loops.

The rsync solution is probably most viable/easiest?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>99374</commentid>
    <comment_count>3</comment_count>
    <who name="Alexandre Belloni">alexandre.belloni</who>
    <bug_when>2024-07-11 16:13:51 +0000</bug_when>
    <thetext>https://git.yoctoproject.org/poky/commit/?id=6e80b2ab660e60135b52bd7358f0ce7612226f06</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>