15575 2024-08-08 18:15:45 +0000 test_mbox.TestMbox.test_shortlog_length needs to exclude branch specifiers 2024-09-03 13:24:49 +0000 1 1 6 Yocto Project Subprojects Patchwork/Patchtest Patchtest unspecified x86 Multiple RESOLVED FIXED Medium normal 5.1 1 reatmon tgamblin randy.macleod reatmon richard.purdie --- --- No (bug/feature does not impact docs) oldest_to_newest 99531 0 reatmon 2024-08-08 18:15:45 +0000 The test_mbox.TestMbox.test_shortlog_length check is not excluding the [master] or [master/scarthgap] branch specifier in the subject. For example: [OE-core][master/scarthgap][PATCH] u-boot.inc: Refactor do_* steps into functions that can be overridden Resulted in the failure: FAIL: test shortlog length: Edit shortlog so that it is 90 characters or less (currently 95 characters) (test_mbox.TestMbox.test_shortlog_length) But the same shortlog without the specifier passed. 99541 1 richard.purdie 2024-08-15 14:31:39 +0000 Anything in [] will not make the commit message so the test should probably exclude anything enclosed in those. 99591 2 tgamblin 2024-08-31 01:27:31 +0000 This is a little strange. I've got a local copy of that patch and I'm testing it with patchtest locally. That subject line is actually 104 characters, so not sure why it's counting 95. Coincidentally, removing "scarthgap" from it brings the count to 95, so maybe it's reading it with that stripped. When I try locally, with prints added: |SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) |PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format) |shortlog is [master/scarthgap][PATCH] u-boot.inc: Refactor do_* steps into functions that can be overridden |shortlog len is 95 |FAIL: test shortlog length: Edit shortlog so that it is 90 characters or less (currently 95 characters) (test_mbox.TestMbox.test_shortlog_length) So the "[OE-core]" is getting stripped, but the branch and PATCH tags aren't. A re.sub() call should fix this. 99592 3 tgamblin 2024-08-31 13:25:14 +0000 Patch up for review: https://lists.openembedded.org/g/openembedded-core/message/203972 99603 4 tgamblin 2024-09-03 13:24:49 +0000 See: https://git.openembedded.org/openembedded-core/commit/?id=6e1ddadfe779291cf46fb88fb01769c022b733ac