15601 2024-09-25 00:54:39 +0000 The image_qa task hides unexpected exceptions 2025-01-07 21:16:48 +0000 1 1 7 Build System, Metadata & Runtime OE-Core core 5.1 x86 Multiple RESOLVED FIXED Medium+ normal 5.2 M1 1 peter.kjellerstedt peter.kjellerstedt meta.mr.watcher meta.watcher randy.macleod ross.burton --- --- No (bug/feature does not impact docs) oldest_to_newest 99712 0 peter.kjellerstedt 2024-09-25 00:54:39 +0000 After commit 905e224849fbbed1719e0add231b00e2d570b3b4 (image_qa: fix error handling), any unexpected exceptions in do_image_qa() would result in a variable being set, but never used, effectively hiding the error. For Styhead, my recommendation is to just remove the catch of Exception and just let any unexpected exceptions pass on up. For master I instead recommend that we remove the use of the ImageQAFailed exception (and all exception handling in do_image_qa), and instead rely on the called functions to call oe.qa.handle_error() themselves. This matches what do_package_qa() does. 99736 1 ross.burton 2024-09-26 15:58:34 +0000 Peter has sent patches. 100549 2 peter.kjellerstedt 2025-01-07 21:16:48 +0000 This was solved in commit 0c3e111c965af2bc56533633c376b70b7fa5e1de for master, and commit c00ad42b6a26ceb7a2878ed2c7f6c2821fe513cc for Styhead.