15635 2024-10-28 15:23:14 +0000 Automake patch "Set relative to top_builddir path in Makefile to access" breaks "make check" 2024-11-14 16:21:11 +0000 1 1 7 Build System, Metadata & Runtime OE-Core devtools / tool chain 5.1 x86 Multiple RESOLVED FIXED Medium normal 5.2 1 ola.x.nilsson ola.x.nilsson meta.mr.watcher meta.watcher randy.macleod --- --- Yes (doc changes required) oldest_to_newest 100048 0 5078 ola.x.nilsson 2024-10-28 15:23:14 +0000 Created attachment 5078 [PATCH] automake: Fix bad path to test-driver The automake patch "Set relative to top_builddir path in Makefile to access" sets the default path of `test-driver` to `$(top_builddir)/$(config_aux_dir)` instead of the normal `$(top_srcdir)/$(config_aux_dir)`. This breaks `check test` for Automake projects in generated images. To reproduce, use core-image-kernel-dev with git added. git clone https://git.kernel.org/pub/scm/linux/kernel/git/kay/libabc.git (cd libabc && ./autogen.sh) mkdir build cd build ../libabc/configure CFLAGS='-g -O0' --prefix=/usr --sysconfdir=/etc --libdir=/usr/lib make check /bin/sh: ./build-aux/test-driver: No such file or directory Removing the patch makes the checks complete successfully. The patch should be removed to ensure proper automake behaviour, but that will break some ptests. For instance ptests for attr fail with BEGIN: /usr/lib/attr/ptest /bin/bash: ../attr-2.5.2/build-aux/test-driver: No such file or directory make: *** [Makefile:1502: test/attr.log] Error 127 The attached patch makes automake work in both scenarios, but the proper solution is still to fix the tests and remove the patch. 100056 1 ola.x.nilsson 2024-10-29 14:33:19 +0000 Turns out ptest only broke for these recipes in oe-core when the patch was removed: * acl * attr * parted * sed * strace They were all easy to fix. 100066 2 randy.macleod 2024-10-31 14:38:32 +0000 Clearly we want to keep ptests working. Can you send patches for automake as well as the list of broken ptests? Did you also test meta-oe? 100100 3 ola.x.nilsson 2024-11-04 14:29:27 +0000 If we agree that the automake patch should be removed, I can provide patches for the recipes I had to fix ptest for. I have not looked at PTEST_PROBLEMATIC in oe-core yet. I intend to look at the ptests in meta-openembedded, haven't gotten very far yet. 100128 4 randy.macleod 2024-11-07 16:00:40 +0000 Ola, The triage team discussed and we think the discussion needs to happen on the email list. Can you get the ball rolling with an RFC patch and/or join the YP tech call on Tuesday perhaps. 100129 5 ola.x.nilsson 2024-11-07 16:24:10 +0000 Sure, I'll send what I have so far. 100168 6 randy.macleod 2024-11-14 16:21:11 +0000 merged to master: https://git.openembedded.org/openembedded-core/commit/?id=d21dbafda92263d3e30a5b7d84dd9bb02f855610 Thanks Ola! 5078 2024-10-28 15:23:14 +0000 2024-10-28 15:23:14 +0000 [PATCH] automake: Fix bad path to test-driver 0001-automake-Fix-bad-path-to-test-driver.patch text/plain 2610 ola.x.nilsson RnJvbSA0M2M5N2I1ZmM3MGM2NmU1ZjE3YTM0ZWJiMWExZGIwNzA0MDc1YTQxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBPbGEgeCBOaWxzc29uIDxvbGFuaUBheGlzLmNvbT4KRGF0ZTog RnJpLCAyNSBPY3QgMjAyNCAxNTowNjoyMSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIGF1dG9tYWtl OiBGaXggYmFkIHBhdGggdG8gdGVzdC1kcml2ZXIKClRoZSBhdXRvbWFrZSBwYXRjaAoiU2V0IHJl bGF0aXZlIHRvIHRvcF9idWlsZGRpciBwYXRoIGluIE1ha2VmaWxlIHRvIGFjY2VzcyB0ZXN0LWRy aXZlciIKY2FycmllZCBieSBPRSBtYXkgYmUgaGVscGZ1bCBpbiB0aGUgcHRlc3QgY2FzZSwgYnV0 IGl0IGJyZWFrcyBub3JtYWwKb3V0IG9mIHRyZWUgYnVpbGRzLgoKUmVtb3ZpbmcgdGhlIHBhdGNo IGlzIG5vdCBhbiBhbHRlcm5hdGl2ZSBhcyB0aGF0IHdpbGwgcHJvYmFibHkgYnJlYWsKcHRlc3Rz IGZvciBhbGwgYXV0b21ha2UgYmFzZWQgcGFja2FnZXMuCgpJbnN0ZWFkIGNoYW5nZSB0aGUgc2V0 dGluZyBvZiBMT0dfRFJJVkVSIHRvIHVzZQoxKSB0aGUgT0Ugc3RhbmRhcmQgZm9yIHRlc3QtZHJp dmVyIGluIHRvcF9idWlsZGRpciBpZiBpdCBleGlzdHMKMikgdGhlIGF1dG9tYWtlIHN0YW5kYXJk IGZvciB0ZXN0LWRyaXZlciBpbiB0b3BzcmNkaXIgaWYgaXQgZXhpc3RzCjMpIHRoZSBPRSBzdGFu ZGFyZCBldmVuIGlmIGl0IGRvZXMgbm90IGV4aXN0CgpUaGlzIHNob3VsZCBtYWtlIGl0IHBvc3Np YmxlIHRvIGJ1aWxkIGF1dG9tYWtlIHN0YW5kYXJkIHN0dWZmIHdoaWxlCnByZXNlcnZpbmcgdGhl IHB0ZXN0IGJlaGF2aW91ciBhbmQgaGF2ZSB0aGUgc2FtZSBlcnJvciBtZXNzYWdlIGFzCmJlZm9y ZSBpZiBuZWl0aGVyIGV4aXN0cy4KClRoZSBzb2x1dGlvbiBpcyBwcm9iYWJseSBvbmx5IEdOVSBt YWtlIGNvbXBhdGlibGUsIGJ1dCB0aGF0IHNob3VsZCBub3QKYmUgYSBwcm9ibGVtIGZvciBZb2N0 by4KClVuZm9ydHVuYXRlbHkgdGhlIG5ldyBHTlUtbWFrZSBzcGVjaWZpYyB2YWx1ZSBvZiBMT0df RFJJVkVSIHdpbGwgbm90CnBhc3MgaW50ZXJuYWwgYXV0b21ha2UgY29tcGxpYW5jZSB0ZXN0cyBp bgpBdXRvbWFrZTo6VmFyaWFibGU6OmNoZWNrX3ZhcmlhYmxlX2V4cGFuc2lvbnMsIHNvIGFkZCBh IHNwZWNpZmljCmV4Y2VwdGlvbiB0aGVyZS4KClVwc3RyZWFtLVN0YXR1czogSW5hcHByb3ByaWF0 ZSBbRml4IGZvciBPRS1zcGVjaWZpYyBwYXRjaF0KU2lnbmVkLW9mZi1ieTogT2xhIHggTmlsc3Nv biA8b2xhbmlAYXhpcy5jb20+Ci0tLQogYmluL2F1dG9tYWtlLmluICAgICAgICAgIHwgMiArLQog bGliL0F1dG9tYWtlL1ZhcmlhYmxlLnBtIHwgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvYmluL2F1dG9tYWtlLmluIGIv YmluL2F1dG9tYWtlLmluCmluZGV4IDNhYTg3MDYuLjNiNWExYWYgMTAwNjQ0Ci0tLSBhL2Jpbi9h dXRvbWFrZS5pbgorKysgYi9iaW4vYXV0b21ha2UuaW4KQEAgLTQ5MjAsNyArNDkyMCw3IEBAIHN1 YiBoYW5kbGVfcGVyX3N1ZmZpeF90ZXN0CiAgICAgewogICAgICAgcmVxdWlyZV9jb25mX2ZpbGUg KCJwYXJhbGxlbC10ZXN0cyIsIEZPUkVJR04sICd0ZXN0LWRyaXZlcicpOwogICAgICAgZGVmaW5l X3ZhcmlhYmxlICgiJHtwZnh9TE9HX0RSSVZFUiIsCi0gICAgICAgICAgICAgICAgICAgICAgICJc JChTSEVMTCkgJGFtX2NvbmZpZ19ydF9hdXhfZGlyL3Rlc3QtZHJpdmVyIiwKKyAgICAgICAgICAg ICAgICAgICAgICAgIlwkKFNIRUxMKSBcJChmaXJzdHdvcmQgXCQod2lsZGNhcmQgJGFtX2NvbmZp Z19ydF9hdXhfZGlyL3Rlc3QtZHJpdmVyICRhbV9jb25maWdfYXV4X2Rpci90ZXN0LWRyaXZlcikg JGFtX2NvbmZpZ19ydF9hdXhfZGlyL3Rlc3QtZHJpdmVyKSIsCiAgICAgICAgICAgICAgICAgICAg ICAgIElOVEVSTkFMKTsKICAgICB9CiAgIG15ICRkcml2ZXIgPSAnJCgnIC4gJHBmeCAuICdMT0df RFJJVkVSKSc7CmRpZmYgLS1naXQgYS9saWIvQXV0b21ha2UvVmFyaWFibGUucG0gYi9saWIvQXV0 b21ha2UvVmFyaWFibGUucG0KaW5kZXggOWMwMDRmNS4uOTZjNTc0YyAxMDA2NDQKLS0tIGEvbGli L0F1dG9tYWtlL1ZhcmlhYmxlLnBtCisrKyBiL2xpYi9BdXRvbWFrZS9WYXJpYWJsZS5wbQpAQCAt Nzc5LDcgKzc3OSw3IEBAIHN1YiBjaGVja192YXJpYWJsZV9leHBhbnNpb25zICgkJCkKICAgIyBD YXRjaCBleHBhbnNpb24gb2YgdmFyaWFibGVzIHdob3NlIG5hbWUgZG9lcyBub3QgY29uZm9ybSB0 byBQT1NJWC4KICAgZm9yZWFjaCBteSAkdmFyIChzY2FuX3ZhcmlhYmxlX2V4cGFuc2lvbnMgKCR0 ZXh0KSkKICAgICB7Ci0gICAgICBpZiAoJHZhciAhfiAvJF9WQVJJQUJMRV9QQVRURVJOL28pCisg ICAgICBpZiAoJHZhciAhfiAvJF9WQVJJQUJMRV9QQVRURVJOL28gJiYgJHZhciAhfiAvXmZpcnN0 d29yZCBcJFwod2lsZGNhcmQgXCRcKHRvcF9idWlsZGRpci8pCiAJewogCSAgIyBJZiB0aGUgdmFy aWFibGUgbmFtZSBjb250YWlucyBhIHNwYWNlLCBpdCdzIGxpa2VseQogCSAgIyB0byBiZSBhIEdO VSBtYWtlIGV4dGVuc2lvbiAoc3VjaCBhcyAkKGFkZHN1ZmZpeCAuLi4pKS4K