15685 2024-12-09 10:32:38 +0000 ??= behaves as = for variable flags 2025-02-18 10:10:09 +0000 1 1 7 Build System, Metadata & Runtime BitBake bitbake unspecified x86 Multiple RESOLVED FIXED Medium+ normal 5.2 M3 1 ola.x.nilsson louis.rannou louis.rannou louis.rannou poky.bs.watcher poky.watcher randy.macleod richard.purdie yoann.congal --- --- Don't know oldest_to_newest 100387 0 ola.x.nilsson 2024-12-09 10:32:38 +0000 VARIABLE[flag] ??= "value" behaves as VARIABLE[flag] = "value" while the docs say that "All the standard syntax operations previously mentioned work for variable flags except for override style syntax". I _think_ it's because in DataNode::eval flag = None if 'flag' in groupd and groupd['flag'] is not None: flag = groupd['flag'] elif groupd["lazyques"]: flag = "_defaultval" will leave op = "set" even if groupd['op'] == 'lazyques'. But I can't find the code that cares about op, so I could be wrong. If ??= is not supported for flag assignments, we should at least get an error. 100392 1 richard.purdie 2024-12-09 17:49:46 +0000 I think this is a bug and ??= should work for flags as expected. We should probably add a test case to lib/bb/tests/ and then fix the code, you're probably on the right track with the code fix but I need to look in more detail. The test case will help test before/after the fix. 100423 2 randy.macleod 2024-12-12 15:40:20 +0000 Should fix but not urgent. Yoann will work on this next year! 100599 3 yoann.congal 2025-01-09 23:00:16 +0000 Reproducer: #local.conf: TEST = "good value" TEST ??= "bad value" TEST[flag] = "good flag" TEST[flag] ??= "bad flag" Then: $ bitbake-getvar TEST ; echo -n "TEST[flag] = " ; bitbake-getvar TEST -f flag --value # # $TEST [4 operations] # set /home/yocon/Documents/projets/yocto/poky_bb_intero_flag/build/conf/local.conf:291 # "good value" # set /home/yocon/Documents/projets/yocto/poky_bb_intero_flag/build/conf/local.conf:292 # [_defaultval] "bad value" # set /home/yocon/Documents/projets/yocto/poky_bb_intero_flag/build/conf/local.conf:293 # [flag] "good flag" # set /home/yocon/Documents/projets/yocto/poky_bb_intero_flag/build/conf/local.conf:294 # [flag] "bad flag" # pre-expansion value: # "good value" TEST="good value" TEST[flag] =bad flag ^ this should display "good flag" (like it does for "good value") 100605 4 yoann.congal 2025-01-10 19:11:37 +0000 Patch v1 sent: bitbake-devel@lists.openembedded.org | [PATCH 1/2] tests/parse: add test for ?= and ??= operators for variable flags https://lists.openembedded.org/g/bitbake-devel/topic/patch_1_2_tests_parse_add/110541105 bitbake-devel@lists.openembedded.org | [PATCH 2/2] data_smart: fix ??= operator for variable flags https://lists.openembedded.org/g/bitbake-devel/topic/patch_2_2_data_smart_fix/110541106 100609 5 yoann.congal 2025-01-10 23:01:37 +0000 Patch v2: bitbake-devel@lists.openembedded.org | [PATCH v2 1/2] tests/parse: add test for ?= and ??= operators for variable flags https://lists.openembedded.org/g/bitbake-devel/topic/patch_v2_1_2_tests_parse/110545216 bitbake-devel@lists.openembedded.org | [PATCH v2 2/2] data_smart: fix ??= operator for variable flags https://lists.openembedded.org/g/bitbake-devel/topic/patch_v2_2_2_data_smart/110545217 100657 6 yoann.congal 2025-01-15 23:01:58 +0000 Merged: tests/parse: add test for ?= and ??= operators for variable flags - bitbake - Bitbake Development tree https://git.openembedded.org/bitbake/commit/?id=d12c80125d810df54379cc4f019a95ab9064ad2c data_smart: fix ??= operator for variable flags - bitbake - Bitbake Development tree https://git.openembedded.org/bitbake/commit/?id=0329a7e3ac694737f2d2c1861f65492551360663 100896 7 5096 yoann.congal 2025-02-11 17:10:38 +0000 Created attachment 5096 Failing test case for getVarFlags() 100897 8 yoann.congal 2025-02-11 17:14:00 +0000 Louis Rannou found a bug with the current fix: * default varflags are excluded from d.getVarFlags() dict but should be (at least I would expect it) * https://bugzilla.yoctoproject.org/attachment.cgi?id=5096 attached patch to trigger the bug * Simpler version: In the current testcase: self.assertTrue("flag_default" in d.getVarFlags("A")) 100898 9 yoann.congal 2025-02-11 18:00:43 +0000 I guess we need to act on "_defaultval_flag_*" variables in getVarFlags() instead of skipping them currently: https://git.openembedded.org/bitbake/tree/lib/bb/data_smart.py?id=93059aad13a12cd69d86368795c88e5349197d5d#n952 100899 10 richard.purdie 2025-02-11 22:30:57 +0000 you may need to pass internalflags=True to getVarFlags()? 100915 11 louis.rannou 2025-02-13 13:46:35 +0000 Hello, I'm quite ready for a v2 patch but I'm having some incoherences. First of all, I found that calling delVar("A") will blow out all flags. Is that expected ? Perhaps we can have an extra argument to say if we want flags to be deleted or not. Second, delVarFlag("A", "flag1") will erase the flag1 but not its weak default. I suppose the default must be removed too ? 100939 12 yoann.congal 2025-02-13 16:01:28 +0000 Louis sent a v2: [PATCH v2 0/2] bitbake: fix ??= operator for variable flags and test https://lists.openembedded.org/g/bitbake-devel/topic/patch_v2_0_2_bitbake_fix/111163809 [PATCH v2 1/2] bitbake: data_smart: fix ??= operator for variable flags https://lists.openembedded.org/g/bitbake-devel/topic/patch_v2_1_2_bitbake/111163810 [PATCH v2 2/2] bitbake: tests/data: add tests for variable flags https://lists.openembedded.org/g/bitbake-devel/topic/patch_v2_2_2_bitbake/111163811 101131 13 louis.rannou 2025-02-18 09:03:35 +0000 Merged: bitbake: data_smart: fix ??= operator for variable flags https://git.openembedded.org/bitbake/commit?id=2ee079fc1b7cf6d384ca17bd034b0a40461d9d18 bitbake: tests/data: add tests for variable flags https://git.openembedded.org/bitbake/commit?id=ff8cae735cf489373af1aac7ee233d7b82d483d3 101132 14 louis.rannou 2025-02-18 09:04:39 +0000 Closing, but reoppen if delVar is not supposed to erase all variable flags 101135 15 richard.purdie 2025-02-18 10:10:09 +0000 I did mean to comment, delVar is supposed to remove all varflags so that behaviour is correct, thanks! 5096 2025-02-11 17:10:38 +0000 2025-02-11 17:10:38 +0000 Failing test case for getVarFlags() 0001-bitbake-tests-parse-add-test-for-getVarFlags.patch text/plain 3198 yoann.congal RnJvbSAyNzFjODc0NTYzZjdkZjI4NDk4ZGVmY2VmZjZlZGRhNjgyYWRjMmY4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMb3VpcyBSYW5ub3UgPGxvdWlzLnJhbm5vdUBub24uc2UuY29t PgpEYXRlOiBUdWUsIDExIEZlYiAyMDI1IDE2OjI0OjAzICswMTAwClN1YmplY3Q6IFtQQVRDSF0g Yml0YmFrZTogdGVzdHMvcGFyc2U6IGFkZCB0ZXN0IGZvciBnZXRWYXJGbGFncwoKUnVuIHRoZSB0 ZXN0IHdpdGg6CiAgICAkIGJpdGJha2Utc2VsZnRlc3QgYmIudGVzdHMucGFyc2UuUGFyc2VUZXN0 LnRlc3RfcGFyc2VfZGVmYXVsdHRlc3QKICAgIEYKICAgID09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KICAgIEZBSUw6 IHRlc3RfcGFyc2VfZGVmYXVsdHRlc3QgKGJiLnRlc3RzLnBhcnNlLlBhcnNlVGVzdC50ZXN0X3Bh cnNlX2RlZmF1bHR0ZXN0KQogICAgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogICAgVHJhY2ViYWNrIChtb3N0IHJl Y2VudCBjYWxsIGxhc3QpOgogICAgICBGaWxlICIvaG9tZS9sb3Vpcy9wb2t5Mi9iaXRiYWtlL2xp Yi9iYi90ZXN0cy9wYXJzZS5weSIsIGxpbmUgMTMwLCBpbiB0ZXN0X3BhcnNlX2RlZmF1bHR0ZXN0 CiAgICAgICAgc2VsZi5hc3NlcnREaWN0RXF1YWwoCiAgICBBc3NlcnRpb25FcnJvcjogeydmbGFb MTAyIGNoYXJzXWZsYWdfcXVlc3Rpb25fdnNfZGVmYXVsdCc6ICdxdWVzdGlvbiBmbGFnJywgJ2Zb MjAyIGNoYXJzXXJzdCd9ICE9IHsnZmxhWzEwMiBjaGFyc11mbGFnX2RlZmF1bHQnOiAnZGVmYXVs dCBmbGFnJywgJ2ZsYWdfcXVlc3Rpb25fWzI3OSBjaGFyc11vbmQnfQogICAgKyB7J2ZsYWdfZGVm YXVsdCc6ICdkZWZhdWx0IGZsYWcnLAogICAgKyAgJ2ZsYWdfZGVmYXVsdF90d2ljZSc6ICdkZWZh dWx0IGZsYWcgc2Vjb25kJywKICAgIC0geydmbGFnX2RlZmF1bHRfdnNfcXVlc3Rpb24nOiAncXVl c3Rpb24gZmxhZycsCiAgICA/IF4KCiAgICArICAnZmxhZ19kZWZhdWx0X3ZzX3F1ZXN0aW9uJzog J3F1ZXN0aW9uIGZsYWcnLAogICAgPyBeCgogICAgICAgJ2ZsYWdfcXVlc3Rpb24nOiAncXVlc3Rp b24gZmxhZycsCiAgICAgICAnZmxhZ19xdWVzdGlvbl90d2ljZSc6ICdxdWVzdGlvbiBmbGFnIGZp cnN0JywKICAgICAgICdmbGFnX3F1ZXN0aW9uX3ZzX2RlZmF1bHQnOiAncXVlc3Rpb24gZmxhZycs CiAgICAgICAnZmxhZ19zZXRfZGVmYXVsdF9xdWVzdGlvbic6ICdzZXQgZmxhZycsCiAgICAgICAn ZmxhZ19zZXRfcXVlc3Rpb25fZGVmYXVsdCc6ICdzZXQgZmxhZycsCiAgICAgICAnZmxhZ19zZXRf dHdpY2UnOiAnc2V0IGZsYWcgc2Vjb25kJywKICAgICAgICdmbGFnX3NldF92c19kZWZhdWx0Jzog J3NldCBmbGFnJywKICAgICAgICdmbGFnX3NldF92c19xdWVzdGlvbic6ICdzZXQgZmxhZyd9Cgog ICAgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLQogICAgUmFuIDEgdGVzdCBpbiAwLjAwMXMKCiAgICBGQUlMRUQgKGZh aWx1cmVzPTEpCgpXZWFrIHZhbHVlcyBhcmUgb21pdHRlZC4gVGhpcyBiZWhhdmlvdXIgaGFzIGNo YW5nZWQgd2l0aCAwNTI3NDZkYTlhN2U5NmI0M2VjNDVhMDQzMjJlODU3NmE2Y2JhYWI3LiBCZWZv cmUgdGhhdCwgd2VhayB2YWx1ZXMgd2VyZSBub3Qgb21pdHRlZCAoYnV0IGluY29ycmVjdCkuCgpT aWduZWQtb2ZmLWJ5OiBMb3VpcyBSYW5ub3UgPGxvdWlzLnJhbm5vdUBub24uc2UuY29tPgotLS0K IGJpdGJha2UvbGliL2JiL3Rlc3RzL3BhcnNlLnB5IHwgMTYgKysrKysrKysrKysrKysrKwogMSBm aWxlIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9iaXRiYWtlL2xpYi9i Yi90ZXN0cy9wYXJzZS5weSBiL2JpdGJha2UvbGliL2JiL3Rlc3RzL3BhcnNlLnB5CmluZGV4IGUz Y2JhNjdhZDQuLjc0YTZjNTRhZDEgMTAwNjQ0Ci0tLSBhL2JpdGJha2UvbGliL2JiL3Rlc3RzL3Bh cnNlLnB5CisrKyBiL2JpdGJha2UvbGliL2JiL3Rlc3RzL3BhcnNlLnB5CkBAIC0xMjcsNiArMTI3 LDIyIEBAIEFbZmxhZ19kZWZhdWx0X3R3aWNlXSA/Pz0gImRlZmF1bHQgZmxhZyBzZWNvbmQiCiAg ICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoZC5nZXRWYXJGbGFnKCJBIiwiZmxhZ19zZXRfdHdpY2Ui KSwgInNldCBmbGFnIHNlY29uZCIpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoZC5nZXRWYXJG bGFnKCJBIiwiZmxhZ19xdWVzdGlvbl90d2ljZSIpLCAicXVlc3Rpb24gZmxhZyBmaXJzdCIpCiAg ICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoZC5nZXRWYXJGbGFnKCJBIiwiZmxhZ19kZWZhdWx0X3R3 aWNlIiksICJkZWZhdWx0IGZsYWcgc2Vjb25kIikKKyAgICAgICAgc2VsZi5hc3NlcnREaWN0RXF1 YWwoCisgICAgICAgICAgICBkLmdldFZhckZsYWdzKCJBIiksCisgICAgICAgICAgICB7CisgICAg ICAgICAgICAgICAgImZsYWdfc2V0X3ZzX3F1ZXN0aW9uIjogInNldCBmbGFnIiwKKyAgICAgICAg ICAgICAgICAiZmxhZ19zZXRfdnNfZGVmYXVsdCI6ICJzZXQgZmxhZyIsCisgICAgICAgICAgICAg ICAgImZsYWdfcXVlc3Rpb24iOiAicXVlc3Rpb24gZmxhZyIsCisgICAgICAgICAgICAgICAgImZs YWdfZGVmYXVsdCI6ICJkZWZhdWx0IGZsYWciLAorICAgICAgICAgICAgICAgICJmbGFnX3F1ZXN0 aW9uX3ZzX2RlZmF1bHQiOiAicXVlc3Rpb24gZmxhZyIsCisgICAgICAgICAgICAgICAgImZsYWdf ZGVmYXVsdF92c19xdWVzdGlvbiI6ICJxdWVzdGlvbiBmbGFnIiwKKyAgICAgICAgICAgICAgICAi ZmxhZ19zZXRfcXVlc3Rpb25fZGVmYXVsdCI6ICJzZXQgZmxhZyIsCisgICAgICAgICAgICAgICAg ImZsYWdfc2V0X2RlZmF1bHRfcXVlc3Rpb24iOiAic2V0IGZsYWciLAorICAgICAgICAgICAgICAg ICJmbGFnX3NldF90d2ljZSI6ICJzZXQgZmxhZyBzZWNvbmQiLAorICAgICAgICAgICAgICAgICJm bGFnX3F1ZXN0aW9uX3R3aWNlIjogInF1ZXN0aW9uIGZsYWcgZmlyc3QiLAorICAgICAgICAgICAg ICAgICJmbGFnX2RlZmF1bHRfdHdpY2UiOiAiZGVmYXVsdCBmbGFnIHNlY29uZCIsCisgICAgICAg ICAgICB9CisgICAgICAgICkKIAogICAgIGV4cG9ydHRlc3QgPSAiIiIKIEEgPSAiYSIKLS0gCjIu NDMuMAoK