<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>15731</bug_id>
          
          <creation_ts>2025-01-29 08:14:30 +0000</creation_ts>
          <short_desc>cml1.bbclass: Invalid shell syntax in line 61: &quot;\\$?&quot;</short_desc>
          <delta_ts>2025-04-01 20:34:05 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>oe-core other</component>
          <version>5.0.6</version>
          <rep_platform>x86</rep_platform>
          <op_sys>x86_64</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>Future</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sven Kalmbach">Sven.Kalmbach</reporter>
          <assigned_to name="Sven Kalmbach">Sven.Kalmbach</assigned_to>
          <cc>christoph.vogtlaender</cc>
    
    <cc>randy.macleod</cc>
    
    <cc>yoann.congal</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>100761</commentid>
    <comment_count>0</comment_count>
    <who name="Sven Kalmbach">Sven.Kalmbach</who>
    <bug_when>2025-01-29 08:14:30 +0000</bug_when>
    <thetext>Lines 61-62 of cml1.bbclass contains:
&gt; oe_terminal(&quot;sh -c &apos;make %s; if [ \\$? -ne 0 ]; then ...
Escaping $? is wrong in this context, as it&apos;s already escaped by the quotes.
This causes the error handling logic not to run if make fails. The double backslash can be removed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>100775</commentid>
    <comment_count>1</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2025-01-30 15:42:15 +0000</bug_when>
    <thetext>Sven can you send a patch to the list?

If so, see: https://docs.yoctoproject.org/contributor-guide/index.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>100842</commentid>
    <comment_count>2</comment_count>
    <who name="Sven Kalmbach">Sven.Kalmbach</who>
    <bug_when>2025-02-05 07:34:07 +0000</bug_when>
    <thetext>(In reply to Randy MacLeod from comment #1)
&gt; Sven can you send a patch to the list?
&gt; 
&gt; If so, see: https://docs.yoctoproject.org/contributor-guide/index.html

I&apos;ll check out the guide, if I find the time :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>100864</commentid>
    <comment_count>3</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2025-02-06 15:50:05 +0000</bug_when>
    <thetext>Hoping the Sven can find the time.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>100905</commentid>
    <comment_count>4</comment_count>
    <who name="Sven Kalmbach">Sven.Kalmbach</who>
    <bug_when>2025-02-12 14:55:36 +0000</bug_when>
    <thetext>(In reply to Randy MacLeod from comment #3)
&gt; Hoping the Sven can find the time.

I found the time (https://lists.openembedded.org/g/openembedded-core/topic/patch_fixes_yocto_15731/111143606). I hope the patch is formatted well enough, since I can not use git send-email.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>101538</commentid>
    <comment_count>5</comment_count>
    <who name="Sven Kalmbach">Sven.Kalmbach</who>
    <bug_when>2025-04-01 06:40:57 +0000</bug_when>
    <thetext>I&apos;ve implemented the fix since last time and sent a (well-formated) patch to the mailing list (https://lists.openembedded.org/g/openembedded-core/message/211948)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>101543</commentid>
    <comment_count>6</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2025-04-01 20:34:05 +0000</bug_when>
    <thetext>Thanks Sven, it&apos;s merged to master and walnascar:

https://git.openembedded.org/openembedded-core/commit/?id=5c44a9154f0cd4252d4840d836e6936393b5d3a3

❯ git branch -a --contains 5c44a9154f0cd4252d4840d836e6936393b5d3a3
* master
  remotes/origin/HEAD -&gt; origin/master
  remotes/origin/master
  remotes/origin/master-next
  remotes/origin/walnascar</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>