<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>15763</bug_id>
          
          <creation_ts>2025-02-16 11:15:16 +0000</creation_ts>
          <short_desc>GO_IMPORT missing sanity check</short_desc>
          <delta_ts>2025-03-04 12:47:41 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>core</component>
          <version>unspecified</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard>NEWCOMER</status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>5.99</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>kweihmann</reporter>
          <assigned_to name="Christos Gavros">gavrosc</assigned_to>
          <cc>gavrosc</cc>
    
    <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
    
    <cc>randy.macleod</cc>
    
    <cc>richard.purdie</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>101102</commentid>
    <comment_count>0</comment_count>
    <who name="">kweihmann</who>
    <bug_when>2025-02-16 11:15:16 +0000</bug_when>
    <thetext>GO_IMPORT referenced by at least go-mod and go class, doesn&apos;t come with any default value.
There&apos;s also no sanity check in case the currently undefined variable is not set at all</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>101113</commentid>
    <comment_count>1</comment_count>
    <who name="Richard Purdie">richard.purdie</who>
    <bug_when>2025-02-17 12:51:19 +0000</bug_when>
    <thetext>As per several other bugs opened of this type, we are not adding default values for the sake of it.

For the sanity check, a patch would be welcome.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>101226</commentid>
    <comment_count>2</comment_count>
    <who name="Christos Gavros">gavrosc</who>
    <bug_when>2025-02-25 14:28:51 +0000</bug_when>
    <thetext>hi Richard

I can send a patch for sanity check for this. Couple of questions:

- in case sanity check fails, shall we generate a warning or abort building?
- shall we check in every build ? 

Br
Christos</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>101227</commentid>
    <comment_count>3</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2025-02-25 15:24:33 +0000</bug_when>
    <thetext>Christos,

Richard may not reply so I will.

Start with making it an error and send the patch to get feedback.

Do any go-based recipes currently not set this variable?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>101228</commentid>
    <comment_count>4</comment_count>
    <who name="Christos Gavros">gavrosc</who>
    <bug_when>2025-02-25 15:31:29 +0000</bug_when>
    <thetext>Hi Randy

I am not in a hurry :)!

Its assigned only in go-helloworld_0.1.bb as an example as far as I can see!

That&apos;s why I asked if we make it only warning!

I will do as you said!

Br
Christos</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>101229</commentid>
    <comment_count>5</comment_count>
    <who name="Christos Gavros">gavrosc</who>
    <bug_when>2025-02-25 18:12:47 +0000</bug_when>
    <thetext>hi

I send a patch! Testing with poky is generating error and aborting the build.
If I assign a value in local.conf then is ok.

https://lists.openembedded.org/g/openembedded-core/topic/patch_sanity_check/111381998</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>101275</commentid>
    <comment_count>6</comment_count>
    <who name="Christos Gavros">gavrosc</who>
    <bug_when>2025-03-04 12:41:10 +0000</bug_when>
    <thetext>The patch is merged in the master:

https://git.openembedded.org/openembedded-core/commit/?id=374a91204bdaf44067f6b0ae89ed60934751efaa</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>101276</commentid>
    <comment_count>7</comment_count>
    <who name="">kweihmann</who>
    <bug_when>2025-03-04 12:47:41 +0000</bug_when>
    <thetext>@Christos Gavros - very nice solution - really like it - thanks for the patch</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>