15947 2025-08-05 09:15:25 +0000 WIC does not preserve metadata when updating fstab 2026-08-04 14:42:42 +0000 1 1 6 Yocto Project Subprojects Wic wic v0.3.0 All Multiple ACCEPTED Medium major v0.4.0 1 daniel.andrade twoerner ccasciato daniele.romano hongxu.jia randy.macleod ross.burton twoerner --- --- No (bug/feature does not impact docs) oldest_to_newest 102544 0 daniel.andrade 2025-08-05 09:15:25 +0000 The functionality to update fstab generates a new temporary fstab with the new partition configuration. However, this file does not retain any metadata being it a completely new file. Because of this, when the rootfs plugin under `poky/scripts/lib/wic/plugins/source/rootfs.py` copies the file, it overrides the original metadata of it. 73 @classmethod 74 def do_prepare_partition(cls, part, source_params, cr, cr_workdir, 75 oe_builddir, bootimg_dir, kernel_dir, 76 krootfs_dir, native_sysroot): ... 224 if part.update_fstab_in_rootfs and part.has_fstab and not part.no_fstab_update: 225 fstab_path = os.path.join(new_rootfs, "etc/fstab") 226 # Assume that fstab should always be owned by root with fixed permissions 227 install_cmd = "install -m 0644 -p %s %s" % (part.updated_fstab_path, fstab_path) 228 if new_pseudo: 229 pseudo = cls.__get_pseudo(native_sysroot, new_rootfs, new_pseudo) 230 else: 231 pseudo = None 232 exec_native_cmd(install_cmd, native_sysroot, pseudo) A dirty fix was changing the install_cmd line to `"cat %s > %s" % (part.updated_fstab_path, fstab_path)`. However, the reason to reach this stage was that the fstype used was squashfs, because, if it is ext* or vfat, it is handled in a different location instead of here, where this fix is not doable. In `partition.py` under `poky/scripts/lib/wic/partition.py`, the original fstab is explicitly deleted, losing track of all xattrs and later it copies the temporary one into the image. By using debugfs, the "dirty fix" previously mentioned is not doable 298 if self.updated_fstab_path and self.has_fstab and not self.no_fstab_update: 299 debugfs_script_path = os.path.join(cr_workdir, "debugfs_script") 300 with open(debugfs_script_path, "w") as f: 301 f.write("cd etc\n") 302 f.write("rm fstab\n") 303 f.write("write %s fstab\n" % (self.updated_fstab_path)) 304 debugfs_cmd = "debugfs -w -f %s %s" % (debugfs_script_path, rootfs) 305 exec_native_cmd(debugfs_cmd, native_sysroot) Fixing Solution: This fstab update should be delegated to one class, in this case, Rootfs one seems the most appropriate to contain that functionality. If we still want to maintain all the code as it is, then the temporary updated fstab should inherit all the metadata of the original fstab. TL;DR: The content of the temporary updated fstab should be copied into the original fstab, preserving the metadata and xattrs, for example, SELinux xattrs. If we override the original one, we lose those. 102556 1 randy.macleod 2025-08-07 14:41:26 +0000 Daniel, I've cc'ed Trevor and Hongxu who work on wic at times. Are you willing to send a patch to this list and CC these folks ? -- YP Bug review. 102612 2 5133 daniel.andrade 2025-08-15 14:03:06 +0000 Created attachment 5133 The patch corrects the replacement of fstab instead of the file contents Using `install` in the rootfs plugin forces fstab to be replaced entirely, meaning that even its Inodes will change, leading xattrs and SELinux context stored by pseudo not to be applied. The fix just uses `cp` without preserving attributes from the temporary fstab since none of them are needed, just the content. Same thing happens with the predefined mechanisms for ext4 and msdos. Using debugfs there is no way to replace contents while maintaining metadata, so the approach taken on the path was to remove the different fstab logic for those fstypes and also use the same modified cp command. Reviewing the builds I did it seems to work for all of the fstypes. Another topic (not the real reason of this bug but also related) is that the timestamp applied to fstab is not the same as every other file. It seems like the `SOURCE_DATE_EPOCH` variable goes to the fallback timestamp (`SOURCE_DATE_EPOCH_FALLBACK`). Since you are using that variable everywhere, it is not the same value as ` REPRODUCIBLE_TIMESTAMP_ROOTFS` under `poky/meta/conf/bitbake.conf` that is applied in every other file. 102658 3 randy.macleod 2025-08-21 15:35:19 +0000 Daniel, Thanks for the attached patch. Are you willing and able to send it to the oe-core list for review ? https://docs.yoctoproject.org/contributor-guide/index.html You could include your question about the timestamp on /etc/fstab as part of your cover letter or just reply to your own thread or even make the change and see what people think in review. 102708 4 daniel.andrade 2025-09-08 10:36:48 +0000 The bug is now being addressed at: https://lists.openembedded.org/g/openembedded-core/topic/115043355 As suggested by Randy MacLeod 102826 5 randy.macleod 2025-09-25 15:03:12 +0000 Patch being discuss on the list. 104207 6 randy.macleod 2026-02-09 22:05:07 +0000 Daniel's email bounces so move to unassigned. 104478 7 randy.macleod 2026-03-03 22:05:18 +0000 Add TrevorW's gmail. Trevor, do you want to comment on or own this bug? 105598 8 randy.macleod 2026-05-28 13:16:28 +0000 Bulk move of 6.0 Medium bugs to 6.1. 106430 9 5240 daniele.romano 2026-08-04 14:42:42 +0000 Created attachment 5240 Retrive And Restore fstab xattrs patch Hello everyone, While reviewing this issue, I thought of a very simple and effective two-step approach with minimal code changes and that should be unlikely to have undesired effects. 1) First, we retrive the fstab xattr before replacing it with the following lines: get_xattr_cmd = "getfattr --absolute-names -dm- %s" % (fstab_path) ret, source_xattr = exec_native_cmd(get_xattr_cmd, native_sysroot, pseudo) 2) After the replacement of the fstab with install, we re-apply the stored xattr with the following lines: apply_xattr_cmd = "setfattr --restore=- %s" % (f"<< 'STDIN'\n{source_xattr}\nSTDIN") ret,out=exec_native_cmd(apply_xattr_cmd, native_sysroot, pseudo) All the tests and test-suites performed were successful. You can find the patch attached. Let me know if you need any additional information. Thank you and regards, Daniele 5133 2025-08-15 14:03:06 +0000 2025-08-15 14:03:06 +0000 The patch corrects the replacement of fstab instead of the file contents fstab-metadata.patch text/plain 3353 daniel.andrade ZGlmZiAtLWdpdCBhL3NjcmlwdHMvbGliL3dpYy9wYXJ0aXRpb24ucHkgYi9zY3JpcHRzL2xpYi93 aWMvcGFydGl0aW9uLnB5CmluZGV4IGJmMmMzNGQ1OTQuLjY5OTdhZTU1OWUgMTAwNjQ0Ci0tLSBh L3NjcmlwdHMvbGliL3dpYy9wYXJ0aXRpb24ucHkKKysrIGIvc2NyaXB0cy9saWIvd2ljL3BhcnRp dGlvbi5weQpAQCAtMTMxLDcgKzEzMSw3IEBAIGNsYXNzIFBhcnRpdGlvbigpOgogICAgICAgICBw YXJ0aXRpb24gY29tbWFuZCBwYXJhbWV0ZXJzLgogICAgICAgICAiIiIKICAgICAgICAgc2VsZi51 cGRhdGVkX2ZzdGFiX3BhdGggPSB1cGRhdGVkX2ZzdGFiX3BhdGgKLSAgICAgICAgaWYgc2VsZi51 cGRhdGVkX2ZzdGFiX3BhdGggYW5kIG5vdCAoc2VsZi5mc3R5cGUuc3RhcnRzd2l0aCgiZXh0Iikg b3Igc2VsZi5mc3R5cGUgPT0gIm1zZG9zIik6CisgICAgICAgIGlmIHNlbGYudXBkYXRlZF9mc3Rh Yl9wYXRoOgogICAgICAgICAgICAgc2VsZi51cGRhdGVfZnN0YWJfaW5fcm9vdGZzID0gVHJ1ZQog CiAgICAgICAgIGlmIG5vdCBzZWxmLnNvdXJjZToKQEAgLTI5NSwxNSArMjk1LDYgQEAgY2xhc3Mg UGFydGl0aW9uKCk6CiAgICAgICAgICAgICAoc2VsZi5mc3R5cGUsIGV4dHJhb3B0cywgcm9vdGZz LCBsYWJlbF9zdHIsIHNlbGYuZnN1dWlkLCByb290ZnNfZGlyKQogICAgICAgICBleGVjX25hdGl2 ZV9jbWQobWtmc19jbWQsIG5hdGl2ZV9zeXNyb290LCBwc2V1ZG89cHNldWRvKQogCi0gICAgICAg IGlmIHNlbGYudXBkYXRlZF9mc3RhYl9wYXRoIGFuZCBzZWxmLmhhc19mc3RhYiBhbmQgbm90IHNl bGYubm9fZnN0YWJfdXBkYXRlOgotICAgICAgICAgICAgZGVidWdmc19zY3JpcHRfcGF0aCA9IG9z LnBhdGguam9pbihjcl93b3JrZGlyLCAiZGVidWdmc19zY3JpcHQiKQotICAgICAgICAgICAgd2l0 aCBvcGVuKGRlYnVnZnNfc2NyaXB0X3BhdGgsICJ3IikgYXMgZjoKLSAgICAgICAgICAgICAgICBm LndyaXRlKCJjZCBldGNcbiIpCi0gICAgICAgICAgICAgICAgZi53cml0ZSgicm0gZnN0YWJcbiIp Ci0gICAgICAgICAgICAgICAgZi53cml0ZSgid3JpdGUgJXMgZnN0YWJcbiIgJSAoc2VsZi51cGRh dGVkX2ZzdGFiX3BhdGgpKQotICAgICAgICAgICAgZGVidWdmc19jbWQgPSAiZGVidWdmcyAtdyAt ZiAlcyAlcyIgJSAoZGVidWdmc19zY3JpcHRfcGF0aCwgcm9vdGZzKQotICAgICAgICAgICAgZXhl Y19uYXRpdmVfY21kKGRlYnVnZnNfY21kLCBuYXRpdmVfc3lzcm9vdCkKLQogICAgICAgICBta2Zz X2NtZCA9ICJmc2NrLiVzIC1wdmZEICVzIiAlIChzZWxmLmZzdHlwZSwgcm9vdGZzKQogICAgICAg ICBleGVjX25hdGl2ZV9jbWQobWtmc19jbWQsIG5hdGl2ZV9zeXNyb290LCBwc2V1ZG89cHNldWRv KQogCkBAIC0zMTUsNiArMzA2LDcgQEAgY2xhc3MgUGFydGl0aW9uKCk6CiAgICAgICAgICAgICAg ICAgYmFzZSA9IHJvb3QucmVwbGFjZShyb290ZnNfZGlyLCAiIikucnN0cmlwKG9zLnNlcCkKICAg ICAgICAgICAgICAgICBmaWxlcyArPSBbICIvIiBpZiBiYXNlID09ICIiIGVsc2UgYmFzZSBdCiAg ICAgICAgICAgICAgICAgZmlsZXMgKz0gWyBiYXNlICsgIi8iICsgbiBmb3IgbiBpbiBkaXJzICsg b3RoZXJzIF0KKwogICAgICAgICAgICAgd2l0aCBvcGVuKGRlYnVnZnNfc2NyaXB0X3BhdGgsICJ3 IikgYXMgZjoKICAgICAgICAgICAgICAgICBmLndyaXRlKCJzZXRfY3VycmVudF90aW1lICVzXG4i ICUgKHNkZV90aW1lKSkKICAgICAgICAgICAgICAgICBpZiBzZWxmLnVwZGF0ZWRfZnN0YWJfcGF0 aCBhbmQgc2VsZi5oYXNfZnN0YWIgYW5kIG5vdCBzZWxmLm5vX2ZzdGFiX3VwZGF0ZToKQEAgLTQw MCwxMCArMzkyLDYgQEAgY2xhc3MgUGFydGl0aW9uKCk6CiAgICAgICAgIG1jb3B5X2NtZCA9ICJt Y29weSAtaSAlcyAtcyAlcy8qIDo6LyIgJSAocm9vdGZzLCByb290ZnNfZGlyKQogICAgICAgICBl eGVjX25hdGl2ZV9jbWQobWNvcHlfY21kLCBuYXRpdmVfc3lzcm9vdCkKIAotICAgICAgICBpZiBz ZWxmLnVwZGF0ZWRfZnN0YWJfcGF0aCBhbmQgc2VsZi5oYXNfZnN0YWIgYW5kIG5vdCBzZWxmLm5v X2ZzdGFiX3VwZGF0ZToKLSAgICAgICAgICAgIG1jb3B5X2NtZCA9ICJtY29weSAtbSAtaSAlcyAl cyA6Oi9ldGMvZnN0YWIiICUgKHJvb3Rmcywgc2VsZi51cGRhdGVkX2ZzdGFiX3BhdGgpCi0gICAg ICAgICAgICBleGVjX25hdGl2ZV9jbWQobWNvcHlfY21kLCBuYXRpdmVfc3lzcm9vdCkKLQogICAg ICAgICBjaG1vZF9jbWQgPSAiY2htb2QgNjQ0ICVzIiAlIHJvb3RmcwogICAgICAgICBleGVjX2Nt ZChjaG1vZF9jbWQpCiAKZGlmZiAtLWdpdCBhL3NjcmlwdHMvbGliL3dpYy9wbHVnaW5zL3NvdXJj ZS9yb290ZnMucHkgYi9zY3JpcHRzL2xpYi93aWMvcGx1Z2lucy9zb3VyY2Uvcm9vdGZzLnB5Cmlu ZGV4IGUyOWYzYTRjMmYuLjM4NDhhZjJhOTEgMTAwNjQ0Ci0tLSBhL3NjcmlwdHMvbGliL3dpYy9w bHVnaW5zL3NvdXJjZS9yb290ZnMucHkKKysrIGIvc2NyaXB0cy9saWIvd2ljL3BsdWdpbnMvc291 cmNlL3Jvb3Rmcy5weQpAQCAtMjIzLDggKzIyMyw4IEBAIGNsYXNzIFJvb3Rmc1BsdWdpbihTb3Vy Y2VQbHVnaW4pOgogICAgICAgICAgICAgcGFydC5oYXNfZnN0YWIgPSBvcy5wYXRoLmV4aXN0cyhv cy5wYXRoLmpvaW4obmV3X3Jvb3RmcywgImV0Yy9mc3RhYiIpKQogICAgICAgICAgICAgaWYgcGFy dC51cGRhdGVfZnN0YWJfaW5fcm9vdGZzIGFuZCBwYXJ0Lmhhc19mc3RhYiBhbmQgbm90IHBhcnQu bm9fZnN0YWJfdXBkYXRlOgogICAgICAgICAgICAgICAgIGZzdGFiX3BhdGggPSBvcy5wYXRoLmpv aW4obmV3X3Jvb3RmcywgImV0Yy9mc3RhYiIpCi0gICAgICAgICAgICAgICAgIyBBc3N1bWUgdGhh dCBmc3RhYiBzaG91bGQgYWx3YXlzIGJlIG93bmVkIGJ5IHJvb3Qgd2l0aCBmaXhlZCBwZXJtaXNz aW9ucwotICAgICAgICAgICAgICAgIGluc3RhbGxfY21kID0gImluc3RhbGwgLW0gMDY0NCAtcCAl cyAlcyIgJSAocGFydC51cGRhdGVkX2ZzdGFiX3BhdGgsIGZzdGFiX3BhdGgpCisgICAgICAgICAg ICAgICAgIyBXZSBkb250IHdhbnQgYW55IG1ldGFkYXRhIG9mIHRoZSB1cGRhdGVkIGZzdGFiLCBq dXN0IHRoZSBvbmUgdGhhdCBhbHJlYWR5IGV4aXN0ZWQKKyAgICAgICAgICAgICAgICBpbnN0YWxs X2NtZCA9ICJjcCAtLW5vLXByZXNlcnZlPWFsbCAlcyAlcyIgJSAocGFydC51cGRhdGVkX2ZzdGFi X3BhdGgsIGZzdGFiX3BhdGgpCiAgICAgICAgICAgICAgICAgaWYgbmV3X3BzZXVkbzoKICAgICAg ICAgICAgICAgICAgICAgcHNldWRvID0gY2xzLl9fZ2V0X3BzZXVkbyhuYXRpdmVfc3lzcm9vdCwg bmV3X3Jvb3RmcywgbmV3X3BzZXVkbykKICAgICAgICAgICAgICAgICBlbHNlOgo= 5240 2026-08-04 14:42:42 +0000 2026-08-04 14:42:42 +0000 Retrive And Restore fstab xattrs patch retrieve_and_restore_fstab_xattr.patch text/plain 2019 daniele.romano ZGlmZiAtLWdpdCBhL3NjcmlwdHMvbGliL3dpYy9wbHVnaW5zL3NvdXJjZS9yb290ZnMucHkgYi9z Y3JpcHRzL2xpYi93aWMvcGx1Z2lucy9zb3VyY2Uvcm9vdGZzLnB5CmluZGV4IGUyOWYzYTRjMmYu LjFkYzg5NDY5ZWUgMTAwNjQ0Ci0tLSBhL3NjcmlwdHMvbGliL3dpYy9wbHVnaW5zL3NvdXJjZS9y b290ZnMucHkKKysrIGIvc2NyaXB0cy9saWIvd2ljL3BsdWdpbnMvc291cmNlL3Jvb3Rmcy5weQpA QCAtMjIzLDE0ICsyMjMsMjYgQEAgY2xhc3MgUm9vdGZzUGx1Z2luKFNvdXJjZVBsdWdpbik6CiAg ICAgICAgICAgICBwYXJ0Lmhhc19mc3RhYiA9IG9zLnBhdGguZXhpc3RzKG9zLnBhdGguam9pbihu ZXdfcm9vdGZzLCAiZXRjL2ZzdGFiIikpCiAgICAgICAgICAgICBpZiBwYXJ0LnVwZGF0ZV9mc3Rh Yl9pbl9yb290ZnMgYW5kIHBhcnQuaGFzX2ZzdGFiIGFuZCBub3QgcGFydC5ub19mc3RhYl91cGRh dGU6CiAgICAgICAgICAgICAgICAgZnN0YWJfcGF0aCA9IG9zLnBhdGguam9pbihuZXdfcm9vdGZz LCAiZXRjL2ZzdGFiIikKLSAgICAgICAgICAgICAgICAjIEFzc3VtZSB0aGF0IGZzdGFiIHNob3Vs ZCBhbHdheXMgYmUgb3duZWQgYnkgcm9vdCB3aXRoIGZpeGVkIHBlcm1pc3Npb25zCi0gICAgICAg ICAgICAgICAgaW5zdGFsbF9jbWQgPSAiaW5zdGFsbCAtbSAwNjQ0IC1wICVzICVzIiAlIChwYXJ0 LnVwZGF0ZWRfZnN0YWJfcGF0aCwgZnN0YWJfcGF0aCkKKwogICAgICAgICAgICAgICAgIGlmIG5l d19wc2V1ZG86CiAgICAgICAgICAgICAgICAgICAgIHBzZXVkbyA9IGNscy5fX2dldF9wc2V1ZG8o bmF0aXZlX3N5c3Jvb3QsIG5ld19yb290ZnMsIG5ld19wc2V1ZG8pCiAgICAgICAgICAgICAgICAg ZWxzZToKICAgICAgICAgICAgICAgICAgICAgcHNldWRvID0gTm9uZQorCisgICAgICAgICAgICAg ICAgIyBVcGRhdGluZyB0aGUgZnN0YWIgdmlhIGluc3RhbGwgY3JlYXRlcyBhIG5ldyBpbm9kZSwg bG9zaW5nCisgICAgICAgICAgICAgICAgIyB0aGUgYXNzb2NpYXRpb24gd2l0aCB0aGUgeGF0dHJz IHJlY29yZGVkIGluIHRoZSBwc2V1ZG8uZGIKKyAgICAgICAgICAgICAgICAjIFNhdmUgdGhlbSBo ZXJlIGFuZCByZWFwcGx5IGFmdGVyIHVwZGF0aW5nIHRoZSBmc3RhYi4KKyAgICAgICAgICAgICAg ICBnZXRfeGF0dHJfY21kID0gImdldGZhdHRyIC0tYWJzb2x1dGUtbmFtZXMgLWRtLSAlcyIgJSAo ZnN0YWJfcGF0aCkKKyAgICAgICAgICAgICAgICByZXQsIHNvdXJjZV94YXR0ciA9IGV4ZWNfbmF0 aXZlX2NtZChnZXRfeGF0dHJfY21kLCBuYXRpdmVfc3lzcm9vdCwgcHNldWRvKQorCisgICAgICAg ICAgICAgICAgIyBBc3N1bWUgdGhhdCBmc3RhYiBzaG91bGQgYWx3YXlzIGJlIG93bmVkIGJ5IHJv b3Qgd2l0aCBmaXhlZCBwZXJtaXNzaW9ucworICAgICAgICAgICAgICAgIGluc3RhbGxfY21kID0g Imluc3RhbGwgLW0gMDY0NCAtcCAlcyAlcyIgJSAocGFydC51cGRhdGVkX2ZzdGFiX3BhdGgsIGZz dGFiX3BhdGgpCiAgICAgICAgICAgICAgICAgZXhlY19uYXRpdmVfY21kKGluc3RhbGxfY21kLCBu YXRpdmVfc3lzcm9vdCwgcHNldWRvKQogCisgICAgICAgICAgICAgICAgIyBBcHBseSB0aGUgc3Rv cmVkIHhhdHRyIHRvIHRoZSBuZXdseSBpbnN0YWxsZWQgZnN0YWIKKyAgICAgICAgICAgICAgICBh cHBseV94YXR0cl9jbWQgPSAic2V0ZmF0dHIgLS1yZXN0b3JlPS0gJXMiICUgKGYiPDwgJ1NURElO J1xue3NvdXJjZV94YXR0cn1cblNURElOIikKKyAgICAgICAgICAgICAgICByZXQsb3V0PWV4ZWNf bmF0aXZlX2NtZChhcHBseV94YXR0cl9jbWQsIG5hdGl2ZV9zeXNyb290LCBwc2V1ZG8pCisKICAg ICAgICAgcGFydC5wcmVwYXJlX3Jvb3Rmcyhjcl93b3JrZGlyLCBvZV9idWlsZGRpciwKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBuZXdfcm9vdGZzIG9yIHBhcnQucm9vdGZzX2RpciwgbmF0 aXZlX3N5c3Jvb3QsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcHNldWRvX2RpciA9IG5l d19wc2V1ZG8gb3IgcHNldWRvX2RpcikK