16247 2026-04-15 12:24:02 +0000 patchtest: Check for missing spaces in modified patches 2026-04-20 18:19:37 +0000 1 1 6 Yocto Project Subprojects Patchwork/Patchtest Patchtest unspecified x86 Multiple IN PROGRESS IMPLEMENTATION Medium enhancement 6.1 1 yoann.congal tgamblin randy.macleod --- --- No (bug/feature does not impact docs) oldest_to_newest 105074 0 yoann.congal 2026-04-15 12:24:02 +0000 In patches, an empty context line translate to a patch line "+ ". Some tools consider the space ending the line an error, remove it and technically corrupt the patch. We could add a check in patchtest to error on such patches. Counterpoint: GNU patch (and most the patch tools I could find) handle this case gracefully and silently. Related: 9876 – patchtest-oe: check that attached SW patches does not contain trailing spaces https://bugzilla.yoctoproject.org/show_bug.cgi?id=9876 105155 1 5208 yoann.congal 2026-04-20 12:52:32 +0000 Created attachment 5208 Vibe-coded (Gemini) PoC script to check patch missing white space in context (It does work) Added my vibe-coded (Gemini) PoC script to check patch missing white spaces in context. It does work. 5208 2026-04-20 12:52:32 +0000 2026-04-20 12:52:32 +0000 Vibe-coded (Gemini) PoC script to check patch missing white space in context (It does work) check_patch.py text/x-python 2714 yoann.congal IyEvdXNyL2Jpbi9lbnYgcHl0aG9uMwojIEFzc2lzdGVkLWJ5OiBHZW1pbmkKaW1wb3J0IGFyZ3Bh cnNlCmltcG9ydCBzeXMKZnJvbSB1bmlkaWZmIGltcG9ydCBQYXRjaFNldApmcm9tIHVuaWRpZmYu ZXJyb3JzIGltcG9ydCBVbmlkaWZmUGFyc2VFcnJvcgoKZGVmIG1haW4oKToKICAgIHBhcnNlciA9 IGFyZ3BhcnNlLkFyZ3VtZW50UGFyc2VyKGRlc2NyaXB0aW9uPSJWYWxpZGF0ZSB0aGUgZm9ybWF0 IG9mIGEgdW5pZmllZCBkaWZmIHBhdGNoIHVzaW5nIHVuaWRpZmYuIikKICAgIHBhcnNlci5hZGRf YXJndW1lbnQoInBhdGNoX2ZpbGUiLCBoZWxwPSJQYXRoIHRvIHRoZSB1bmlmaWVkIGRpZmYgcGF0 Y2ggZmlsZSB0byB2YWxpZGF0ZS4iKQogICAgYXJncyA9IHBhcnNlci5wYXJzZV9hcmdzKCkKCiAg ICB0cnk6CiAgICAgICAgIyBSZWFkIHJhdyBsaW5lcyBmb3Igc3RyaWN0IHByZWZpeCBjaGVja2lu ZwogICAgICAgIHdpdGggb3BlbihhcmdzLnBhdGNoX2ZpbGUsICdyJywgZW5jb2Rpbmc9J3V0Zi04 JywgZXJyb3JzPSdpZ25vcmUnKSBhcyBmOgogICAgICAgICAgICByYXdfbGluZXMgPSBmLnJlYWRs aW5lcygpCgogICAgICAgICMgQXR0ZW1wdCB0byBwYXJzZSB0aGUgcGF0Y2ggZmlsZQogICAgICAg ICMgVGhpcyB3aWxsIHJhaXNlIFVuaWRpZmZQYXJzZUVycm9yIGlmIHRoZSBiYXNpYyBzdHJ1Y3R1 cmUgaXMgaW52YWxpZAogICAgICAgIHBhdGNoID0gUGF0Y2hTZXQuZnJvbV9maWxlbmFtZShhcmdz LnBhdGNoX2ZpbGUpCiAgICAgICAgCiAgICAgICAgIyBDaGVjayBpZiB0aGUgcGF0Y2ggc2V0IGlz IGFjdHVhbGx5IGVtcHR5CiAgICAgICAgaWYgbGVuKHBhdGNoKSA9PSAwOgogICAgICAgICAgICAg cHJpbnQoZiJXYXJuaW5nOiAne2FyZ3MucGF0Y2hfZmlsZX0nIGNvbnRhaW5zIG5vIHZhbGlkIHBh dGNoIGRhdGEgb3IgaXMgZW1wdHkuIiwgZmlsZT1zeXMuc3RkZXJyKQogICAgICAgICAgICAgc3lz LmV4aXQoMSkKCiAgICAgICAgIyBTdHJpY3QgdmFsaWRhdGlvbjogQ2hlY2sgdGhhdCBldmVyeSBs aW5lIGluIGV2ZXJ5IGh1bmsgc3RhcnRzIHdpdGggYSB2YWxpZCBwcmVmaXggKCcgJywgJysnLCAn LScsICdcJykKICAgICAgICAjIHVuaWRpZmYgaXMgc29tZXRpbWVzIHRvbyBsZW5pZW50IGFuZCBh bGxvd3MgY29tcGxldGVseSBlbXB0eSBsaW5lcyBhcyBjb250ZXh0IGxpbmVzLgogICAgICAgIGZv ciBwYXRjaGVkX2ZpbGUgaW4gcGF0Y2g6CiAgICAgICAgICAgIGZvciBodW5rIGluIHBhdGNoZWRf ZmlsZToKICAgICAgICAgICAgICAgIGZvciBsaW5lIGluIGh1bms6CiAgICAgICAgICAgICAgICAg ICAgIyBkaWZmX2xpbmVfbm8gaXMgMS1pbmRleGVkCiAgICAgICAgICAgICAgICAgICAgaWYgbGlu ZS5kaWZmX2xpbmVfbm86CiAgICAgICAgICAgICAgICAgICAgICAgIGlkeCA9IGxpbmUuZGlmZl9s aW5lX25vIC0gMQogICAgICAgICAgICAgICAgICAgICAgICBpZiBpZHggPCBsZW4ocmF3X2xpbmVz KToKICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJhd19saW5lID0gcmF3X2xpbmVzW2lkeF0K ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmIG5vdCByYXdfbGluZS5zdGFydHN3aXRoKCgn ICcsICcrJywgJy0nLCAnXFwnKSk6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcHJp bnQoZiJFcnJvcjogTWFsZm9ybWVkIHBhdGNoIGxpbmUgYXQge2FyZ3MucGF0Y2hfZmlsZX06e2xp bmUuZGlmZl9saW5lX25vfSIsIGZpbGU9c3lzLnN0ZGVycikKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBwcmludChmIkxpbmUgY29udGVudDoge3JlcHIocmF3X2xpbmUpfSIsIGZpbGU9 c3lzLnN0ZGVycikKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwcmludCgiQ29udGV4 dCBsaW5lcyBtdXN0IHN0YXJ0IHdpdGggZXhhY3RseSBvbmUgc3BhY2UuIFRoaXMgbGluZSBpcyBt aXNzaW5nIGl0cyBwcmVmaXguIiwgZmlsZT1zeXMuc3RkZXJyKQogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHN5cy5leGl0KDEpCgogICAgICAgIHByaW50KGYiU3VjY2VzczogJ3thcmdz LnBhdGNoX2ZpbGV9JyBpcyBhIHZhbGlkIHVuaWZpZWQgZGlmZiBwYXRjaC4iLCBmaWxlPXN5cy5z dGRvdXQpCiAgICAgICAgc3lzLmV4aXQoMCkKICAgICAgICAKICAgIGV4Y2VwdCBVbmlkaWZmUGFy c2VFcnJvciBhcyBlOgogICAgICAgIHByaW50KGYiRXJyb3I6IE1hbGZvcm1lZCBwYXRjaCBmaWxl ICd7YXJncy5wYXRjaF9maWxlfScuIiwgZmlsZT1zeXMuc3RkZXJyKQogICAgICAgIHByaW50KGYi RGV0YWlsczoge2V9IiwgZmlsZT1zeXMuc3RkZXJyKQogICAgICAgIHByaW50KCJcbkNvbW1vbiBp c3N1ZTogQ29udGV4dCBsaW5lcyBtdXN0IHN0YXJ0IHdpdGggZXhhY3RseSBvbmUgc3BhY2UuIiwg ZmlsZT1zeXMuc3RkZXJyKQogICAgICAgIHN5cy5leGl0KDEpCiAgICBleGNlcHQgRmlsZU5vdEZv dW5kRXJyb3I6CiAgICAgICAgcHJpbnQoZiJFcnJvcjogRmlsZSAne2FyZ3MucGF0Y2hfZmlsZX0n IG5vdCBmb3VuZC4iLCBmaWxlPXN5cy5zdGRlcnIpCiAgICAgICAgc3lzLmV4aXQoMSkKICAgIGV4 Y2VwdCBFeGNlcHRpb24gYXMgZToKICAgICAgICBwcmludChmIkFuIHVuZXhwZWN0ZWQgZXJyb3Ig b2NjdXJyZWQ6IHtlfSIsIGZpbGU9c3lzLnN0ZGVycikKICAgICAgICBzeXMuZXhpdCgyKQoKaWYg X19uYW1lX18gPT0gIl9fbWFpbl9fIjoKICAgIG1haW4oKQo=