1791 2011-11-29 18:07:43 +0000 Remove a few unwanted lines 2011-12-06 23:51:39 +0000 1 1 7 Build System, Metadata & Runtime BitBake bitbake 1.2 x86 Multiple RESOLVED FIXED Low minor 1.2 1 liezhi.yang liezhi.yang poky.bs.watcher poky.watcher richard.purdie sgw --- --- --- oldest_to_newest 17426 0 liezhi.yang 2011-11-29 18:07:43 +0000 There seems a few lines are unwanted. In bitbake/lib/bb/cooker.py, we have the followings in both BBCooker::__init__ and BBCooker::loadConfigurationData: if not self.configuration.cmd: self.configuration.cmd = self.configuration.data.getVar("BB_DEFAULT_TASK", True) or "build" The __init__ will invoke the loadConfigurationData, so we can remove the one in the __init__. In bitbake/lib/bb/command.py, we have the following lines: for attr in CommandsSync.__dict__: command = attr[:].lower() method = getattr(CommandsSync, attr) sync_cmds[command] = (method) for attr in CommandsAsync.__dict__: command = attr[:].lower() method = getattr(CommandsAsync, attr) async_cmds[command] = (method) The sync_cmds and async_cmds are defined as global dictionaries, but it seems that we've never used them, it seems that they have been replaced by the self.cmds_sync and self.cmds_async, so I think that we can remove them. 17427 1 liezhi.yang 2011-11-29 18:10:54 +0000 Add Richard to the CC list. 17505 2 liezhi.yang 2011-12-06 23:51:39 +0000 merged to master