1844 2011-12-19 04:45:11 +0000 base.bbclass should check for multiple (or) licenses in bb files 2012-01-11 02:09:45 +0000 1 1 7 Build System, Metadata & Runtime Meta-yocto meta-yocto unspecified x86 Multiple RESOLVED FIXED Medium normal 1.2 M2 1 andrei andrei kergoth poky.bs.watcher poky.watcher sgw --- --- --- oldest_to_newest 17720 0 302 andrei 2011-12-19 04:45:11 +0000 Created attachment 302 base.bbclass checks for multiple (or) licenses There are a couple of packages with double or multiple license. This means that everybody can choose from a set of licenses. [example : qt4-embedded] LICENSE = "LGPLv2.1 | GPLv3" Well, this "or" operand doesn't work as i end up with this error in a GPLv3 incompatible build: [example : qt4-embedded] ERROR: Nothing PROVIDES 'qt4-embedded' ERROR: qt4-embedded was skipped: incompatible with license LGPLv2.1 | GPLv3 ERROR: Command execution failed: Traceback (most recent call last): File "/home/agherzan/work/wrs/yocto-adige/poky/bitbake/lib/bb/command.py", line 87, in runAsyncCommand commandmethod(self.cmds_async, self, options) File "/home/agherzan/work/wrs/yocto-adige/poky/bitbake/lib/bb/command.py", line 192, in buildTargets command.cooker.buildTargets(pkgs_to_build, task) File "/home/agherzan/work/wrs/yocto-adige/poky/bitbake/lib/bb/cooker.py", line 1111, in buildTargets taskdata.add_provider(localdata, self.status, k) File "/home/agherzan/work/wrs/yocto-adige/poky/bitbake/lib/bb/taskdata.py", line 371, in add_provider self.add_provider_internal(cfgData, dataCache, item) File "/home/agherzan/work/wrs/yocto-adige/poky/bitbake/lib/bb/taskdata.py", line 391, in add_provider_internal raise bb.providers.NoProvider(item) NoProvider: qt4-embedded For the case of excluding a certain license, base.bbclass should be modified in order to check if there is an "or" operand, and if it is, should check further if there are other non-excluded licenses. I will attach a patch that would solve this problem. Please check it and tell me if i should commit it. 17722 1 kergoth 2011-12-19 06:38:57 +0000 (In reply to comment #0) > Created attachment 302 [details] > base.bbclass checks for multiple (or) licenses I'm sure this method might be a quick one, and if so, that could be a reason to stick with it, but it does seem to be duplicating at least some of the logic which already exists in the license parsing code used by license.bbclass. 17724 2 andrei 2011-12-19 07:23:15 +0000 (In reply to comment #1) > (In reply to comment #0) > > Created attachment 302 [details] [details] > > base.bbclass checks for multiple (or) licenses > > I'm sure this method might be a quick one, and if so, that could be a reason to > stick with it, but it does seem to be duplicating at least some of the logic > which already exists in the license parsing code used by license.bbclass. As i know that class is taken into consideration while building packages. Didn't see any license checked there for dependencies or excluded licenses. So i think my solution is ok. 17725 3 kergoth 2011-12-19 07:43:52 +0000 (In reply to comment #2) > (In reply to comment #1) > > (In reply to comment #0) > > > Created attachment 302 [details] [details] [details] > > > base.bbclass checks for multiple (or) licenses > > > > I'm sure this method might be a quick one, and if so, that could be a reason to > > stick with it, but it does seem to be duplicating at least some of the logic > > which already exists in the license parsing code used by license.bbclass. > > As i know that class is taken into consideration while building packages. > Didn't see any license checked there for dependencies or excluded licenses. So > i think my solution is ok. I don't understand the point you're trying to make here. Whether license.bbclass excludes or not, the core logic is the same, and duplicating it arguably increases maintenance load. copyleft_compliance.bbclass uses the same parsing, and it *does* support exclusion. 17727 4 kergoth 2011-12-19 07:44:31 +0000 Note: I don't have a strong opinion either way on this, I just wanted to make sure the decision was a conscious one. 17896 5 andrei 2011-12-30 03:32:15 +0000 Patch submitted by email to openembedded-core list: http://lists.linuxtogo.org/pipermail/openembedded-core/2011-December/015128.html 18025 6 andrei 2012-01-09 07:46:24 +0000 http://lists.linuxtogo.org/pipermail/openembedded-core/2012-January/015873.html 18042 7 andrei 2012-01-10 07:21:38 +0000 http://lists.linuxtogo.org/pipermail/openembedded-core/2012-January/015953.html 18069 8 andrei 2012-01-11 02:09:45 +0000 commit 4005c3ff5e673f9d561026c76326054bd0a3a2b6 302 2011-12-19 04:45:11 +0000 2011-12-19 04:45:11 +0000 base.bbclass checks for multiple (or) licenses or_license.patch text/plain 1372 andrei ZGlmZiAtLWdpdCBhL21ldGEvY2xhc3Nlcy9iYXNlLmJiY2xhc3MgYi9tZXRhL2NsYXNzZXMvYmFz ZS5iYmNsYXNzCmluZGV4IGZiY2FlZmIuLjEwMTBiNWEgMTAwNjQ0Ci0tLSBhL21ldGEvY2xhc3Nl cy9iYXNlLmJiY2xhc3MKKysrIGIvbWV0YS9jbGFzc2VzL2Jhc2UuYmJjbGFzcwpAQCAtNDAyLDgg KzQwMiwyMSBAQCBweXRob24gKCkgewogICAgICAgICAgICAgICAgIGltcG9ydCByZQogICAgICAg ICAgICAgICAgIHRoaXNfbGljZW5zZSA9IGQuZ2V0VmFyKCdMSUNFTlNFJywgMSkKICAgICAgICAg ICAgICAgICBpZiB0aGlzX2xpY2Vuc2UgYW5kIHJlLnNlYXJjaChkb250X3dhbnRfbGljZW5zZSwg dGhpc19saWNlbnNlKToKLSAgICAgICAgICAgICAgICAgICAgYmIubm90ZSgiU0tJUFBJTkcgJXMg YmVjYXVzZSBpdCdzICVzIiAlIChwbiwgdGhpc19saWNlbnNlKSkKLSAgICAgICAgICAgICAgICAg ICAgcmFpc2UgYmIucGFyc2UuU2tpcFBhY2thZ2UoImluY29tcGF0aWJsZSB3aXRoIGxpY2Vuc2Ug JXMiICUgdGhpc19saWNlbnNlKQorCQkgICAgdGhpc19saWNlbnNlX25vX3NwYWNlcyA9IHJlLnN1 YihyJ1xzJywgJycsIHRoaXNfbGljZW5zZSkKKwkJICAgIGxpY2Vuc2VzID0gcmUuc3BsaXQoJ1t8 XScsIHRoaXNfbGljZW5zZV9ub19zcGFjZXMpCisJCSAgICBpZiBsZW4obGljZW5zZXMpICE9IDA6 CisJCQlnb29kX2xpY2Vuc2U9IiIKKwkJICAgICAgICBmb3Igb25lbGljZW5zZSBpbiBsaWNlbnNl czoKKwkJCSAgICBpZiBub3QgcmUuc2VhcmNoKGRvbnRfd2FudF9saWNlbnNlLCBvbmVsaWNlbnNl KToKKwkJCQlnb29kX2xpY2Vuc2UgPSBvbmVsaWNlbnNlCisJCQlpZiBnb29kX2xpY2Vuc2UgPT0g IiI6CisJCQkgICAgYmIubm90ZSgiU0tJUFBJTkcgJXMgYmVjYXVzZSBpdCdzICVzIiAlIChwbiwg dGhpc19saWNlbnNlKSkKKwkJCSAgICByYWlzZSBiYi5wYXJzZS5Ta2lwUGFja2FnZSgiaW5jb21w YXRpYmxlIHdpdGggbGljZW5zZSAlcyIgJSB0aGlzX2xpY2Vuc2UpCisJCQllbHNlOgorCQkJICAg IGJiLm5vdGUoIk5PVCBTS0lQUElORyAlcyBiZWNhdXNlIGl0J3MgJXMgd2hpY2ggY29udGFpbnMg JXMiICUgKHBuLCB0aGlzX2xpY2Vuc2UsIGdvb2RfbGljZW5zZSkpCisJCSAgICBlbHNlOgorCQkJ YmIubm90ZSgiU0tJUFBJTkcgJXMgYmVjYXVzZSBpdCdzICVzIiAlIChwbiwgdGhpc19saWNlbnNl KSkKKwkJCXJhaXNlIGJiLnBhcnNlLlNraXBQYWNrYWdlKCJpbmNvbXBhdGlibGUgd2l0aCBsaWNl bnNlICVzIiAlIHRoaXNfbGljZW5zZSkKIAogICAgIHNyY3VyaSA9IGQuZ2V0VmFyKCdTUkNfVVJJ JywgMSkKICAgICAjIFN2biBwYWNrYWdlcyBzaG91bGQgREVQRU5EIG9uIHN1YnZlcnNpb24tbmF0 aXZlCg==