<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>1884</bug_id>
          
          <creation_ts>2012-01-07 12:15:47 +0000</creation_ts>
          <short_desc>gettext: GPL-3 is not checked in order to be exluded from a non-GPLv3 build</short_desc>
          <delta_ts>2012-01-11 02:09:26 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>core</component>
          <version>unspecified</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>1.2 M2</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Andrei Gherzan">andrei</reporter>
          <assigned_to name="Andrei Gherzan">andrei</assigned_to>
          <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>---</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>18002</commentid>
    <comment_count>0</comment_count>
    <who name="Andrei Gherzan">andrei</who>
    <bug_when>2012-01-07 12:15:47 +0000</bug_when>
    <thetext>If non-GPLv3 build fix-gettext-version.patch should be included. This was done   
already but the &quot;if&quot; structure (probably) contains a typo.

if not ((d.getVar(&quot;INCOMPATIBLE_LICENSE&quot;, True) or &quot;&quot;).find(&quot;GPLv3&quot;) != -1):
This means (if INCOMPATIBLE_LICENSE DOESN&apos;T contain GPLv3) cause it&apos;s a double negation.

This should be fixed to exclude that &quot;not&quot;:
if ((d.getVar(&quot;INCOMPATIBLE_LICENSE&quot;, True) or &quot;&quot;).find(&quot;GPLv3&quot;) != -1):

I sent an email to oe-core with the very simple fix.

Please be aware that this bug makes a non-GPLv3 build not build-able - this is why i will set Severity on &quot;major&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>18003</commentid>
    <comment_count>1</comment_count>
    <who name="Andrei Gherzan">andrei</who>
    <bug_when>2012-01-07 13:13:58 +0000</bug_when>
    <thetext>(In reply to comment #0)
&gt; If non-GPLv3 build fix-gettext-version.patch should be included. This was done  
&gt; already but the &quot;if&quot; structure (probably) contains a typo.
&gt; 
&gt; if not ((d.getVar(&quot;INCOMPATIBLE_LICENSE&quot;, True) or &quot;&quot;).find(&quot;GPLv3&quot;) != -1):
&gt; This means (if INCOMPATIBLE_LICENSE DOESN&apos;T contain GPLv3) cause it&apos;s a double
&gt; negation.
&gt; 
&gt; This should be fixed to exclude that &quot;not&quot;:
&gt; if ((d.getVar(&quot;INCOMPATIBLE_LICENSE&quot;, True) or &quot;&quot;).find(&quot;GPLv3&quot;) != -1):
&gt; 
&gt; I sent an email to oe-core with the very simple fix.
&gt; 
&gt; Please be aware that this bug makes a non-GPLv3 build not build-able - this is
&gt; why i will set Severity on &quot;major&quot;.

After looking a little more into this problem i realized that i was wrong. The problem is not here. The problem is that gettext 0.18 is not excluded from a non-GPLv3 build even if it is GPLv3 license. In a non-GPLv3 build gettext 0.18 is compiled but in gnutls, the patch for this gettext version is omitted due to the above specified patch and it fails with this error:

...
| make[4]: Entering directory `/home/agherzan/work/wrs/yocto-adige/test/tmp/work/armv5te-poky-linux-gnueabi/gnutls-2.12.14-r3.4/gnutls-2.12.14/lib/po&apos;
| *** error: gettext infrastructure mismatch: using a Makefile.in.in from gettext version 0.17 but the autoconf macros are from gettext version 0.18
...

I found strange the fact that gettext has in it&apos;s bb file the following license:
LICENSE = &quot;GPL-3+ &amp; LGPL-2.1+&quot;

I checked the license and it is GPLv3.
GNU GENERAL PUBLIC LICENSE
Version 3, 29 June 2007

So after all it is a typo... 

Sau, what do you think about this issue?

P.S.: Fortunately, i realized this in time not to send this patch to oe-core.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>18006</commentid>
    <comment_count>2</comment_count>
    <who name="Andrei Gherzan">andrei</who>
    <bug_when>2012-01-08 04:47:25 +0000</bug_when>
    <thetext>I sent a patch for this (as a workaround or not).

http://lists.linuxtogo.org/pipermail/openembedded-core/2012-January/015848.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>18007</commentid>
    <comment_count>3</comment_count>
    <who name="Andrei Gherzan">andrei</who>
    <bug_when>2012-01-08 04:48:03 +0000</bug_when>
    <thetext>I sent a patch for this (as a workaround or not) and modified the summary of this bug.

http://lists.linuxtogo.org/pipermail/openembedded-core/2012-January/015848.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>18015</commentid>
    <comment_count>4</comment_count>
    <who name="Saul Wold">sgw</who>
    <bug_when>2012-01-08 23:25:09 +0000</bug_when>
    <thetext>I demoted this to normal, major is for when a core builds are broken and needs to be fixed by a Milestone (M1, M2, ...)

I assigned this back to you since you appear to be working on this issue. I would suggest that you extend the code handling INCOMPATIBLE_LICENSE to use the SPDX names also.

So we have 2 names for GPLv3 (OE-Style) and GPL-3 (SPDX)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>18024</commentid>
    <comment_count>5</comment_count>
    <who name="Andrei Gherzan">andrei</who>
    <bug_when>2012-01-09 07:45:42 +0000</bug_when>
    <thetext>http://lists.linuxtogo.org/pipermail/openembedded-core/2012-January/015873.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>18043</commentid>
    <comment_count>6</comment_count>
    <who name="Andrei Gherzan">andrei</who>
    <bug_when>2012-01-10 07:21:49 +0000</bug_when>
    <thetext>http://lists.linuxtogo.org/pipermail/openembedded-core/2012-January/015953.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>18068</commentid>
    <comment_count>7</comment_count>
    <who name="Andrei Gherzan">andrei</who>
    <bug_when>2012-01-11 02:09:26 +0000</bug_when>
    <thetext>commit 4005c3ff5e673f9d561026c76326054bd0a3a2b6</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>