<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>2453</bug_id>
          
          <creation_ts>2012-05-14 06:58:20 +0000</creation_ts>
          <short_desc>Convert -config (binconfig) files to pkgconfig</short_desc>
          <delta_ts>2012-12-14 06:24:02 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>core</component>
          <version>1.2</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>VERIFIED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard>Finished</status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>1.4 M2</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Saul Wold">sgw</reporter>
          <assigned_to name="Chen Qi">Qi.Chen</assigned_to>
          <cc>jessica.zhang</cc>
    
    <cc>liezhi.yang</cc>
    
    <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
    
    <cc>Qi.Chen</cc>
    
    <cc>sgw</cc>
    
    <cc>yi.zhao</cc>
    
    <cc>zhenfeng.zhao</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>---</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>21331</commentid>
    <comment_count>0</comment_count>
    <who name="Saul Wold">sgw</who>
    <bug_when>2012-05-14 06:58:20 +0000</bug_when>
    <thetext>We have about 30 recipes / packages that deliver *-config tools for development, these packages should deliver pkgconfig (.pc) files instead.  Verify if they do and use that file and delete the -config or create a patch to deliver the .pc file.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>27594</commentid>
    <comment_count>1</comment_count>
    <who name="Chen Qi">Qi.Chen</who>
    <bug_when>2012-11-21 09:06:13 +0000</bug_when>
    <thetext>Hi Saul,
Below is a patch that adds pkgconfig to libksba. Am I doing it right?
If so, I&apos;ll add pkgconfig support to other packages in the same way; otherwise, please let me know what&apos;s wrong with it.

Chen Qi
-----------------------------------------------------------------

From e6fd274484cc2b4b479c561d6dc7c17d26273a84 Mon Sep 17 00:00:00 2001
From: Chen Qi &lt;Qi.Chen@windriver.com&gt;
Date: Wed, 21 Nov 2012 16:30:51 +0800
Subject: [PATCH] libksba: add pkgconfig support

Add pkgconfig support for libksba.

[YOCTO #2453]

Singed-off-by: Chen Qi&lt;Qi.Chen@windriver.com&gt;
---
 .../libksba/0001-add-pkgconfig-support.patch       |   42 ++++++++++++++++++++
 meta/recipes-support/libksba/libksba_1.2.0.bb      |   13 ++++--
 2 files changed, 52 insertions(+), 3 deletions(-)
 create mode 100644 meta/recipes-support/libksba/libksba/0001-add-pkgconfig-support.patch

diff --git a/meta/recipes-support/libksba/libksba/0001-add-pkgconfig-support.patch b/meta/recipes-support/libksba/libksba/0001-add-pkgconfig-support.patch
new file mode 100644
index 0000000..619041b
--- /dev/null
+++ b/meta/recipes-support/libksba/libksba/0001-add-pkgconfig-support.patch
@@ -0,0 +1,42 @@
+Upstream-Status: Inappropriate [distribution]
+
+Signed-off-by: Chen Qi &lt;Qi.Chen@windriver.com&gt;
+
+Index: libksba-1.2.0/configure.ac
+====================================================================
+--- libksba-1.2.0/configure.ac
++++ libksba-1.2.0/configure.ac
+@@ -391,6 +391,7 @@ m4/Makefile
+ gl/Makefile
+ src/Makefile
+ src/ksba-config
++src/ksba.pc
+ src/versioninfo.rc
+ tests/Makefile
+ doc/Makefile
+
+Index: libksba-1.2.0/src/ksba.pc.in
+====================================================================
+--- /dev/null
++++ libksba-1.2.0/src/ksba.pc.in
+@@ -0,0 +1,17 @@
++# Process this file with autoconf to produce a pkg-config metadata file.
++
++prefix=@prefix@
++exec_prefix=@exec_prefix@
++libdir=@libdir@
++includedir=@includedir@
++
++# API info
++api_version=@KSBA_CONFIG_API_VERSION@
++
++Name: ksba
++Description: Libksba provides an easy API to create and parse X.509 and CMS related objects
++Requires:
++Version: @VERSION@
++Libs: -L${libdir} -lksba
++Libs.private: -L{libdir} -lgpg-error
++Cflags: -I${includedir}
+-- 
+1.7.11.2
+
diff --git a/meta/recipes-support/libksba/libksba_1.2.0.bb b/meta/recipes-support/libksba/libksba_1.2.0.bb
index dd8d88f..ca361ef 100644
--- a/meta/recipes-support/libksba/libksba_1.2.0.bb
+++ b/meta/recipes-support/libksba/libksba_1.2.0.bb
@@ -2,13 +2,20 @@ DESCRIPTION = &quot;Libksba provides an easy API to create and parse X.509 and CMS re
 HOMEPAGE = &quot;http://www.gnupg.org/related_software/libksba/&quot;
 LICENSE = &quot;GPLv3&quot;
 LIC_FILES_CHKSUM = &quot;file://COPYING;md5=f27defe1e96c2e1ecd4e0c9be8967949&quot;
-PR = &quot;r1&quot;
+PR = &quot;r2&quot;
 
 DEPENDS = &quot;libgpg-error&quot;
 
-inherit autotools binconfig
+inherit autotools binconfig pkgconfig
 
-SRC_URI = &quot;ftp://ftp.gnupg.org/gcrypt/${BPN}/${BPN}-${PV}.tar.bz2&quot;
+SRC_URI = &quot;ftp://ftp.gnupg.org/gcrypt/${BPN}/${BPN}-${PV}.tar.bz2 \
+	   file://0001-add-pkgconfig-support.patch&quot;
 
 SRC_URI[md5sum] = &quot;e797f370b69b4dc776499d6a071ae137&quot;
 SRC_URI[sha256sum] = &quot;09afce65b03d027cbec10d21464f4f651cdfd269e38b404f83e48d3e2a3c934b&quot;
+
+# ksba.pc is added locally and thus installed here
+do_install_append() {
+	install -d ${D}/${libdir}/pkgconfig
+	install -m 0644 ${S}/src/ksba.pc ${D}/${libdir}/pkgconfig/
+}
-- 
1.7.9.5</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>28106</commentid>
    <comment_count>2</comment_count>
    <who name="Chen Qi">Qi.Chen</who>
    <bug_when>2012-12-10 07:11:26 +0000</bug_when>
    <thetext>Merged into master.
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/pkgconfig2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>28224</commentid>
    <comment_count>3</comment_count>
    <who name="Chen Qi">Qi.Chen</who>
    <bug_when>2012-12-13 08:33:57 +0000</bug_when>
    <thetext>The four packages are:
pth
libassuan
libksba
icu (ICU is being upgraded for now)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>28226</commentid>
    <comment_count>4</comment_count>
    <who name="Chen Qi">Qi.Chen</who>
    <bug_when>2012-12-13 09:04:16 +0000</bug_when>
    <thetext>(In reply to comment #3)
&gt; The four packages are:
&gt; pth
&gt; libassuan
&gt; libksba
&gt; icu (ICU is being upgraded for now)

The corresponding .pc files reside under /usr/lib/pkgconfig/.

Naming rule: libxxx -&gt; xxx.pc or libxxx.pc (if necessary)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>28281</commentid>
    <comment_count>5</comment_count>
    <who name="Yi Zhao">yi.zhao</who>
    <bug_when>2012-12-14 06:24:02 +0000</bug_when>
    <thetext>Verified with master branch: 45915123a727f86b106da7ccb761b23067b1ff88

###################
# rpm -ql icu-dev|grep &quot;.pc&quot;
/usr/lib/pkgconfig/icu.pc
# rpm -ql libpth-dev|grep &quot;.pc&quot;
/usr/lib/pkgconfig/pth.pc
# rpm -ql libksba-dev|grep &quot;.pc&quot;
/usr/lib/pkgconfig/ksba.pc
# rpm -ql libassuan-dev|grep &quot;.pc&quot;
/usr/lib/pkgconfig/assuan.pc
###################</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>