2467 2012-05-17 09:35:47 +0000 xserver-nodm-init init script broken for rootles X 2012-06-19 13:31:44 +0000 1 1 7 Build System, Metadata & Runtime OE-Core graphics 1.2 x86 Multiple VERIFIED FIXED (Scheduled) High major 1.3 M1 1 tf+bugs.yocto laurentiu.palcu alexandru.c.georgescu jessica.zhang meta.mr.watcher meta.watcher ross.burton song.liu --- --- --- oldest_to_newest 21407 0 516 tf+bugs.yocto 2012-05-17 09:35:47 +0000 Created attachment 516 Patch to add missing -s option to su invocation. the init script tries to start the server using this line: su -l -c '/etc/X11/Xserver&' $username This does not work, because the user 'xuser' has default shell /bin/false, so the whole line is a NOP. It can be fixed by adding '-s /bin/sh' to the command line; patch is attached. 21925 1 laurentiu.palcu 2012-06-08 08:09:58 +0000 I tested rootless X on an atom based Lenovo Ideapad S10-3t, with Intel GPU, and it works fine. I used atom-pc machine target and I didn't need to change anything else. However, it doesn't work in qemux86 anymore because X depends very much on DRI now and qemu does not support it. Nevertheless, the bug doesn't seem to be valid since the xserver-nodm script works fine for atom-pc. 21986 2 laurentiu.palcu 2012-06-11 10:53:47 +0000 Works fine on real HW. Closing as invalid. 21989 3 tf+bugs.yocto 2012-06-11 11:31:48 +0000 I am using this on real HW too, and it definitely does not work here, and I don't see how it could possibly work considering xuser has no shell ... from a root console, if you do 'su xuser' do you get an xuser shell? 21990 4 laurentiu.palcu 2012-06-11 12:04:55 +0000 @tf: I do get a shell after doing 'su xuser' in a root console. Also, /etc/passwd shows that xuser does have a shell assigned: xuser:x:1000:1000::/home/xuser:/bin/sh The '/bin/sh' is assigned by default by useradd if no -s option is provided and if /etc/default/useradd exists. In our case, the file exists and the default shell is /bin/sh. So, it should also work for you. Are you using the latest tree? Can you provide more info? 21991 5 tf+bugs.yocto 2012-06-11 12:39:25 +0000 I am using denzil; the xuser entry in the passwd file is: xuser:x:999:999::/home/xuser:/bin/false The reason for this is connman, the connman.inc file also does a useradd xuser and it specifies the shell as /bin/false -- I guess the final outcome depends on whether your xserver-nodm-init or connman recipe gets built first. 21992 6 laurentiu.palcu 2012-06-11 13:35:36 +0000 You're right. It looks like a parallelism issue. If connman creates the user first, then xserver-nodm-init script will fail to create the user because it already exists. It turns out, I was "lucky" enough not to reproduce it... :) 21993 7 ross.burton 2012-06-11 13:42:32 +0000 There is a good reason for connman to create the user -- dbus warns if it comes across a username it doesn't recognise in the rules. Long term I want to see that rule die anyway. 21996 8 laurentiu.palcu 2012-06-11 15:01:32 +0000 Well, I think the right solution to this would be to make useradd parameters consistent for both connman and xserver-nodm-init. Afterall, they both add the same user which is shared between connman and rootless X. 22120 9 laurentiu.palcu 2012-06-13 13:14:32 +0000 Patches merged: http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=ca6d07c92c50a52d05aa960b7929184413780714 http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=7f017cab0b3e4d5a4fc356eccd8eb8429b0531d0 22121 10 tf+bugs.yocto 2012-06-13 13:21:37 +0000 Thx; it's a fix for now, but having to manually keep files in sync is not very robust -- would it not be better to have a dedicated xuser package that the two packages RDEPEND on? 22123 11 laurentiu.palcu 2012-06-13 13:34:46 +0000 Technically, it would be better. But I don't think it's worth the effort, provided USERADD_PARAMs are not expected to change that often in the future. Otherwise, yes, I agree with you. 22124 12 ross.burton 2012-06-13 14:02:16 +0000 I've made it a personal mission to remove the xuser reference in connman anyway. 22337 13 alexandru.c.georgescu 2012-06-19 13:31:44 +0000 Hi, I have tested it with the core-image-sato-sugarbay-20120618061023.hddimg. X starts, the line: xuser:x:1000:1000::/home/xuser:/bin/sh exist in /etc/passwd, and in connman.inc the USER_ADD_PARAM${PN} is created like this: USERADD_PARAM_${PN} = "--create-home \ --groups video,tty,audio \ --user-group xuser" Setting it to verified. alex. 516 2012-05-17 09:35:47 +0000 2012-05-17 09:35:47 +0000 Patch to add missing -s option to su invocation. 0001-xserver-nodm-init-fix-server-invocation-via-su-for-r.patch text/plain 1339 tf+bugs.yocto RnJvbSAxNTk0ZjAyMDljNTc5ZjQxNTY0ZTU3MTE4NmEyODRkOGNiODFiNzE0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUb21hcyBGcnlkcnljaCA8dG9tYXNAc2xlZXBmaXZlLmNvbT4K RGF0ZTogVGh1LCAxNyBNYXkgMjAxMiAwOTo1OToxNyArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIHhz ZXJ2ZXItbm9kbS1pbml0OiBmaXggc2VydmVyIGludm9jYXRpb24gdmlhIHN1IGZvciByb290bGVz cwogWApUbzogeW9jdG9AeW9jdG9wcm9qZWN0Lm9yZwoKU2luY2UgdGhlIFggdXNlciBtaWdodCBu b3QgaGF2ZSBhIGxvZ2luIHNoZWxsIChhcyBpcyB0aGUgY2FzZSB3aXRoIHRoZSBkZWZhdWx0Cnh1 c2VyLCB3aGVyZSBsb2dpbiBzaGVsbCBpcyAvYmluL2ZhbHNlKSwgYSBzaGVsbCBwYXJhbWV0ZXIg bXVzdCBwYXNzZWQKZXhwbGl0ZWx5IHRvIHRoZSBzdSBjb21tYW5kLgoKU2lnbmVkLW9mZi1ieTog VG9tYXMgRnJ5ZHJ5Y2ggPHRvbWFzQHNsZWVwZml2ZS5jb20+Ci0tLQogLi4uL3gxMS1jb21tb24v eHNlcnZlci1ub2RtLWluaXQveHNlcnZlci1ub2RtICAgICAgfCAgICAyICstCiAxIGZpbGUgY2hh bmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9tZXRhL3Jl Y2lwZXMtZ3JhcGhpY3MveDExLWNvbW1vbi94c2VydmVyLW5vZG0taW5pdC94c2VydmVyLW5vZG0g Yi9tZXRhL3JlY2lwZXMtZ3JhcGhpY3MveDExLWNvbW1vbi94c2VydmVyLW5vZG0taW5pdC94c2Vy dmVyLW5vZG0KaW5kZXggYzcwN2E0Yi4uMDg1NjA4NCAxMDA3NTUKLS0tIGEvbWV0YS9yZWNpcGVz LWdyYXBoaWNzL3gxMS1jb21tb24veHNlcnZlci1ub2RtLWluaXQveHNlcnZlci1ub2RtCisrKyBi L21ldGEvcmVjaXBlcy1ncmFwaGljcy94MTEtY29tbW9uL3hzZXJ2ZXItbm9kbS1pbml0L3hzZXJ2 ZXItbm9kbQpAQCAtNDAsNyArNDAsNyBAQCBjYXNlICIkMSIgaW4KICAgICAgICAgICAgZmkKICAg ICAgICBmaQogICAgICAgICMgVXNpbmcgc3UgcmF0aGVyIHRoYW4gc3VkbyBhcyBsYXRlc3QgMS44 LjEgY2F1c2UgZmFpbHVyZSBbWU9DVE8gIzEyMTFdCi0gICAgICAgc3UgLWwgLWMgJy9ldGMvWDEx L1hzZXJ2ZXImJyAkdXNlcm5hbWUgCisgICAgICAgc3UgLXMgL2Jpbi9zaCAtbCAtYyAnL2V0Yy9Y MTEvWHNlcnZlciYnICR1c2VybmFtZQogICAgICAgICMgV2FpdCBmb3IgdGhlIGRlc2t0b3AgdG8g c2F5IGl0cyBmaW5pc2hlZCBsb2FkaW5nCiAgICAgICAgIyBiZWZvcmUgbG9hZGluZyB0aGUgcmVz dCBvZiB0aGUgc3lzdGVtCiAgICAgICAgIyBkYnVzLXdhaXQgb3JnLm1hdGNoYm94X3Byb2plY3Qu ZGVza3RvcCBMb2FkZWQKLS0gCjEuNy45LjUKCg==