2505 2012-05-25 23:54:01 +0000 qt4x11.bbclass forces to add qt4-x11-free dependency 2012-11-07 08:50:50 +0000 1 1 7 Build System, Metadata & Runtime OE-Core graphics 1.2 x86 Multiple VERIFIED FIXED Medium normal 1.3 M3 1 ftonello bluelightning corneliux.stoicescu meta.mr.watcher meta.watcher --- --- --- oldest_to_newest 21637 0 ftonello 2012-05-25 23:54:01 +0000 qt4x11.bbclass forces to add qt4-x11-free dependency to any recipe that inherits it. I think this is ugly and unnecessasry. If any recipe needs that depedency, the recipe needs to contain that. This will, also, cause to compile Qt4 free with Qt4 commercial, which was my case. And that makes difficult to debug. The patches removes that line and add the qt4-x11-free dependency to recipes that needed. 21638 1 539 ftonello 2012-05-25 23:55:52 +0000 Created attachment 539 Patch to fix that dependency 21640 2 ftonello 2012-05-26 00:01:49 +0000 *** Bug 2504 has been marked as a duplicate of this bug. *** 22037 3 bluelightning 2012-06-12 10:40:49 +0000 Rather than forcing every recipe to be changed I'd prefer to do something like this in the qt4-x11-free recipe: PROVIDES += "qt4-x11" You can do the same in your qt4-commercial recipe; then qt4x11.bbclass can add a DEPENDS on qt4-x11 rather than qt4-x11-free. You'd also want to set PREFERRED_PROVIDER_qt4-x11 = "qt4-commercial" in your local or distro configuration. Does that sound reasonable? 22211 4 ftonello 2012-06-14 17:54:18 +0000 Yes, it's better approach than changing every recipe. But qt4.inc still configuring Qt for opensource license. Perhaps we could add a QT_LICENSE variable, if it exists, then do something like this: echo yes | QT_LICENSE_FILE=${QT_LICENSE} ./configure -v \ ... What do you think? 23603 5 bluelightning 2012-07-30 12:26:37 +0000 I've finally got a chance to look into this today, sorry for the delay. I'm happy to add the above; I've also added a way to specify the license option (-opensource / -commercial). Patch will be sent out soon. 23619 6 bluelightning 2012-07-30 23:32:24 +0000 I've just sent the following patch to OE-Core: http://patchwork.openembedded.org/patch/33323/ Note that with this change applied, a commercial Qt4 (for X11) recipe should do the following: PROVIDES += "qt4-x11" QT_LICENSE_FILE = "license_filename" QT_LICENSE_FLAGS = "-commercial" 23657 7 bluelightning 2012-07-31 13:59:25 +0000 Fix merged in revision 72730329c804bd474655d2f4ab5aed02345fd1e3. 27263 8 corneliux.stoicescu 2012-11-06 15:18:08 +0000 I sent an email to the bug owner in order to set this to verified. Waiting for feedback. 27269 9 ftonello 2012-11-06 22:01:34 +0000 I didn't test but I checked the commit and it seems it's fixed. Thank you 27273 10 corneliux.stoicescu 2012-11-07 08:50:50 +0000 As per the above comment I am setting this to Verified. Please feel free to reopen if necessary. 539 2012-05-25 23:55:52 +0000 2012-05-25 23:55:52 +0000 Patch to fix that dependency remove-qt4-x11-free-forced-depedency.patch text/plain 890 ftonello ZGlmZiAtLWdpdCBhL21ldGEvY2xhc3Nlcy9xdDR4MTEuYmJjbGFzcyBiL21ldGEvY2xhc3Nlcy9x dDR4MTEuYmJjbGFzcwppbmRleCA2MTAzOTdkLi5mOTA4ZThhIDEwMDY0NAotLS0gYS9tZXRhL2Ns YXNzZXMvcXQ0eDExLmJiY2xhc3MKKysrIGIvbWV0YS9jbGFzc2VzL3F0NHgxMS5iYmNsYXNzCkBA IC0xLDUgKzEsMyBAQAotREVQRU5EU19wcmVwZW5kID0gIiR7QFsicXQ0LXgxMS1mcmVlICIsICIi XVsoZC5nZXRWYXIoJ0JQTicsIFRydWUpWzoxMl0gPT0gJ3F0NC14MTEtZnJlZScpXX0iCi0KIGlu aGVyaXQgcW1ha2UyCiAKIFFUX0JBU0VfTkFNRSA9ICJxdDQiCmRpZmYgLS1naXQgYS9tZXRhL3Jl Y2lwZXMtcXQvcXQtYXBwcy9xbW1wXzAuNS4yLmJiIGIvbWV0YS9yZWNpcGVzLXF0L3F0LWFwcHMv cW1tcF8wLjUuMi5iYgppbmRleCBkZjE4ZjkxLi40ZDE4NWM5IDEwMDY0NAotLS0gYS9tZXRhL3Jl Y2lwZXMtcXQvcXQtYXBwcy9xbW1wXzAuNS4yLmJiCisrKyBiL21ldGEvcmVjaXBlcy1xdC9xdC1h cHBzL3FtbXBfMC41LjIuYmIKQEAgLTUsOSArNSw5IEBAIExJQ0VOU0VfRkxBR1MgPSAiY29tbWVy Y2lhbCIKIExJQ19GSUxFU19DSEtTVU0gPSAiZmlsZTovL0NPUFlJTkc7bWQ1PTM5M2E1Y2E0NDVm Njk2NTg3M2VjYTAyNTlhMTdmODMzIgogU0VDVElPTiA9ICJtdWx0aW1lZGlhIgogCi1QUiA9ICJy MCIKK1BSID0gInIxIgogCi1ERVBFTkRTID0gInRhZ2xpYiBsaWJtYWQgbGlidm9yYmlzIGxpYm9n ZyBhbHNhLWxpYiIKK0RFUEVORFMgPSAicXQ0LXgxMS1mcmVlIHRhZ2xpYiBsaWJtYWQgbGlidm9y YmlzIGxpYm9nZyBhbHNhLWxpYiIKIAogU1JDX1VSSSA9ICJodHRwOi8vcW1tcC55bHNvZnR3YXJl LmNvbS9maWxlcy8ke0JQTn0tJHtQVn0udGFyLmJ6MiIKIAo=