<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>2610</bug_id>
          
          <creation_ts>2012-06-14 17:08:05 +0000</creation_ts>
          <short_desc>poky-tiny builds should be marked as failed if the image size is above a specified threshold</short_desc>
          <delta_ts>2014-07-11 09:52:54 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>5</classification_id>
          <classification>Infrastructure</classification>
          <product>AutoBuilder</product>
          <component>autobuilder</component>
          <version>unspecified</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugzilla.yoctoproject.org/show_bug.cgi?id=6396</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>1.7 M2</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Darren Hart">dvhart</reporter>
          <assigned_to name="Robert Yang">liezhi.yang</assigned_to>
          <cc>elizabeth.flanagan</cc>
    
    <cc>infras.ab.watcher</cc>
    
    <cc>Infras.watcher</cc>
    
    <cc>liezhi.yang</cc>
    
    <cc>Martin.Jansa</cc>
    
    <cc>richard.purdie</cc>
    
    <cc>sgw</cc>
    
    <cc>song.liu</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>Yes (doc changes required)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>22209</commentid>
    <comment_count>0</comment_count>
    <who name="Darren Hart">dvhart</who>
    <bug_when>2012-06-14 17:08:05 +0000</bug_when>
    <thetext>The goal of poky-tiny is to build small images. Sometimes unrelated changes result in packages being pulled into the dependency chain of poky-tiny builds. A QA test comparing the size of a poky-tiny core-image-minimal image to a threshold and marking the build as failed if it exceeds it would make this apparent earlier.

TODO: get the threshold</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>38056</commentid>
    <comment_count>1</comment_count>
    <who name="Saul Wold">sgw</who>
    <bug_when>2013-10-18 16:16:35 +0000</bug_when>
    <thetext>Could be sanity test related, so giving it to paul to look into</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>39413</commentid>
    <comment_count>2</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2013-12-16 11:41:44 +0000</bug_when>
    <thetext>This is something that needs to be checked at do_rootfs time; we can&apos;t know how large the image will be until that point.

A couple of questions:

1) Are we checking the maximum size of the output image file (in which case it is specific to the format type)? Although this is more complicated it does seem like the most sensible given that this is what you&apos;ll end up writing to storage on the target.

2) What size threshold do we want to set by default for poky-tiny?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>39915</commentid>
    <comment_count>3</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2014-01-17 18:11:23 +0000</bug_when>
    <thetext>Setting to NEEDINFO as per above.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>40937</commentid>
    <comment_count>4</comment_count>
    <who name="Darren Hart">dvhart</who>
    <bug_when>2014-03-06 18:04:47 +0000</bug_when>
    <thetext>How about a SANITY test that does a du -s for tmp/work/core-image-minimal/1.0-r0/rootfs ? That avoids all the fs / package (tar, cpio, etc.) overhead.

We should also check the kernel as that is a critical part of this, possibly with two unique THRESHOLD values, maybe:

TINY_ROOTFS_THRESHOLD
TINY_KERNEL_THRESHOLD

Threshold is tricky. Ideally it would be per-machine - but for now, even something like 4MB would be a good starting point. The THRESHOLD should be the easiest aspect of this to change... it should be a variable that a machine config can override as well.

For the kernel, 2MB would be a good start I think.

THis is assuming eglibc of course, with uclibc, the THRESHOLD for ROOTFS should be more like 2MB. Each could be defined in poky-tiny.conf I suspect, depending on the value of TCLIBC...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>43102</commentid>
    <comment_count>5</comment_count>
    <who name="Richard Purdie">richard.purdie</who>
    <bug_when>2014-05-03 18:04:46 +0000</bug_when>
    <thetext>We already have a setting for the kernel size check. We discussed this at OEDAM and there was general interest in some kind of image size check too as others have run into this kind of issue.

A generic image size check would therefore be useful.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>43103</commentid>
    <comment_count>6</comment_count>
    <who name="Martin Jansa">Martin.Jansa</who>
    <bug_when>2014-05-03 18:05:50 +0000</bug_when>
    <thetext>There is meta/lib/oe/image.py _get_rootfs_size function, so it should be enhanced a bit to issue warning when the rootfs exceeds the maximal size.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>43789</commentid>
    <comment_count>7</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2014-06-05 14:47:35 +0000</bug_when>
    <thetext>*** Bug 6396 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>44450</commentid>
    <comment_count>8</comment_count>
    <who name="Robert Yang">liezhi.yang</who>
    <bug_when>2014-07-11 09:52:54 +0000</bug_when>
    <thetext>Merged into master:

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=1cb9f7b00b5ede62a9546c39d798c876775b08c0
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=7e6eeeefdd0a92df5203d54a9b574957ed2a25ce</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>