2735 2012-07-11 06:04:04 +0000 scripts/send-pull-request cc:ing everyone mentioned in a resubmitted patch 2012-08-13 20:53:41 +0000 1 1 7 Build System, Metadata & Runtime Meta-yocto meta-yocto unspecified x86 Multiple VERIFIED NOTABUG Medium normal 1.3 M3 1 tom.zanussi dvhart jessica.zhang laurentiu.serban poky.bs.watcher poky.watcher --- --- --- oldest_to_newest 22984 0 tom.zanussi 2012-07-11 06:04:04 +0000 I just submitted a linux-yocto-3.0 kernel patchset to linux-yocto and was very unpleasantly surprised to see that the kernel devs mentioned in a resubmitted patch were automatically CC:ed on my Yocto e-mail cover letter as well as for the resubmitted patch: https://lists.yoctoproject.org/pipermail/yocto/2012-July/010060.html 23128 1 dvhart 2012-07-16 18:53:08 +0000 Which command did you use to send the patches? Did you use -a or -c? 23129 2 tom.zanussi 2012-07-16 18:58:05 +0000 -a 23131 3 dvhart 2012-07-16 21:14:37 +0000 OK, so this is working as documented in the help text: -a Send the cover letter to every recipient listed in Cc and Signed-off-by lines found in the cover letter and the patches. This option implies -c. At first I thought this was a repeat of the previous issue where patches being added to a recipe were being parsed and the CCs added - but it doesn't appear to be. The patch itself had these CC lines, so this is working as designed. What behavior did you expect from -a? 23132 4 tom.zanussi 2012-07-16 21:34:51 +0000 Ah, ok, yeah, my mistake, I've just become used to always using -a without thinking about it or reading the help text. Basically send-pull-request should just never be used for linux-yocto kernel patches, period. Now I remember why I used to just do them manually... 23133 5 dvhart 2012-07-16 21:57:01 +0000 (In reply to comment #4) > Ah, ok, yeah, my mistake, I've just become used to always using -a without > thinking about it or reading the help text. > > Basically send-pull-request should just never be used for linux-yocto kernel > patches, period. > > Now I remember why I used to just do them manually... If you don't use -a -c then it will do the right thing and only send to the list specified via the -t on the command line. This is how I do it. Note that git send-email will embarass you in exactly the same way if using a similar option. 23985 6 laurentiu.serban 2012-08-13 20:53:41 +0000 setting this to verified