2984 2012-08-21 18:36:43 +0000 Image details reports that "Your image is ready" even if changes to the included packages have been made 2012-09-11 08:17:31 +0000 1 1 7 Build System, Metadata & Runtime Hob hob 1.3 All Multiple VERIFIED FIXED Medium major 1.3 M4 1 cristian.iorga cristiana.voicu alexandru.damian andreea.b.proca belen.barros.pena cristian.iorga cristiana.voicu poky.bs.watcher poky.watcher sgw valentin.popa --- --- --- oldest_to_newest 24302 0 cristian.iorga 2012-08-21 18:36:43 +0000 After an image is built via Hob, the "Image details" screen is brought up. At this point, user decided to edit some packages (for example, adding some) via the "Edit packages" button. When the user is returned to "Image details" page, "Your image is ready" status is still reported, which is wrong. Correct status should be reported and buttons should be updated accordingly. For example, the "Run Image" button should be replaced by "Build Image" or "Rebuild image" ("Update image") button. 24607 1 cristiana.voicu 2012-08-29 14:01:45 +0000 After investigating this issue, I have found that after returning to "Image details" page, "Your image is ready" status should appear. In fact, "back" button should have another action( like a "cancel" button). After pressing the "back" button, all the changes you made in "packages selected" page should be the reseted, to reflect the image you already build. I will continue fixing the button. 24693 2 belen.barros.pena 2012-08-31 09:21:17 +0000 Hi Cristiana, You are right: that is the correct behaviour. I think some confusion comes from the fact that we have currently a 'back' button, instead of a 'cancel' button as the design specified (see bug 3012). When my image build completes, I arrive to the image details screen. If I: 1. select the 'edit packages' option, 2. make some changes to the packages 3. click the 'cancel' (currently 'stop') button, All my package changes should be ignored and I should return to exactly the same image details screen (only without the 'Image ready' notification). 24694 3 cristiana.voicu 2012-08-31 09:50:36 +0000 I have already sent a patch to change the action for "back" button, but I didn't think I should also remove 'Image ready' notification. I will send another patch for this. 24695 4 belen.barros.pena 2012-08-31 10:05:49 +0000 Sorry, Cristiana: my bad. I should have been more clear about the notification. I think we should remove it if we can. The notification tells you that everything went fine with the image building, so it only makes sense to have it when you land on the image details screen as a result of building something. If I then go away and come back, I already know the build finished successfully, so I should no longer need the notification. I hope that's ok. Thanks! Belen 24699 5 cristiana.voicu 2012-08-31 11:39:44 +0000 Yes you are right. I will change this soon. 24921 6 cristiana.voicu 2012-09-07 11:51:02 +0000 patches merged to master 25024 7 andreea.b.proca 2012-09-11 08:17:31 +0000 Verified in commit: 7250638ec895bc89508711831083d43b9e1e9826.