3111 2012-09-13 19:36:48 +0000 mpc8315 kernel fails to link due to uprobe changse 2012-10-10 13:40:25 +0000 1 1 7 Build System, Metadata & Runtime OE-Core kernel 1.3 mpc8315e-rdb Multiple VERIFIED FIXED Patch submitted to linux-yocto mailing list High critical 1.3 M5 1 sgw bruce.ashfield alexandrux.palalau bruce.ashfield tom.zanussi --- --- --- oldest_to_newest 25212 0 sgw 2012-09-13 19:36:48 +0000 http://autobuilder.yoctoproject.org:8010/builders/nightly-ppc/builds/598/steps/shell_52/logs/stdio 25213 1 sgw 2012-09-13 19:37:23 +0000 | arch/powerpc/kernel/built-in.o: In function `do_notify_resume': | /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.4.10+git8+e0374ce012e7e6fc8e5bb8b957addb0478950898_4+363a6f7e0c95aabec779a7ea3474662d191b935c-r4.1/linux/arch/powerpc/kernel/signal.c:193: undefined reference to `uprobe_notify_resume' | arch/powerpc/kernel/built-in.o: In function `arch_uprobe_exception_notify': | /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.4.10+git8+e0374ce012e7e6fc8e5bb8b957addb0478950898_4+363a6f7e0c95aabec779a7ea3474662d191b935c-r4.1/linux/arch/powerpc/kernel/uprobes.c:129: undefined reference to `uprobe_pre_sstep_notifier' | /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.4.10+git8+e0374ce012e7e6fc8e5bb8b957addb0478950898_4+363a6f7e0c95aabec779a7ea3474662d191b935c-r4.1/linux/arch/powerpc/kernel/uprobes.c:133: undefined reference to `uprobe_post_sstep_notifier' | kernel/built-in.o: In function `mmput': | /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.4.10+git8+e0374ce012e7e6fc8e5bb8b957addb0478950898_4+363a6f7e0c95aabec779a7ea3474662d191b935c-r4.1/linux/kernel/fork.c:580: undefined reference to `uprobe_clear_state' | kernel/built-in.o: In function `mm_release': | /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.4.10+git8+e0374ce012e7e6fc8e5bb8b957addb0478950898_4+363a6f7e0c95aabec779a7ea3474662d191b935c-r4.1/linux/kernel/fork.c:759: undefined reference to `uprobe_free_utask' | kernel/built-in.o: In function `dup_mm': | /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.4.10+git8+e0374ce012e7e6fc8e5bb8b957addb0478950898_4+363a6f7e0c95aabec779a7ea3474662d191b935c-r4.1/linux/kernel/fork.c:815: undefined reference to `uprobe_reset_state' | kernel/built-in.o: In function `dup_mmap': | /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.4.10+git8+e0374ce012e7e6fc8e5bb8b957addb0478950898_4+363a6f7e0c95aabec779a7ea3474662d191b935c-r4.1/linux/kernel/fork.c:430: undefined reference to `uprobe_mmap' | kernel/built-in.o: In function `copy_process': | /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.4.10+git8+e0374ce012e7e6fc8e5bb8b957addb0478950898_4+363a6f7e0c95aabec779a7ea3474662d191b935c-r4.1/linux/kernel/fork.c:1358: undefined reference to `uprobe_copy_process' | kernel/built-in.o: In function `get_signal_to_deliver': | /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.4.10+git8+e0374ce012e7e6fc8e5bb8b957addb0478950898_4+363a6f7e0c95aabec779a7ea3474662d191b935c-r4.1/linux/kernel/signal.c:2206: undefined reference to `uprobe_deny_signal' | kernel/built-in.o: In function `probe_event_enable': | /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.4.10+git8+e0374ce012e7e6fc8e5bb8b957addb0478950898_4+363a6f7e0c95aabec779a7ea3474662d191b935c-r4.1/linux/kernel/trace/trace_uprobe.c:550: undefined reference to `uprobe_register' | kernel/built-in.o: In function `probe_event_disable': | /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.4.10+git8+e0374ce012e7e6fc8e5bb8b957addb0478950898_4+363a6f7e0c95aabec779a7ea3474662d191b935c-r4.1/linux/kernel/trace/trace_uprobe.c:568: undefined reference to `uprobe_unregister' | mm/built-in.o: In function `unmap_single_vma': | /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.4.10+git8+e0374ce012e7e6fc8e5bb8b957addb0478950898_4+363a6f7e0c95aabec779a7ea3474662d191b935c-r4.1/linux/mm/memory.c:1311: undefined reference to `uprobe_munmap' | mm/built-in.o: In function `vma_adjust': | /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.4.10+git8+e0374ce012e7e6fc8e5bb8b957addb0478950898_4+363a6f7e0c95aabec779a7ea3474662d191b935c-r4.1/linux/mm/mmap.c:629: undefined reference to `uprobe_mmap' | /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.4.10+git8+e0374ce012e7e6fc8e5bb8b957addb0478950898_4+363a6f7e0c95aabec779a7ea3474662d191b935c-r4.1/linux/mm/mmap.c:637: undefined reference to `uprobe_munmap' | /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.4.10+git8+e0374ce012e7e6fc8e5bb8b957addb0478950898_4+363a6f7e0c95aabec779a7ea3474662d191b935c-r4.1/linux/mm/mmap.c:658: undefined reference to `uprobe_mmap' | /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.4.10+git8+e0374ce012e7e6fc8e5bb8b957addb0478950898_4+363a6f7e0c95aabec779a7ea3474662d191b935c-r4.1/linux/mm/mmap.c:552: undefined reference to `uprobe_munmap' | /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.4.10+git8+e0374ce012e7e6fc8e5bb8b957addb0478950898_4+363a6f7e0c95aabec779a7ea3474662d191b935c-r4.1/linux/mm/mmap.c:555: undefined reference to `uprobe_munmap' | /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.4.10+git8+e0374ce012e7e6fc8e5bb8b957addb0478950898_4+363a6f7e0c95aabec779a7ea3474662d191b935c-r4.1/linux/mm/mmap.c:632: undefined reference to `uprobe_mmap' | mm/built-in.o: In function `mmap_region': | /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.4.10+git8+e0374ce012e7e6fc8e5bb8b957addb0478950898_4+363a6f7e0c95aabec779a7ea3474662d191b935c-r4.1/linux/mm/mmap.c:1393: undefined reference to `uprobe_mmap' | mm/built-in.o: In function `insert_vm_struct': | /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.4.10+git8+e0374ce012e7e6fc8e5bb8b957addb0478950898_4+363a6f7e0c95aabec779a7ea3474662d191b935c-r4.1/linux/mm/mmap.c:2379: undefined reference to `uprobe_mmap' | mm/built-in.o: In function `copy_vma': | /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.4.10+git8+e0374ce012e7e6fc8e5bb8b957addb0478950898_4+363a6f7e0c95aabec779a7ea3474662d191b935c-r4.1/linux/mm/mmap.c:2452: undefined reference to `uprobe_mmap' | make[2]: *** [.tmp_vmlinux1] Error 1 | make[1]: *** [sub-make] Error 2 | make: *** [all] Error 2 | ERROR: oe_runmake failed 25214 2 bruce.ashfield 2012-09-13 19:38:07 +0000 This would be related to TomZ's uprobes/kprobes updates .. I'd suggest that he have a look :) 25215 3 bruce.ashfield 2012-09-13 19:41:40 +0000 It's just a matter of disabling the functionality for this board, or #ifdefing the patches. I can look into nuking them for the board. 25216 4 tom.zanussi 2012-09-13 19:43:06 +0000 My patches simply added the missing config options and turned them on. Looks like something was missing from the original patchset, which should work for powerpc. 25217 5 bruce.ashfield 2012-09-13 19:45:33 +0000 right. qemuppc definitely builds. Something is missing in the series for that arch/subarch. I'll start a build and disable it for that board, while we look into it more. A similar build issue was reported on another non-yocto board. 25218 6 tom.zanussi 2012-09-13 20:06:20 +0000 warning: (UPROBE_EVENT) selects UPROBES which has unmet direct dependencies (UPROBE_EVENT &&\ PERF_EVENTS) The UPROBE_EVENT config options appear in .config: CONFIG_ARCH_SUPPORTS_UPROBES=y CONFIG_UPROBES=y CONFIG_UPROBE_EVENT=y but PERF_EVENTS is missing for this board: # CONFIG_PERF_EVENTS is not set 25219 7 tom.zanussi 2012-09-13 20:18:22 +0000 So UPROBES depends on PERF_EVENTS, so one option would be to add PERF_EVENTS to the uprobes feature, but that seems backwards. Wondering why mpc8315 doesn't have PERF_EVENTS turned on already like everything else. 25220 8 bruce.ashfield 2012-09-13 20:22:01 +0000 Hmm. It should. I've reproduced the build failure now, will try to tweak that. It's much better to fix this build vs hiding it, so you are on the right track. 25222 9 bruce.ashfield 2012-09-13 20:43:48 +0000 Confirmed. It does just look like a missing config option for the board to get it up and building. But there's a missing dependency in the kernel, since if perf events is off, everything really should be off as well. I'll do a fix for the board config, but I'm going to take a few minutes to look into the dependency as well. 25223 10 bruce.ashfield 2012-09-13 20:57:36 +0000 I've patched the Kconfig line to select what it needs, this now builds out of the box. I pushed the new kernel, but will send the pull request in a bit. 25227 11 tom.zanussi 2012-09-13 22:48:23 +0000 So, looking a bit more into it, x86 always selects CONFIG_PERF_EVENTS, and CONFIG_PERF_EVENTS is also selected automatically if CONFIG_PROFILING is selected. CONFIG_PROFILING is selected by features/profiling/profiling.scc, which most of the BSPs do, but of course not mpc8315, so we see this error. Other BSPs may be at 3.0, in which case we also won't see the error since they don't have UPROBES. So, since UPROBES is after all dependent on PERF_EVENTS, PERF_EVENTS should be turned on by the UPROBES feature, which should fix this problem. 25228 12 bruce.ashfield 2012-09-13 22:50:17 +0000 ok. thanks for the confirmation, the mpc *should* be including that profiling fragment, but the select Kconfig fix is good as well. The following worked for me: http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-3.4/commit/?h=standard/base&id=59c3ff750831338d05ab67d5efd7fc101c451aff 25231 13 tom.zanussi 2012-09-13 23:05:21 +0000 Yeah, that should work, and probably makes more sense than the way things are now - i.e. selecting PERF_EVENTS if UPROBE_EVENTS is selected makes more sense to me than having UPROBES depend on PERF_EVENTS, which frankly to me is nonintuitive. I'll submit my patch to uprobes.cfg just to reflect the current situation and make sure they can't get out of sync. 25233 14 tom.zanussi 2012-09-14 00:49:43 +0000 Just a couple other things noticed while examining the current BSPS - all the qemu machines include profiling.scc but the meta-yocto-bsp BSPs other than atom-pc by virtue of inheriting common-pc don't and therefore don't get PERF_EVENTS and OPROFILE. Also, the powertop feature seems circular - profiling.cfg includes stuff for powertop, while powertop includes profiling.scc. 25250 15 bruce.ashfield 2012-09-14 12:29:40 +0000 commit ffc3b5ded372bdebcb610b7aac91ff56cabeddce in poky master. 26484 16 alexandrux.palalau 2012-10-10 13:40:25 +0000 Verified under master branch. Latest commit ID: 2c3e8280e67721d42d4be48a8e2c1e9ce9bb89fd