<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>3308</bug_id>
          
          <creation_ts>2012-10-18 17:14:07 +0000</creation_ts>
          <short_desc>Validate IMAGE_FEATURES values</short_desc>
          <delta_ts>2013-06-20 12:09:46 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>core</component>
          <version>1.3</version>
          <rep_platform>All</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>VERIFIED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>1.5</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Paul Eggleton">bluelightning</reporter>
          <assigned_to name="Paul Eggleton">bluelightning</assigned_to>
          <cc>corneliux.stoicescu</cc>
    
    <cc>jessica.zhang</cc>
    
    <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
    
    <cc>sgw</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>---</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>26749</commentid>
    <comment_count>0</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2012-10-18 17:14:07 +0000</bug_when>
    <thetext>It seems to be a common mistake for people to add package names into IMAGE_FEATURES in order to install them into their image. We don&apos;t currently validate items added to here so it is not clear to the user that it hasn&apos;t worked until they find that nothing changed in the image produced. It would not be hard to validate the values in IMAGE_FEATURES, so I think we should.

I have a very basic patch here to do this already but it needs further testing and cleanup.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>33516</commentid>
    <comment_count>1</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2013-06-03 17:14:05 +0000</bug_when>
    <thetext>Implementation merged to master, with a couple of follow-up fixes from Khem and Martin:

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=d63c8a1597c9bd0a838cb59ca461ac432b630a90
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=0c8173d7dcd5d3338f6619ad39cb17fc241a8123
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=fb89bb369be0863d7c1175fcf10c4860e547fd9c

As mentioned on the mailing list it would be nice to have list validation like this implemented generically in OE&apos;s type support, but that is a separate task.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>33995</commentid>
    <comment_count>2</comment_count>
    <who name="Stoicescu Cornel">corneliux.stoicescu</who>
    <bug_when>2013-06-20 12:09:46 +0000</bug_when>
    <thetext>Adding IMAGE_FEATURES += &quot; ssh-server-openssh&quot; in local.conf results in an error:

ERROR: &apos;ssh&apos; in IMAGE_FEATURES is not a valid image feature. Valid features: dbg-pkgs debug-tweaks dev-pkgs doc-pkgs eclipse-debug hwcodecs nfs-server package-management package-management ptest-pkgs qt4-pkgs read-only-rootfs splash ssh-server-dropbear ssh-server-openssh staticdev-pkgs tools-debug tools-profile tools-sdk tools-testapps x11 x11-base x11-sato
ERROR: Unable to parse /home/cornel/SSD/poky/meta/recipes-graphics/images/core-image-x11.bb: Exited with &quot;1&quot;
ERROR: &apos;ssh&apos; in IMAGE_FEATURES is not a valid image feature. Valid features: dbg-pkgs debug-tweaks dev-pkgs doc-pkgs eclipse-debug hwcodecs nfs-server package-management package-management ptest-pkgs qt4-pkgs read-only-rootfs splash ssh-server-dropbear ssh-server-openssh staticdev-pkgs tools-debug tools-profile tools-sdk tools-testapps x11 x11-base x11-sato
ERROR: &apos;ssh&apos; in IMAGE_FEATURES is not a valid image feature. Valid features: dbg-pkgs debug-tweaks dev-pkgs doc-pkgs eclipse-debug hwcodecs nfs-server package-management package-management ptest-pkgs qt4-pkgs read-only-rootfs splash ssh-server-dropbear ssh-server-openssh staticdev-pkgs tools-debug tools-profile tools-sdk tools-testapps x11 x11-base x11-sato
ERROR: Command execution failed: Exited with 1

Verified in master:e04e6dab0afa8f72bf001b0cc106cd13b7694a91</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>