3371 2012-10-31 15:06:39 +0000 Terminal (devshell, menuconfig) code broken in latest master 2012-12-05 14:57:29 +0000 1 1 7 Build System, Metadata & Runtime OE-Core core 1.4 All Multiple VERIFIED FIXED A raw solution, waiting for advices and suggestions Medium+ major 1.4 M1 1 bluelightning Qi.Chen alexandrux.palalau liezhi.yang meta.mr.watcher meta.watcher Qi.Chen richard.purdie sgw zhenfeng.zhao --- --- --- oldest_to_newest 27120 0 bluelightning 2012-10-31 15:06:39 +0000 With latest master if you run bitbake -c devshell <target> or bitbake -c devshell virtual/kernel, you get multiple terminals launched instead of just one. This has been traced back to the following revision - reverting this fixes the problem: http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=c45a7d127e76a43069f12483b7453a3778ae0126 27122 1 bluelightning 2012-10-31 15:10:01 +0000 Oops, that second example should have been bitbake -c menuconfig virtual/kernel. 27180 2 Qi.Chen 2012-11-02 06:39:53 +0000 %problem, cause, solution and a raw patch% A rough analysis about this issue. Any suggestion would be welcome. problem ------- 1) two terminals are launched instead of one 2) the environment is not correct, 'echo $PATH' for a verification cause ----- c76da87511d2668479745c2f18b8a9b8116c7489 in OE core changed the default behavior of terminal.bbclass Problem 1 may be caused by the os.environ not correctly set, as that commit removed "os.environ[export] = str(value)". Problem 2 is caused by passing wrong argument to the oe.terminal.spawn which invokes subprocess.Popen to do the actual job underneath. - oe.terminal.spawn(terminal, command, title, None, d) + oe.terminal.spawn(terminal, command, title, env, d) Changing the default fourth para from 'None' to env will override the environment in child process. The environment in child process in no longer the same with its parent which has the correct values for environment variables such as PATH. solution -------- Change all things back. The env argument is not needed, and what's more, it causes trouble. patch ----- diff --git a/meta/classes/terminal.bbclass b/meta/classes/terminal.bbclass index 51846c1..906fa58 100644 --- a/meta/classes/terminal.bbclass +++ b/meta/classes/terminal.bbclass @@ -15,19 +15,17 @@ def oe_terminal(command, title, d): import oe.data import oe.terminal - env = dict() - for export in oe.data.typed_value('OE_TERMINAL_EXPORTS', d): value = d.getVar(export, True) if value is not None: - env[export] = str(value) + os.environ[export] = str(value) terminal = oe.data.typed_value('OE_TERMINAL', d).lower() if terminal == 'none': bb.fatal('Devshell usage disabled with OE_TERMINAL') elif terminal != 'auto': try: - oe.terminal.spawn(terminal, command, title, env, d) + oe.terminal.spawn(terminal, command, title, None, d) return except oe.terminal.UnsupportedTerminal: bb.warn('Unsupported terminal "%s", defaulting to "auto"' % @@ -36,7 +34,7 @@ def oe_terminal(command, title, d): bb.fatal('Unable to spawn terminal %s: %s' % (terminal, exc)) try: - oe.terminal.spawn_preferred(command, title, env, d) + oe.terminal.spawn_preferred(command, title, None, d) except oe.terminal.NoSupportedTerminals: bb.fatal('No valid terminal found, unable to open devshell') except oe.terminal.ExecutionError as exc: 27181 3 Qi.Chen 2012-11-02 06:50:25 +0000 An explanation of the 'env' para in subprocess.Popen: "If env is not None, it must be a mapping that defines the environment variables for the new process; these are used instead of inheriting the current process’ environment, which is the default behavior." From: http://docs.python.org/2/library/subprocess.html#subprocess.Popen 27193 4 bluelightning 2012-11-02 10:05:10 +0000 I have to say I think we should just revert the patch in question. 27194 5 Qi.Chen 2012-11-02 10:23:24 +0000 (In reply to comment #4) > I have to say I think we should just revert the patch in question. Ah... Yes. Reverting it would be better. Thanks. 27362 6 richard.purdie 2012-11-12 16:11:42 +0000 Fixed in master: http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=05a1f4a5a32c6cc392fa4480732101d668cd6f77 http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=ad9ad06056bb9ee1f9da54d60dfabb3240798018 27998 7 alexandrux.palalau 2012-12-05 14:57:29 +0000 Switching to verified